You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/05 23:58:21 UTC
[PR] [ISSUE-3868][test] Deepen languagePreference tests with zh round-trip and storage failure fallback [rocketmq-dashboard]
yyqdbngt opened a new pull request, #3868:
URL: https://github.com/apache/rocketmq-dashboard/pull/3868
### Motivation
The existing `languagePreference` tests cover the default/unsupported fallback and the English round-trip. The Chinese round-trip and the storage-throw fallback were untested.
### Changes
- `round-trips the Chinese preference`: persisting `zh` survives a read-back through the same storage key.
- `falls back to Chinese when storage access throws`: an unavailable `localStorage.getItem` (security error) degrades to the Chinese default instead of crashing.
### Verification
```
./node_modules/.bin/vitest run src/i18n/languagePreference.test.ts # 4 passed
./node_modules/.bin/tsc --noEmit # clean
./node_modules/.bin/eslint src/i18n/languagePreference.test.ts # clean
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE-3868][test] Deepen languagePreference tests with zh round-trip and storage failure fallback [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3868: [ISSUE-3868][test] Deepen languagePreference tests with zh round-trip and storage failure fallback
URL: https://github.com/apache/rocketmq-dashboard/pull/3868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org