You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@oodt.apache.org by "Ricky Nguyen (Created) (JIRA)" <ji...@apache.org> on 2012/03/23 01:04:22 UTC
[jira] [Created] (OODT-429) filemgr query throws NPE when sorting
by key with possibly empty values
filemgr query throws NPE when sorting by key with possibly empty values
-----------------------------------------------------------------------
Key: OODT-429
URL: https://issues.apache.org/jira/browse/OODT-429
Project: OODT
Issue Type: Bug
Components: file manager
Affects Versions: 0.3
Reporter: Ricky Nguyen
Fix For: 0.4
For a given met element, if any product has a null value, the entire sort fails with NPE.
We should decide whether nulls appear at the beginning or the end of such a sort. My vote is at the end, since nulls are usually the least interesting value.
However, consider the use case of sorting by ProductReceivedTime. Sort only occurs in ascending order (I am not aware of descending capability). If nulls appeared at the end, it would be slightly difficult to get the latest product (programmatically). For this type of sort, it would be useful to put nulls at the beginning, or even remove them altogether. Thoughts?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-429) filemgr query throws NPE when sorting
by key with possibly empty values
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237138#comment-13237138 ]
jiraposter@reviews.apache.org commented on OODT-429:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4458/
-----------------------------------------------------------
(Updated 2012-03-23 21:19:16.059506)
Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl John, and Thomas Bennett.
Changes
-------
test with multiple nulls. since order of null items is indeterminate, take sublist of null items, then test size and test contains.
Summary
-------
putting nulls last
This addresses bug OODT-429.
https://issues.apache.org/jira/browse/OODT-429
Diffs (updated)
-----
trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResultComparator.java 1303205
trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResultComparator.java PRE-CREATION
Diff: https://reviews.apache.org/r/4458/diff
Testing
-------
wrote unit test
Thanks,
Ricky
> filemgr query throws NPE when sorting by key with possibly empty values
> -----------------------------------------------------------------------
>
> Key: OODT-429
> URL: https://issues.apache.org/jira/browse/OODT-429
> Project: OODT
> Issue Type: Bug
> Components: file manager
> Affects Versions: 0.3
> Reporter: Ricky Nguyen
> Fix For: 0.4
>
>
> For a given met element, if any product has a null value, the entire sort fails with NPE.
> We should decide whether nulls appear at the beginning or the end of such a sort. My vote is at the end, since nulls are usually the least interesting value.
> However, consider the use case of sorting by ProductReceivedTime. Sort only occurs in ascending order (I am not aware of descending capability). If nulls appeared at the end, it would be slightly difficult to get the latest product (programmatically). For this type of sort, it would be useful to put nulls at the beginning, or even remove them altogether. Thoughts?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-429) filemgr query throws NPE when sorting
by key with possibly empty values
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238475#comment-13238475 ]
jiraposter@reviews.apache.org commented on OODT-429:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4458/#review6348
-----------------------------------------------------------
Ship it!
LGTM.
trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResultComparator.java
<https://reviews.apache.org/r/4458/#comment13773>
Agreed.
- Chris
On 2012-03-23 21:19:16, Ricky Nguyen wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4458/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-23 21:19:16)
bq.
bq.
bq. Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl John, and Thomas Bennett.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. putting nulls last
bq.
bq.
bq. This addresses bug OODT-429.
bq. https://issues.apache.org/jira/browse/OODT-429
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResultComparator.java 1303205
bq. trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResultComparator.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4458/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. wrote unit test
bq.
bq.
bq. Thanks,
bq.
bq. Ricky
bq.
bq.
> filemgr query throws NPE when sorting by key with possibly empty values
> -----------------------------------------------------------------------
>
> Key: OODT-429
> URL: https://issues.apache.org/jira/browse/OODT-429
> Project: OODT
> Issue Type: Bug
> Components: file manager
> Affects Versions: 0.3
> Reporter: Ricky Nguyen
> Fix For: 0.4
>
>
> For a given met element, if any product has a null value, the entire sort fails with NPE.
> We should decide whether nulls appear at the beginning or the end of such a sort. My vote is at the end, since nulls are usually the least interesting value.
> However, consider the use case of sorting by ProductReceivedTime. Sort only occurs in ascending order (I am not aware of descending capability). If nulls appeared at the end, it would be slightly difficult to get the latest product (programmatically). For this type of sort, it would be useful to put nulls at the beginning, or even remove them altogether. Thoughts?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-429) filemgr query throws NPE when sorting
by key with possibly empty values
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238834#comment-13238834 ]
jiraposter@reviews.apache.org commented on OODT-429:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4458/#review6371
-----------------------------------------------------------
Ship it!
LGTM
- brian
On 2012-03-23 21:19:16, Ricky Nguyen wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4458/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-23 21:19:16)
bq.
bq.
bq. Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl John, and Thomas Bennett.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. putting nulls last
bq.
bq.
bq. This addresses bug OODT-429.
bq. https://issues.apache.org/jira/browse/OODT-429
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResultComparator.java 1303205
bq. trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResultComparator.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4458/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. wrote unit test
bq.
bq.
bq. Thanks,
bq.
bq. Ricky
bq.
bq.
> filemgr query throws NPE when sorting by key with possibly empty values
> -----------------------------------------------------------------------
>
> Key: OODT-429
> URL: https://issues.apache.org/jira/browse/OODT-429
> Project: OODT
> Issue Type: Bug
> Components: file manager
> Affects Versions: 0.3
> Reporter: Ricky Nguyen
> Fix For: 0.4
>
>
> For a given met element, if any product has a null value, the entire sort fails with NPE.
> We should decide whether nulls appear at the beginning or the end of such a sort. My vote is at the end, since nulls are usually the least interesting value.
> However, consider the use case of sorting by ProductReceivedTime. Sort only occurs in ascending order (I am not aware of descending capability). If nulls appeared at the end, it would be slightly difficult to get the latest product (programmatically). For this type of sort, it would be useful to put nulls at the beginning, or even remove them altogether. Thoughts?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-429) filemgr query throws NPE when sorting
by key with possibly empty values
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238833#comment-13238833 ]
jiraposter@reviews.apache.org commented on OODT-429:
----------------------------------------------------
bq. On 2012-03-26 21:06:00, brian Foster wrote:
bq. > trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResultComparator.java, line 48
bq. > <https://reviews.apache.org/r/4458/diff/2/?file=95128#file95128line48>
bq. >
bq. > i don't think this case is ever true... this checks that the 2 references are equal (i.e. pointing to the same object)... perhaps you meant: m1.equals(m2)... however if m1 is null, then NullPointerException will be thrown here
actually... my bad here... this checks the null == null case i asked for above... good idea!
- brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4458/#review6368
-----------------------------------------------------------
On 2012-03-23 21:19:16, Ricky Nguyen wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4458/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-23 21:19:16)
bq.
bq.
bq. Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl John, and Thomas Bennett.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. putting nulls last
bq.
bq.
bq. This addresses bug OODT-429.
bq. https://issues.apache.org/jira/browse/OODT-429
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResultComparator.java 1303205
bq. trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResultComparator.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4458/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. wrote unit test
bq.
bq.
bq. Thanks,
bq.
bq. Ricky
bq.
bq.
> filemgr query throws NPE when sorting by key with possibly empty values
> -----------------------------------------------------------------------
>
> Key: OODT-429
> URL: https://issues.apache.org/jira/browse/OODT-429
> Project: OODT
> Issue Type: Bug
> Components: file manager
> Affects Versions: 0.3
> Reporter: Ricky Nguyen
> Fix For: 0.4
>
>
> For a given met element, if any product has a null value, the entire sort fails with NPE.
> We should decide whether nulls appear at the beginning or the end of such a sort. My vote is at the end, since nulls are usually the least interesting value.
> However, consider the use case of sorting by ProductReceivedTime. Sort only occurs in ascending order (I am not aware of descending capability). If nulls appeared at the end, it would be slightly difficult to get the latest product (programmatically). For this type of sort, it would be useful to put nulls at the beginning, or even remove them altogether. Thoughts?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OODT-429) filemgr query throws NPE when sorting
by key with possibly empty values
Posted by "Ricky Nguyen (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ricky Nguyen resolved OODT-429.
-------------------------------
Resolution: Fixed
Committed revision 1305428.
> filemgr query throws NPE when sorting by key with possibly empty values
> -----------------------------------------------------------------------
>
> Key: OODT-429
> URL: https://issues.apache.org/jira/browse/OODT-429
> Project: OODT
> Issue Type: Bug
> Components: file manager
> Affects Versions: 0.3
> Reporter: Ricky Nguyen
> Fix For: 0.4
>
>
> For a given met element, if any product has a null value, the entire sort fails with NPE.
> We should decide whether nulls appear at the beginning or the end of such a sort. My vote is at the end, since nulls are usually the least interesting value.
> However, consider the use case of sorting by ProductReceivedTime. Sort only occurs in ascending order (I am not aware of descending capability). If nulls appeared at the end, it would be slightly difficult to get the latest product (programmatically). For this type of sort, it would be useful to put nulls at the beginning, or even remove them altogether. Thoughts?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-429) filemgr query throws NPE when sorting
by key with possibly empty values
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238829#comment-13238829 ]
jiraposter@reviews.apache.org commented on OODT-429:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4458/#review6368
-----------------------------------------------------------
trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResultComparator.java
<https://reviews.apache.org/r/4458/#comment13827>
i don't think this case is ever true... this checks that the 2 references are equal (i.e. pointing to the same object)... perhaps you meant: m1.equals(m2)... however if m1 is null, then NullPointerException will be thrown here
trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResultComparator.java
<https://reviews.apache.org/r/4458/#comment13829>
nice test... thanks!
- brian
On 2012-03-23 21:19:16, Ricky Nguyen wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4458/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-23 21:19:16)
bq.
bq.
bq. Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl John, and Thomas Bennett.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. putting nulls last
bq.
bq.
bq. This addresses bug OODT-429.
bq. https://issues.apache.org/jira/browse/OODT-429
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResultComparator.java 1303205
bq. trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResultComparator.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4458/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. wrote unit test
bq.
bq.
bq. Thanks,
bq.
bq. Ricky
bq.
bq.
> filemgr query throws NPE when sorting by key with possibly empty values
> -----------------------------------------------------------------------
>
> Key: OODT-429
> URL: https://issues.apache.org/jira/browse/OODT-429
> Project: OODT
> Issue Type: Bug
> Components: file manager
> Affects Versions: 0.3
> Reporter: Ricky Nguyen
> Fix For: 0.4
>
>
> For a given met element, if any product has a null value, the entire sort fails with NPE.
> We should decide whether nulls appear at the beginning or the end of such a sort. My vote is at the end, since nulls are usually the least interesting value.
> However, consider the use case of sorting by ProductReceivedTime. Sort only occurs in ascending order (I am not aware of descending capability). If nulls appeared at the end, it would be slightly difficult to get the latest product (programmatically). For this type of sort, it would be useful to put nulls at the beginning, or even remove them altogether. Thoughts?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-429) filemgr query throws NPE when sorting
by key with possibly empty values
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236437#comment-13236437 ]
jiraposter@reviews.apache.org commented on OODT-429:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4458/#review6282
-----------------------------------------------------------
Great patch!.... Couple comments
trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResultComparator.java
<https://reviews.apache.org/r/4458/#comment13625>
Should handle case where both are null... will produce faster sorting time in cases where there are several nulls... something along the lines of:
if (m1 == null) {
If (m2 == null) {
return 0;
}
return 1;
}
if (m2 == null) {
return -1;
}
trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResultComparator.java
<https://reviews.apache.org/r/4458/#comment13626>
Maybe add test case with multiple nulls?
- brian
On 2012-03-23 00:10:25, Ricky Nguyen wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4458/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-23 00:10:25)
bq.
bq.
bq. Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl John, and Thomas Bennett.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. putting nulls last
bq.
bq.
bq. This addresses bug OODT-429.
bq. https://issues.apache.org/jira/browse/OODT-429
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResultComparator.java 1303205
bq. trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResultComparator.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4458/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. wrote unit test
bq.
bq.
bq. Thanks,
bq.
bq. Ricky
bq.
bq.
> filemgr query throws NPE when sorting by key with possibly empty values
> -----------------------------------------------------------------------
>
> Key: OODT-429
> URL: https://issues.apache.org/jira/browse/OODT-429
> Project: OODT
> Issue Type: Bug
> Components: file manager
> Affects Versions: 0.3
> Reporter: Ricky Nguyen
> Fix For: 0.4
>
>
> For a given met element, if any product has a null value, the entire sort fails with NPE.
> We should decide whether nulls appear at the beginning or the end of such a sort. My vote is at the end, since nulls are usually the least interesting value.
> However, consider the use case of sorting by ProductReceivedTime. Sort only occurs in ascending order (I am not aware of descending capability). If nulls appeared at the end, it would be slightly difficult to get the latest product (programmatically). For this type of sort, it would be useful to put nulls at the beginning, or even remove them altogether. Thoughts?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-429) filemgr query throws NPE when sorting
by key with possibly empty values
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236208#comment-13236208 ]
jiraposter@reviews.apache.org commented on OODT-429:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4458/
-----------------------------------------------------------
Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl John, and Thomas Bennett.
Summary
-------
putting nulls last
This addresses bug OODT-429.
https://issues.apache.org/jira/browse/OODT-429
Diffs
-----
trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResultComparator.java 1303205
trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResultComparator.java PRE-CREATION
Diff: https://reviews.apache.org/r/4458/diff
Testing
-------
wrote unit test
Thanks,
Ricky
> filemgr query throws NPE when sorting by key with possibly empty values
> -----------------------------------------------------------------------
>
> Key: OODT-429
> URL: https://issues.apache.org/jira/browse/OODT-429
> Project: OODT
> Issue Type: Bug
> Components: file manager
> Affects Versions: 0.3
> Reporter: Ricky Nguyen
> Fix For: 0.4
>
>
> For a given met element, if any product has a null value, the entire sort fails with NPE.
> We should decide whether nulls appear at the beginning or the end of such a sort. My vote is at the end, since nulls are usually the least interesting value.
> However, consider the use case of sorting by ProductReceivedTime. Sort only occurs in ascending order (I am not aware of descending capability). If nulls appeared at the end, it would be slightly difficult to get the latest product (programmatically). For this type of sort, it would be useful to put nulls at the beginning, or even remove them altogether. Thoughts?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira