You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2020/12/30 07:00:09 UTC
[kudu-CR] KUDU-3225 Fixes error 'vld1q u8 x4' was not declared
huangtianhua223@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16907
Change subject: KUDU-3225 Fixes error 'vld1q_u8_x4' was not declared
......................................................................
KUDU-3225 Fixes error 'vld1q_u8_x4' was not declared
'vld1q_u8_x4' type was not defined in aarch64 platform,
forceinline it always.
Change-Id: I2538e6ca321e89edb46d54f620b305b8e005f173
---
M src/kudu/util/sse2neon.h
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/16907/1
--
To view, visit http://gerrit.cloudera.org:8080/16907
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2538e6ca321e89edb46d54f620b305b8e005f173
Gerrit-Change-Number: 16907
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
[kudu-CR] KUDU-3225 Fixes error 'vld1q u8 x4' was not declared
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
huangtianhua223@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/16907 )
Change subject: KUDU-3225 Fixes error 'vld1q_u8_x4' was not declared
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16907/1/src/kudu/util/sse2neon.h
File src/kudu/util/sse2neon.h:
http://gerrit.cloudera.org:8080/#/c/16907/1/src/kudu/util/sse2neon.h@183
PS1, Line 183: __aarch64__
> I'm curious: would this compile with GCC 10 on ARM?
GCC does not implement the vld1q_u8_x4() intrinsic, so maybe we should follow the community solution to modify to __GNUC__ <= 9, see https://github.com/DLTcollab/sse2neon/pull/31/files
--
To view, visit http://gerrit.cloudera.org:8080/16907
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2538e6ca321e89edb46d54f620b305b8e005f173
Gerrit-Change-Number: 16907
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jan 2021 06:29:29 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3225 Fixes error 'vld1q u8 x4' was not declared
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16907 )
Change subject: KUDU-3225 Fixes error 'vld1q_u8_x4' was not declared
......................................................................
Patch Set 3: Code-Review+2
I don't have ARM machine to test this, but I assume this works for you as expected :)
Thank you for the fix!
--
To view, visit http://gerrit.cloudera.org:8080/16907
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2538e6ca321e89edb46d54f620b305b8e005f173
Gerrit-Change-Number: 16907
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jan 2021 04:46:33 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3225 Fixes error 'vld1q u8 x4' was not declared
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16907 )
Change subject: KUDU-3225 Fixes error 'vld1q_u8_x4' was not declared
......................................................................
KUDU-3225 Fixes error 'vld1q_u8_x4' was not declared
GCC does not implement 'vld1q_u8_x4' instrinsic, to forceinline
it for GCC versions smaller than or equal to 9 which as default
version of Ubuntu 20.04.
Change-Id: I2538e6ca321e89edb46d54f620b305b8e005f173
Reviewed-on: http://gerrit.cloudera.org:8080/16907
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/util/sse2neon.h
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16907
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2538e6ca321e89edb46d54f620b305b8e005f173
Gerrit-Change-Number: 16907
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[kudu-CR] KUDU-3225 Fixes error 'vld1q u8 x4' was not declared
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16907 )
Change subject: KUDU-3225 Fixes error 'vld1q_u8_x4' was not declared
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/16907/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16907/1//COMMIT_MSG@10
PS1, Line 10: always
I might be missing something, but it seems the updated code introduces vld1q_u8_x4 only for non-clang case, no?
http://gerrit.cloudera.org:8080/#/c/16907/1/src/kudu/util/sse2neon.h
File src/kudu/util/sse2neon.h:
http://gerrit.cloudera.org:8080/#/c/16907/1/src/kudu/util/sse2neon.h@183
PS1, Line 183: __aarch64__
I'm curious: would this compile with GCC 10 on ARM?
It seems this should be defined only for GCC 9 and older. At least, that's so at https://github.com/DLTcollab/sse2neon/blob/471743745dd09798fb7df87a9b7f31f543aa31da/sse2neon.h#L303-L316
--
To view, visit http://gerrit.cloudera.org:8080/16907
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2538e6ca321e89edb46d54f620b305b8e005f173
Gerrit-Change-Number: 16907
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Jan 2021 17:28:44 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3225 Fixes error 'vld1q u8 x4' was not declared
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16907 )
Change subject: KUDU-3225 Fixes error 'vld1q_u8_x4' was not declared
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16907/1/src/kudu/util/sse2neon.h
File src/kudu/util/sse2neon.h:
http://gerrit.cloudera.org:8080/#/c/16907/1/src/kudu/util/sse2neon.h@183
PS1, Line 183: __aarch64__
> GCC does not implement the vld1q_u8_x4() intrinsic, so maybe we should foll
Exactly my point: that's how it's done at https://github.com/DLTcollab/sse2neon/blob/471743745dd09798fb7df87a9b7f31f543aa31da/sse2neon.h#L303-L316
--
To view, visit http://gerrit.cloudera.org:8080/16907
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2538e6ca321e89edb46d54f620b305b8e005f173
Gerrit-Change-Number: 16907
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jan 2021 06:35:15 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3225 Fixes error 'vld1q u8 x4' was not declared
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
huangtianhua223@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/16907 )
Change subject: KUDU-3225 Fixes error 'vld1q_u8_x4' was not declared
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16907/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16907/2//COMMIT_MSG@10
PS2, Line 10: for GCC versions smaller than or equal to 9.3
> nit: it seems this need to be updated to correspond to the newer code in PS
Done
--
To view, visit http://gerrit.cloudera.org:8080/16907
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2538e6ca321e89edb46d54f620b305b8e005f173
Gerrit-Change-Number: 16907
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jan 2021 08:17:51 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3225 Fixes error 'vld1q u8 x4' was not declared
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
huangtianhua223@gmail.com has removed Tony Foerster from this change. ( http://gerrit.cloudera.org:8080/16907 )
Change subject: KUDU-3225 Fixes error 'vld1q_u8_x4' was not declared
......................................................................
Removed reviewer Tony Foerster.
--
To view, visit http://gerrit.cloudera.org:8080/16907
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I2538e6ca321e89edb46d54f620b305b8e005f173
Gerrit-Change-Number: 16907
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-3225 Fixes error 'vld1q u8 x4' was not declared
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16907
to look at the new patch set (#2).
Change subject: KUDU-3225 Fixes error 'vld1q_u8_x4' was not declared
......................................................................
KUDU-3225 Fixes error 'vld1q_u8_x4' was not declared
GCC does not implement 'vld1q_u8_x4' instrinsic, to forceinline
it for GCC versions smaller than or equal to 9.3 which as default
version of Ubuntu 20.04.
Change-Id: I2538e6ca321e89edb46d54f620b305b8e005f173
---
M src/kudu/util/sse2neon.h
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/16907/2
--
To view, visit http://gerrit.cloudera.org:8080/16907
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2538e6ca321e89edb46d54f620b305b8e005f173
Gerrit-Change-Number: 16907
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[kudu-CR] KUDU-3225 Fixes error 'vld1q u8 x4' was not declared
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16907 )
Change subject: KUDU-3225 Fixes error 'vld1q_u8_x4' was not declared
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Looks good to me, just a nit to update the commit description.
http://gerrit.cloudera.org:8080/#/c/16907/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16907/2//COMMIT_MSG@10
PS2, Line 10: for GCC versions smaller than or equal to 9.3
nit: it seems this need to be updated to correspond to the newer code in PS2
--
To view, visit http://gerrit.cloudera.org:8080/16907
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2538e6ca321e89edb46d54f620b305b8e005f173
Gerrit-Change-Number: 16907
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jan 2021 07:19:54 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3225 Fixes error 'vld1q u8 x4' was not declared
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16907
to look at the new patch set (#3).
Change subject: KUDU-3225 Fixes error 'vld1q_u8_x4' was not declared
......................................................................
KUDU-3225 Fixes error 'vld1q_u8_x4' was not declared
GCC does not implement 'vld1q_u8_x4' instrinsic, to forceinline
it for GCC versions smaller than or equal to 9 which as default
version of Ubuntu 20.04.
Change-Id: I2538e6ca321e89edb46d54f620b305b8e005f173
---
M src/kudu/util/sse2neon.h
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/16907/3
--
To view, visit http://gerrit.cloudera.org:8080/16907
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2538e6ca321e89edb46d54f620b305b8e005f173
Gerrit-Change-Number: 16907
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[kudu-CR] KUDU-3225 Fixes error 'vld1q u8 x4' was not declared
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16907 )
Change subject: KUDU-3225 Fixes error 'vld1q_u8_x4' was not declared
......................................................................
Patch Set 2:
> Or maybe we only follow the community to change it if needed later?
Yes, I think it's easier to keep it in sync with the upstream version as much as possible unless there is a particular reason to do otherwise.
--
To view, visit http://gerrit.cloudera.org:8080/16907
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2538e6ca321e89edb46d54f620b305b8e005f173
Gerrit-Change-Number: 16907
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jan 2021 07:18:03 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3225 Fixes error 'vld1q u8 x4' was not declared
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
huangtianhua223@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/16907 )
Change subject: KUDU-3225 Fixes error 'vld1q_u8_x4' was not declared
......................................................................
Patch Set 1:
Or maybe we only follow the community to change it if needed later?
--
To view, visit http://gerrit.cloudera.org:8080/16907
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2538e6ca321e89edb46d54f620b305b8e005f173
Gerrit-Change-Number: 16907
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jan 2021 06:46:52 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3225 Fixes error 'vld1q u8 x4' was not declared
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
huangtianhua223@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/16907 )
Change subject: KUDU-3225 Fixes error 'vld1q_u8_x4' was not declared
......................................................................
Patch Set 1:
I might be missing something, but it seems the updated code introduces vld1q_u8_x4 only for non-clang case, no?
--- Yes, clang has defined the type 'vld1q_u8_x4'.
--
To view, visit http://gerrit.cloudera.org:8080/16907
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2538e6ca321e89edb46d54f620b305b8e005f173
Gerrit-Change-Number: 16907
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jan 2021 04:18:11 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3225 Fixes error 'vld1q u8 x4' was not declared
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
huangtianhua223@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/16907 )
Change subject: KUDU-3225 Fixes error 'vld1q_u8_x4' was not declared
......................................................................
Patch Set 1:
But if you see the comment of https://github.com/DLTcollab/sse2neon/pull/31, you will find:
"As I search the source code on the GCC github, it does not contain vld1q_u8_x4.
The newest release version is GCC 9.3, hence the modification is acceptable.
But it needs to be taken care with as the newer GCC is released."
Now the lastest stable release of GCC is 10.2, so it doesn't work if we forceinline only for the versions <= 9.3
--
To view, visit http://gerrit.cloudera.org:8080/16907
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2538e6ca321e89edb46d54f620b305b8e005f173
Gerrit-Change-Number: 16907
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jan 2021 06:45:05 +0000
Gerrit-HasComments: No