Re: [PR] Add Primitive time/timestamp_nanos/timestampntz_nanos/uuid test file [parquet-testing]

["mapleFU (via GitHub)" <gi...@apache.org>]

mapleFU commented on code in PR #92:
URL: https://github.com/apache/parquet-testing/pull/92#discussion_r2273369119


##########
variant/regen.py:
##########
@@ -75,12 +75,7 @@
 INSERT INTO T VALUES ('primitive_binary', X'31337deadbeefcafe'::Variant);
 INSERT INTO T VALUES ('primitive_string', 'This string is longer than 64 bytes and therefore does not fit in a short_string and it also includes several non ascii characters such as 🐢, 💖, ♥️, 🎣 and 🤦!!'::Variant);
 
--- https://github.com/apache/parquet-testing/issues/79
--- is not clear how to create the following types using Spark SQL
--- TODO TimeNTZ                    (Type ID 17)
--- TODO 'timestamp with timezone (NANOS)'  (Type ID 18)
--- TODO 'timestamp with time zone (NANOS)' (Type ID 19)
--- TODO 'UUID'                     (Type ID 20)
+-- binary artifacts of 'TimeNTZ'/'timestamp with timezone (NANOS)'/'timestamp with time zone (NANOS)'/'UUID' was generated by the iceberg test code, please ref to https://github.com/apache/parquet-testing/pull/92 for more detail

Review Comment:
   timestamp with timezone is duplicated?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org