You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "hyz1994121 (via GitHub)" <gi...@apache.org> on 2023/03/09 08:55:28 UTC
[GitHub] [shardingsphere] hyz1994121 opened a new pull request, #24523: add classpath parser to support apollo config
hyz1994121 opened a new pull request, #24523:
URL: https://github.com/apache/shardingsphere/pull/24523
Fixes #24498 .
Changes proposed in this pull request:
-
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [x] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [x] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] hyz1994121 commented on a diff in pull request #24523: add classpath parser to support apollo config
Posted by "hyz1994121 (via GitHub)" <gi...@apache.org>.
hyz1994121 commented on code in PR #24523:
URL: https://github.com/apache/shardingsphere/pull/24523#discussion_r1136799098
##########
jdbc/core/pom.xml:
##########
@@ -220,6 +220,10 @@
<groupId>com.ctrip.framework.apollo</groupId>
<artifactId>apollo-client</artifactId>
</dependency>
-
+
+ <dependency>
Review Comment:
in my opinion is irreplaceable，maybe you guys have more idea. we can discuss
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on a diff in pull request #24523: add classpath parser to support apollo config
Posted by "TeslaCN (via GitHub)" <gi...@apache.org>.
TeslaCN commented on code in PR #24523:
URL: https://github.com/apache/shardingsphere/pull/24523#discussion_r1136459187
##########
jdbc/core/pom.xml:
##########
@@ -220,6 +220,10 @@
<groupId>com.ctrip.framework.apollo</groupId>
<artifactId>apollo-client</artifactId>
</dependency>
-
+
+ <dependency>
Review Comment:
Is this dependency irreplaceable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhaojinchao95 commented on pull request #24523: add classpath parser to support apollo config
Posted by "zhaojinchao95 (via GitHub)" <gi...@apache.org>.
zhaojinchao95 commented on PR #24523:
URL: https://github.com/apache/shardingsphere/pull/24523#issuecomment-1468185922
> is there anyone can help me review?
Hi, thank you for your feedback, And i think this function are provided, you can see `ApolloDriverURLProvider.class`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] hyz1994121 commented on pull request #24523: add classpath parser to support apollo config
Posted by "hyz1994121 (via GitHub)" <gi...@apache.org>.
hyz1994121 commented on PR #24523:
URL: https://github.com/apache/shardingsphere/pull/24523#issuecomment-1469694670
> > is there anyone can help me review?
>
> Hi, thank you for your pull request, And i think this function are provided, you can see `ApolloDriverURLProvider.class`
nonono, in ApolloDriverURLProvider.class，we must set the all yaml file into my apollo,
in my suggesstion, we can only use some ${} for my config value, which means i could not change my apollo config, i just change the config yaml in my project, and in my company, we use some placeholder for some account or password, in some jar package, program can replace the real password to the placeholder. so i provide this parser for the real yaml file in project
and the placeholder in apollo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] hyz1994121 closed pull request #24523: add classpath parser to support apollo config
Posted by "hyz1994121 (via GitHub)" <gi...@apache.org>.
hyz1994121 closed pull request #24523: add classpath parser to support apollo config
URL: https://github.com/apache/shardingsphere/pull/24523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] hyz1994121 commented on pull request #24523: add classpath parser to support apollo config
Posted by "hyz1994121 (via GitHub)" <gi...@apache.org>.
hyz1994121 commented on PR #24523:
URL: https://github.com/apache/shardingsphere/pull/24523#issuecomment-1465665995
is there anyone can help me review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org