You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/27 07:12:48 UTC
[GitHub] [apisix] spacewander commented on a change in pull request #2869: fix: start server failure
spacewander commented on a change in pull request #2869:
URL: https://github.com/apache/apisix/pull/2869#discussion_r531417853
##########
File path: Makefile
##########
@@ -86,6 +86,8 @@ run: default
ifeq ("$(wildcard logs/nginx.pid)", "")
mkdir -p logs
$(OR_EXEC) -p $$PWD/ -c $$PWD/conf/nginx.conf
+else ifeq ("$(shell lsof -p $(shell cat logs/nginx.pid))", "")
+ $(OR_EXEC) -p $$PWD/ -c $$PWD/conf/nginx.conf
Review comment:
Would be better if we can output the reason to start APISIX even the `nginx.pid` exists.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org