You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2009/12/22 23:53:29 UTC
[jira] Created: (AVRO-263) avroj tools should return exit codes
avroj tools should return exit codes
------------------------------------
Key: AVRO-263
URL: https://issues.apache.org/jira/browse/AVRO-263
Project: Avro
Issue Type: Improvement
Components: java
Affects Versions: 1.2.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
Priority: Minor
avroj should exit with a non-zero exit code for error conditions. The JVM already does this for exceptions, but same should be true of usage messages, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-263) avroj tools should return exit codes
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated AVRO-263:
-----------------------------
Status: Patch Available (was: Open)
> avroj tools should return exit codes
> ------------------------------------
>
> Key: AVRO-263
> URL: https://issues.apache.org/jira/browse/AVRO-263
> Project: Avro
> Issue Type: Improvement
> Components: java
> Affects Versions: 1.2.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: avro-263.txt
>
>
> avroj should exit with a non-zero exit code for error conditions. The JVM already does this for exceptions, but same should be true of usage messages, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-263) avroj tools should return exit codes
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated AVRO-263:
------------------------------
Resolution: Fixed
Fix Version/s: 1.3.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Todd!
> avroj tools should return exit codes
> ------------------------------------
>
> Key: AVRO-263
> URL: https://issues.apache.org/jira/browse/AVRO-263
> Project: Avro
> Issue Type: Improvement
> Components: java
> Affects Versions: 1.2.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 1.3.0
>
> Attachments: avro-263.txt, avro-263.txt
>
>
> avroj should exit with a non-zero exit code for error conditions. The JVM already does this for exceptions, but same should be true of usage messages, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-263) avroj tools should return exit codes
Posted by "Philip Zeyliger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793844#action_12793844 ]
Philip Zeyliger commented on AVRO-263:
--------------------------------------
Looks good.
Why did you choose to return -1 sometimes, but 1 sometimes? I'd rather see > 0 for errors consistently, and 0 for success.
> avroj tools should return exit codes
> ------------------------------------
>
> Key: AVRO-263
> URL: https://issues.apache.org/jira/browse/AVRO-263
> Project: Avro
> Issue Type: Improvement
> Components: java
> Affects Versions: 1.2.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: avro-263.txt
>
>
> avroj should exit with a non-zero exit code for error conditions. The JVM already does this for exceptions, but same should be true of usage messages, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-263) avroj tools should return exit codes
Posted by "Philip Zeyliger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793878#action_12793878 ]
Philip Zeyliger commented on AVRO-263:
--------------------------------------
+1 as far as I'm concerned.
> avroj tools should return exit codes
> ------------------------------------
>
> Key: AVRO-263
> URL: https://issues.apache.org/jira/browse/AVRO-263
> Project: Avro
> Issue Type: Improvement
> Components: java
> Affects Versions: 1.2.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: avro-263.txt, avro-263.txt
>
>
> avroj should exit with a non-zero exit code for error conditions. The JVM already does this for exceptions, but same should be true of usage messages, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-263) avroj tools should return exit codes
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated AVRO-263:
-----------------------------
Attachment: avro-263.txt
bq. Why did you choose to return -1 sometimes, but 1 sometimes?
No reason at all. Fixed to always return 1 for errors in this new patch. Thanks.
> avroj tools should return exit codes
> ------------------------------------
>
> Key: AVRO-263
> URL: https://issues.apache.org/jira/browse/AVRO-263
> Project: Avro
> Issue Type: Improvement
> Components: java
> Affects Versions: 1.2.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: avro-263.txt, avro-263.txt
>
>
> avroj should exit with a non-zero exit code for error conditions. The JVM already does this for exceptions, but same should be true of usage messages, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-263) avroj tools should return exit codes
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated AVRO-263:
-----------------------------
Attachment: avro-263.txt
pretty trivial patch
> avroj tools should return exit codes
> ------------------------------------
>
> Key: AVRO-263
> URL: https://issues.apache.org/jira/browse/AVRO-263
> Project: Avro
> Issue Type: Improvement
> Components: java
> Affects Versions: 1.2.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: avro-263.txt
>
>
> avroj should exit with a non-zero exit code for error conditions. The JVM already does this for exceptions, but same should be true of usage messages, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.