DO NOT REPLY [Bug 34832] New: - [Shale] Problems with CommonsValidator on the server side.

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=34832>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34832

           Summary: [Shale] Problems with CommonsValidator on the server
                    side.
           Product: Struts
           Version: Nightly Build
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Shale
        AssignedTo: dev@struts.apache.org
        ReportedBy: manklu@web.de


At the moment I see two problematic areas.

- The 'required' validation doesn't work on the server.

- All validations which need a String as value may translate the converted
  value back to a String. This has the following disadvantages:

  -- Validation depends on the toString method and not on the user input.

  -- It's impossible to control a sloppy converter. (Enter an invalid value in
     a field with a 'numberConverter', and you know what I mean).

In addition, I think the displayed value in the error message should be the
submitted and not the converted value.

A possible solution could look as follows:

- If the 'required' validation is configured for server side validation, an
  exception with a helpful error message is thrown.

- Instead of converting the value back to a String, use directly the submitted
  value.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org