You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "lupyuen (via GitHub)" <gi...@apache.org> on 2024/09/20 06:46:05 UTC
[I] [Feedback] PR Review Bot [nuttx]
lupyuen opened a new issue, #13552:
URL: https://github.com/apache/nuttx/issues/13552
### Description
Please provide your feedback for the [NuttX PR Review Bot](https://github.com/apache/nuttx/pull/13494#issuecomment-2357371589). Thanks!
### Verification
- [X] I have verified before submitting the report.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feedback] PR Review Bot [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on issue #13552:
URL: https://github.com/apache/nuttx/issues/13552#issuecomment-2363708441
Thank you @lupyuen I think it is better not to include it to avoid inducing contributors to wrong direction.
It could be something that reviewers could do better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feedback] PR Review Bot [nuttx]
Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on issue #13552:
URL: https://github.com/apache/nuttx/issues/13552#issuecomment-2362959214
Earlier Discussion: https://github.com/apache/nuttx/pull/13494#issuecomment-2357371589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feedback] PR Review Bot [nuttx]
Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on issue #13552:
URL: https://github.com/apache/nuttx/issues/13552#issuecomment-2363663248
> A suggestion like this shouldn't be based solely on the number of commits in PR.
> What should be squashed and what shouldn't require a greater understanding of PR content.
Sorry @cederom and @acassis: What are your thoughts about this? Shall I remove the "Squash Commit" message, since our bot can't analyse the PR Content? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feedback] PR Review Bot [nuttx]
Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on issue #13552:
URL: https://github.com/apache/nuttx/issues/13552#issuecomment-2363695601
OK I removed the check for Squash Commits, I don't we're ready to handle it now :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feedback] PR Review Bot [nuttx]
Posted by "resyfer (via GitHub)" <gi...@apache.org>.
resyfer commented on issue #13552:
URL: https://github.com/apache/nuttx/issues/13552#issuecomment-2428448029
A suggestion to add a way to trigger the bot again. For example...if it gave some feedback, and I improved it, I don't have any way of checking it again without creating another PR (which would mean wasted GH checks as PR text and build runs are often unrelated).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feedback] PR Review Bot [nuttx]
Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl commented on issue #13552:
URL: https://github.com/apache/nuttx/issues/13552#issuecomment-2363653657
My comment on this message from bot:
> Squash The Commits: This PR contains 2 Commits. Please Squash the Multiple Commits into a Single Commit.
A suggestion like this shouldn't be based solely on the number of commits in PR.
What should be squashed and what shouldn't require a greater understanding of PR content.
Having multiple commits in one PR isn't always bad. Sometimes it's even necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feedback] PR Review Bot [nuttx]
Posted by "resyfer (via GitHub)" <gi...@apache.org>.
resyfer commented on issue #13552:
URL: https://github.com/apache/nuttx/issues/13552#issuecomment-2428425398
PR Text:
```
## Testing
...
Target(s): arch(sim), sim:mnemofs.
```
Bot reply:
```
Target Specificity: "sim:mnemofs" is good, but be even more specific if possible (e.g., which simulator, exact config used). More detail makes it easier for reviewers to reproduce your results.
```
This _might_ be due to less fine tuning for the `sim` cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feedback] PR Review Bot [nuttx]
Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl commented on issue #13552:
URL: https://github.com/apache/nuttx/issues/13552#issuecomment-2363675164
maybe we can just change "Please squash commits" to "consider squashing commits if that makes sense for this PR" (or something similar)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feedback] PR Review Bot [nuttx]
Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on issue #13552:
URL: https://github.com/apache/nuttx/issues/13552#issuecomment-2367958326
> Yes we need increase PR and git commit descriptions quality (both need to be self explanatory).. bot was created to help.. you can .. wait was there this nice copy-paste section where all sections were filled in already before
@cederom Yeah that's the problem with LLMs, we can't force it to say the same thing all the time :-) It seems to have a mind of its own / multiple personas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org