(brooklyn-server) 01/03: remove redundant log warning on process workflow steps with non-zero exit code

[he...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

heneveld pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/brooklyn-server.git

commit b0605956a0e65e7b969fd41e4bd60429e94a5a54
Author: Alex Heneveld <al...@cloudsoft.io>
AuthorDate: Fri Feb 2 18:37:13 2024 +0000

    remove redundant log warning on process workflow steps with non-zero exit code
---
 .../apache/brooklyn/core/workflow/steps/external/SshWorkflowStep.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/core/src/main/java/org/apache/brooklyn/core/workflow/steps/external/SshWorkflowStep.java b/core/src/main/java/org/apache/brooklyn/core/workflow/steps/external/SshWorkflowStep.java
index 32743191a1..c28a6d393e 100644
--- a/core/src/main/java/org/apache/brooklyn/core/workflow/steps/external/SshWorkflowStep.java
+++ b/core/src/main/java/org/apache/brooklyn/core/workflow/steps/external/SshWorkflowStep.java
@@ -90,7 +90,7 @@ public class SshWorkflowStep extends WorkflowStepDefinition {
 
     public static <U, T extends ProcessTaskFactory<U>> ProcessTaskFactory<Map<?,?>> customizeProcessTaskFactory(WorkflowStepInstanceExecutionContext context, T tf) {
         DslPredicates.DslPredicate<Integer> exitcode = context.getInput(EXIT_CODE);
-        if (exitcode!=null) tf.allowingNonZeroExitCode();
+        tf.allowingNonZeroExitCode(); // we check it ourselves below; setting this eliminates a warning log message from the subsystem
         Map<String, Object> env = context.getInput(ENV);
         if (env!=null) tf.environmentVariables(new ShellEnvironmentSerializer(context.getWorkflowExectionContext().getManagementContext()).serialize(env));
         Integer maxLength = context.getInput(OUTPUT_MAX_SIZE);