[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #97: [FLINK-27335] Optimize async compaction in MergeTreeWriter

[GitBox <gi...@apache.org>]

tsreaper commented on code in PR #97:
URL: https://github.com/apache/flink-table-store/pull/97#discussion_r858346622


##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/MergeTreeOptions.java:
##########
@@ -115,6 +125,7 @@ public MergeTreeOptions(
         this.pageSize = pageSize;
         this.targetFileSize = targetFileSize;
         this.numSortedRunMax = numSortedRunMax;
+        this.numSortedRunStopTrigger = Math.max(numSortedRunMax, numSortedRunStopTrigger);

Review Comment:
   Make sure that `numSortedRunMax >= numSortedRunStopTrigger`? Otherwise the number of sorted runs may exceed `numSortedRunMax` which contradicts the description of that config option.



##########
flink-table-store-core/src/test/java/org/apache/flink/table/store/file/mergetree/compact/CompactManagerTest.java:
##########
@@ -197,7 +197,7 @@ private void innerTest(
                 new CompactManager(
                         service, strategy, comparator, 2, testRewriter(expectedDropDelete));
         manager.submitCompaction(levels);
-        manager.finishCompaction(levels);

Review Comment:
   Add tests so that compaction thread will randomly hang to simulate heavy compaction tasks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org