You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/06/24 21:37:00 UTC

[jira] [Commented] (AIRFLOW-4844) Adding option to DAG arguments to specify is_paused flag upon creation of a DAG.

    [ https://issues.apache.org/jira/browse/AIRFLOW-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16871800#comment-16871800 ] 

ASF GitHub Bot commented on AIRFLOW-4844:
-----------------------------------------

Sinsin1367 commented on pull request #5473: [AIRFLOW-4844] Added optional is_paused_upon_creation argument for da…
URL: https://github.com/apache/airflow/pull/5473
 
 
   …gs to configure initial pause status upon creation.
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow-4844](https://issues.apache.org/jira/browse/AIRFLOW-4844)
   
   ### Description
   
   - [ ] Here are some details about my PR:
   1. Adding the feature to configure each dag object with the initial state of is_paused flag
   
   
   ### Tests
   
   - [ ] My PR adds the following unit tests:
   1. Adding unit test to test existing dags in database not being affected with the flag.
   2. Adding unit test to test new dags following the flag passed. (there are already unit tests testing backward compatibility of the the code change.)
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Adding option to DAG arguments to specify is_paused flag upon creation of a DAG.
> --------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-4844
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4844
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: DAG
>    Affects Versions: 1.10.3
>            Reporter: Sina Asadallahi
>            Assignee: Sina Asadallahi
>            Priority: Major
>
> There is a need in some applications to set the is_paused flag when creating a DAG for the first time. These applications are mostly the ones where there is no need for DAG owner to turn them on manually once the dag is initiated. This is particularly useful for dynamic DAGs that generate an arbitrary number of DAGs based on calls to some upstream data source. Since the DAGs start as paused by default, it requires users to know when a new DAG has been created, and to enable it.
> Please note that this feature is configuring is_paused flag per dag object and is different than the existing global config coming from default_airflow.cfg file.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)