You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2019/09/30 14:23:35 UTC

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #573: DISPATCH-1426 - Added an abandoned deliveries handler so all abandone…

kgiusti commented on a change in pull request #573: DISPATCH-1426 - Added an abandoned deliveries handler so all abandone…
URL: https://github.com/apache/qpid-dispatch/pull/573#discussion_r329594071
 
 

 ##########
 File path: src/router_node.c
 ##########
 @@ -102,8 +102,8 @@ static qdr_delivery_t *qdr_node_delivery_qdr_from_pn(pn_delivery_t *dlv)
 }
 
 
-static void qdr_node_reap_abandoned_deliveries(qdr_core_t *core, qd_link_t *link)
-{
+void qd_link_abandoned_deliveries_handler(void *context, qd_link_t *link) {
 
 Review comment:
   Nit:  Add a newline after the parameter list: the opening brace should be on the next line by itself.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org