You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Frank W. Zammetti (JIRA)" <ji...@apache.org> on 2006/07/03 07:24:16 UTC
[jira] Created: (STR-2900) Checkstyle patches
Checkstyle patches
------------------
Key: STR-2900
URL: http://issues.apache.org/struts/browse/STR-2900
Project: Struts 1
Type: Improvement
Components: Core, Apps, EL, Extras, Faces, Scripting, Taglibs, Tiles
Versions: 1.3.1
Environment: Any
Reporter: Frank W. Zammetti
Attachments: apps.zip, core.zip, el.zip, extras.zip, faces.zip
This is a collection of patches which addresses about 2,150 Checkstyle complaints. Each ZIP file should be unzipped, and be sure to recreate directory structure! You will find a structure that matches the source repo. I created a single patch file for each package within each subproject that has changes, so it should be quite granular enough. Also note that there are some new package.html files in some places which should be added. I will be happy to do another round once these are applied.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (STR-2900) Checkstyle patches
Posted by "Frank W. Zammetti (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2900?page=all ]
Frank W. Zammetti updated STR-2900:
-----------------------------------
Attachment: all.patch
This file contains all the patches combined, as per James' request.
> Checkstyle patches
> ------------------
>
> Key: STR-2900
> URL: http://issues.apache.org/struts/browse/STR-2900
> Project: Struts 1
> Type: Improvement
> Components: Core, Apps, EL, Extras, Faces, Scripting, Taglibs, Tiles
> Versions: 1.3.1
> Environment: Any
> Reporter: Frank W. Zammetti
> Assignee: James Mitchell
> Attachments: all.patch, apps.zip, core.zip, el.zip, extras.zip, faces.zip, integration.zip, mailreader-dao.zip, scripting.zip, taglib.zip, tiles.zip
>
> This is a collection of patches which addresses about 2,150 Checkstyle complaints. Each ZIP file should be unzipped, and be sure to recreate directory structure! You will find a structure that matches the source repo. I created a single patch file for each package within each subproject that has changes, so it should be quite granular enough. Also note that there are some new package.html files in some places which should be added. I will be happy to do another round once these are applied.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (STR-2900) Checkstyle patches
Posted by "Frank W. Zammetti (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2900?page=comments#action_37683 ]
Frank W. Zammetti commented on STR-2900:
----------------------------------------
Sorry I didn't get to this earlier James, I was away on vacation most of the past week... The patches were created using TortoiseSVN's "Make Patch" function... I will try what you suggest as soon as possible... Although, I'm not sure I can do it from the command line, but I'm fairly sure the TSVN Update option does what you describe. If I had some out of date files, I would have to redo all the patches, so this could wind up taking some time. I try to get to this all this weekend.
> Checkstyle patches
> ------------------
>
> Key: STR-2900
> URL: http://issues.apache.org/struts/browse/STR-2900
> Project: Struts 1
> Type: Improvement
> Components: Core, Apps, EL, Extras, Faces, Scripting, Taglibs, Tiles
> Versions: 1.3.1
> Environment: Any
> Reporter: Frank W. Zammetti
> Assignee: James Mitchell
> Fix For: 1.3.5
> Attachments: all.patch, apps.zip, core.zip, el.zip, extras.zip, faces.zip, integration.zip, mailreader-dao.zip, scripting.zip, taglib.zip, tiles.zip
>
> This is a collection of patches which addresses about 2,150 Checkstyle complaints. Each ZIP file should be unzipped, and be sure to recreate directory structure! You will find a structure that matches the source repo. I created a single patch file for each package within each subproject that has changes, so it should be quite granular enough. Also note that there are some new package.html files in some places which should be added. I will be happy to do another round once these are applied.
> For background, see also
> * http://www.mail-archive.com/dev%40struts.apache.org/msg22827.html
> * http://www.mail-archive.com/dev%40struts.apache.org/msg22988.html
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (STR-2900) Checkstyle patches
Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2900?page=all ]
Ted Husted updated STR-2900:
----------------------------
Description:
This is a collection of patches which addresses about 2,150 Checkstyle complaints. Each ZIP file should be unzipped, and be sure to recreate directory structure! You will find a structure that matches the source repo. I created a single patch file for each package within each subproject that has changes, so it should be quite granular enough. Also note that there are some new package.html files in some places which should be added. I will be happy to do another round once these are applied.
For background, see also
* http://www.mail-archive.com/dev%40struts.apache.org/msg22827.html
* http://www.mail-archive.com/dev%40struts.apache.org/msg22988.html
was:This is a collection of patches which addresses about 2,150 Checkstyle complaints. Each ZIP file should be unzipped, and be sure to recreate directory structure! You will find a structure that matches the source repo. I created a single patch file for each package within each subproject that has changes, so it should be quite granular enough. Also note that there are some new package.html files in some places which should be added. I will be happy to do another round once these are applied.
> Checkstyle patches
> ------------------
>
> Key: STR-2900
> URL: http://issues.apache.org/struts/browse/STR-2900
> Project: Struts 1
> Type: Improvement
> Components: Core, Apps, EL, Extras, Faces, Scripting, Taglibs, Tiles
> Versions: 1.3.1
> Environment: Any
> Reporter: Frank W. Zammetti
> Assignee: James Mitchell
> Attachments: all.patch, apps.zip, core.zip, el.zip, extras.zip, faces.zip, integration.zip, mailreader-dao.zip, scripting.zip, taglib.zip, tiles.zip
>
> This is a collection of patches which addresses about 2,150 Checkstyle complaints. Each ZIP file should be unzipped, and be sure to recreate directory structure! You will find a structure that matches the source repo. I created a single patch file for each package within each subproject that has changes, so it should be quite granular enough. Also note that there are some new package.html files in some places which should be added. I will be happy to do another round once these are applied.
> For background, see also
> * http://www.mail-archive.com/dev%40struts.apache.org/msg22827.html
> * http://www.mail-archive.com/dev%40struts.apache.org/msg22988.html
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (STR-2900) Checkstyle patches
Posted by "James Mitchell (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2900?page=comments#action_37642 ]
James Mitchell commented on STR-2900:
-------------------------------------
Sorry this is taking so long. Maybe I'm just doing it wrong, but I'm not sure how you are creating the patch file. I'm getting a bunch of failures during patch.
(this is only a small snip)
...
...
1 out of 1 hunk FAILED -- saving rejects to file apps/examples/src/main/java/org/apache/struts/webapp/validator/LocaleAction.java.rej
patching file apps/examples/src/main/java/org/apache/struts/webapp/validator/MultiRegistrationAction.java
Hunk #1 FAILED at 1.
1 out of 3 hunks FAILED -- saving rejects to file apps/examples/src/main/java/org/apache/struts/webapp/validator/MultiRegistrationAction.java.rej
patching file apps/examples/src/main/java/org/apache/struts/webapp/validator/RegistrationAction.java
Hunk #1 FAILED at 1.
...
...
Perhaps your files are not up to date or something.
Could you do the following?
$cd {to struts1/ dir}
$svn up (watch for any conflicts)
$svn diff -u > checkstyle.patch
This creates 1 single patch file from the same place that I will run patch.
Thanks again.
> Checkstyle patches
> ------------------
>
> Key: STR-2900
> URL: http://issues.apache.org/struts/browse/STR-2900
> Project: Struts 1
> Type: Improvement
> Components: Core, Apps, EL, Extras, Faces, Scripting, Taglibs, Tiles
> Versions: 1.3.1
> Environment: Any
> Reporter: Frank W. Zammetti
> Assignee: James Mitchell
> Attachments: all.patch, apps.zip, core.zip, el.zip, extras.zip, faces.zip, integration.zip, mailreader-dao.zip, scripting.zip, taglib.zip, tiles.zip
>
> This is a collection of patches which addresses about 2,150 Checkstyle complaints. Each ZIP file should be unzipped, and be sure to recreate directory structure! You will find a structure that matches the source repo. I created a single patch file for each package within each subproject that has changes, so it should be quite granular enough. Also note that there are some new package.html files in some places which should be added. I will be happy to do another round once these are applied.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Commented: (STR-2900) Checkstyle patches
Posted by "Frank W. Zammetti" <fz...@omnytex.com>.
There you go :)
Frank
James Mitchell (JIRA) wrote:
> [ http://issues.apache.org/struts/browse/STR-2900?page=comments#action_37639 ]
>
> James Mitchell commented on STR-2900:
> -------------------------------------
>
> Frank, thanks for the patches. Any chance you can give me a single patch file? Or even a single one per module/directory? (instead of java package)
>
>
>> Checkstyle patches
>> ------------------
>>
>> Key: STR-2900
>> URL: http://issues.apache.org/struts/browse/STR-2900
>> Project: Struts 1
>> Type: Improvement
>
>> Components: Core, Apps, EL, Extras, Faces, Scripting, Taglibs, Tiles
>> Versions: 1.3.1
>> Environment: Any
>> Reporter: Frank W. Zammetti
>> Assignee: James Mitchell
>> Attachments: apps.zip, core.zip, el.zip, extras.zip, faces.zip, integration.zip, mailreader-dao.zip, scripting.zip, taglib.zip, tiles.zip
>>
>> This is a collection of patches which addresses about 2,150 Checkstyle complaints. Each ZIP file should be unzipped, and be sure to recreate directory structure! You will find a structure that matches the source repo. I created a single patch file for each package within each subproject that has changes, so it should be quite granular enough. Also note that there are some new package.html files in some places which should be added. I will be happy to do another round once these are applied.
>
--
Frank W. Zammetti
Founder and Chief Software Architect
Omnytex Technologies
http://www.omnytex.com
AIM: fzammetti
Yahoo: fzammetti
MSN: fzammetti@hotmail.com
Java Web Parts -
http://javawebparts.sourceforge.net
Supplying the wheel, so you don't have to reinvent it!
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [jira] Commented: (STR-2900) Checkstyle patches
Posted by "Frank W. Zammetti" <fz...@omnytex.com>.
There you go :)
Frank
James Mitchell (JIRA) wrote:
> [ http://issues.apache.org/struts/browse/STR-2900?page=comments#action_37639 ]
>
> James Mitchell commented on STR-2900:
> -------------------------------------
>
> Frank, thanks for the patches. Any chance you can give me a single patch file? Or even a single one per module/directory? (instead of java package)
>
>
>> Checkstyle patches
>> ------------------
>>
>> Key: STR-2900
>> URL: http://issues.apache.org/struts/browse/STR-2900
>> Project: Struts 1
>> Type: Improvement
>
>> Components: Core, Apps, EL, Extras, Faces, Scripting, Taglibs, Tiles
>> Versions: 1.3.1
>> Environment: Any
>> Reporter: Frank W. Zammetti
>> Assignee: James Mitchell
>> Attachments: apps.zip, core.zip, el.zip, extras.zip, faces.zip, integration.zip, mailreader-dao.zip, scripting.zip, taglib.zip, tiles.zip
>>
>> This is a collection of patches which addresses about 2,150 Checkstyle complaints. Each ZIP file should be unzipped, and be sure to recreate directory structure! You will find a structure that matches the source repo. I created a single patch file for each package within each subproject that has changes, so it should be quite granular enough. Also note that there are some new package.html files in some places which should be added. I will be happy to do another round once these are applied.
>
--
Frank W. Zammetti
Founder and Chief Software Architect
Omnytex Technologies
http://www.omnytex.com
AIM: fzammetti
Yahoo: fzammetti
MSN: fzammetti@hotmail.com
Java Web Parts -
http://javawebparts.sourceforge.net
Supplying the wheel, so you don't have to reinvent it!
[jira] Commented: (STR-2900) Checkstyle patches
Posted by "James Mitchell (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2900?page=comments#action_37639 ]
James Mitchell commented on STR-2900:
-------------------------------------
Frank, thanks for the patches. Any chance you can give me a single patch file? Or even a single one per module/directory? (instead of java package)
> Checkstyle patches
> ------------------
>
> Key: STR-2900
> URL: http://issues.apache.org/struts/browse/STR-2900
> Project: Struts 1
> Type: Improvement
> Components: Core, Apps, EL, Extras, Faces, Scripting, Taglibs, Tiles
> Versions: 1.3.1
> Environment: Any
> Reporter: Frank W. Zammetti
> Assignee: James Mitchell
> Attachments: apps.zip, core.zip, el.zip, extras.zip, faces.zip, integration.zip, mailreader-dao.zip, scripting.zip, taglib.zip, tiles.zip
>
> This is a collection of patches which addresses about 2,150 Checkstyle complaints. Each ZIP file should be unzipped, and be sure to recreate directory structure! You will find a structure that matches the source repo. I created a single patch file for each package within each subproject that has changes, so it should be quite granular enough. Also note that there are some new package.html files in some places which should be added. I will be happy to do another round once these are applied.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (STR-2900) Checkstyle patches
Posted by "Frank W. Zammetti (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2900?page=all ]
Frank W. Zammetti updated STR-2900:
-----------------------------------
Attachment: el.zip
> Checkstyle patches
> ------------------
>
> Key: STR-2900
> URL: http://issues.apache.org/struts/browse/STR-2900
> Project: Struts 1
> Type: Improvement
> Components: Core, Apps, EL, Extras, Faces, Scripting, Taglibs, Tiles
> Versions: 1.3.1
> Environment: Any
> Reporter: Frank W. Zammetti
> Attachments: apps.zip, core.zip, el.zip, extras.zip, faces.zip
>
> This is a collection of patches which addresses about 2,150 Checkstyle complaints. Each ZIP file should be unzipped, and be sure to recreate directory structure! You will find a structure that matches the source repo. I created a single patch file for each package within each subproject that has changes, so it should be quite granular enough. Also note that there are some new package.html files in some places which should be added. I will be happy to do another round once these are applied.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (STR-2900) Checkstyle patches
Posted by "Frank W. Zammetti (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2900?page=all ]
Frank W. Zammetti updated STR-2900:
-----------------------------------
Attachment: core.zip
> Checkstyle patches
> ------------------
>
> Key: STR-2900
> URL: http://issues.apache.org/struts/browse/STR-2900
> Project: Struts 1
> Type: Improvement
> Components: Core, Apps, EL, Extras, Faces, Scripting, Taglibs, Tiles
> Versions: 1.3.1
> Environment: Any
> Reporter: Frank W. Zammetti
> Attachments: apps.zip, core.zip, el.zip, extras.zip, faces.zip
>
> This is a collection of patches which addresses about 2,150 Checkstyle complaints. Each ZIP file should be unzipped, and be sure to recreate directory structure! You will find a structure that matches the source repo. I created a single patch file for each package within each subproject that has changes, so it should be quite granular enough. Also note that there are some new package.html files in some places which should be added. I will be happy to do another round once these are applied.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (STR-2900) Checkstyle patches
Posted by "James Mitchell (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2900?page=all ]
James Mitchell reassigned STR-2900:
-----------------------------------
Assign To: James Mitchell
> Checkstyle patches
> ------------------
>
> Key: STR-2900
> URL: http://issues.apache.org/struts/browse/STR-2900
> Project: Struts 1
> Type: Improvement
> Components: Core, Apps, EL, Extras, Faces, Scripting, Taglibs, Tiles
> Versions: 1.3.1
> Environment: Any
> Reporter: Frank W. Zammetti
> Assignee: James Mitchell
> Attachments: apps.zip, core.zip, el.zip, extras.zip, faces.zip, integration.zip, mailreader-dao.zip, scripting.zip, taglib.zip, tiles.zip
>
> This is a collection of patches which addresses about 2,150 Checkstyle complaints. Each ZIP file should be unzipped, and be sure to recreate directory structure! You will find a structure that matches the source repo. I created a single patch file for each package within each subproject that has changes, so it should be quite granular enough. Also note that there are some new package.html files in some places which should be added. I will be happy to do another round once these are applied.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (STR-2900) Checkstyle patches
Posted by "Frank W. Zammetti (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2900?page=all ]
Frank W. Zammetti updated STR-2900:
-----------------------------------
Attachment: apps.zip
> Checkstyle patches
> ------------------
>
> Key: STR-2900
> URL: http://issues.apache.org/struts/browse/STR-2900
> Project: Struts 1
> Type: Improvement
> Components: Core, Apps, EL, Extras, Faces, Scripting, Taglibs, Tiles
> Versions: 1.3.1
> Environment: Any
> Reporter: Frank W. Zammetti
> Attachments: apps.zip, core.zip, el.zip, extras.zip, faces.zip
>
> This is a collection of patches which addresses about 2,150 Checkstyle complaints. Each ZIP file should be unzipped, and be sure to recreate directory structure! You will find a structure that matches the source repo. I created a single patch file for each package within each subproject that has changes, so it should be quite granular enough. Also note that there are some new package.html files in some places which should be added. I will be happy to do another round once these are applied.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (STR-2900) Checkstyle patches
Posted by "Frank W. Zammetti (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2900?page=all ]
Frank W. Zammetti updated STR-2900:
-----------------------------------
Attachment: faces.zip
> Checkstyle patches
> ------------------
>
> Key: STR-2900
> URL: http://issues.apache.org/struts/browse/STR-2900
> Project: Struts 1
> Type: Improvement
> Components: Core, Apps, EL, Extras, Faces, Scripting, Taglibs, Tiles
> Versions: 1.3.1
> Environment: Any
> Reporter: Frank W. Zammetti
> Attachments: apps.zip, core.zip, el.zip, extras.zip, faces.zip
>
> This is a collection of patches which addresses about 2,150 Checkstyle complaints. Each ZIP file should be unzipped, and be sure to recreate directory structure! You will find a structure that matches the source repo. I created a single patch file for each package within each subproject that has changes, so it should be quite granular enough. Also note that there are some new package.html files in some places which should be added. I will be happy to do another round once these are applied.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (STR-2900) Checkstyle patches
Posted by "Frank W. Zammetti (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2900?page=all ]
Frank W. Zammetti updated STR-2900:
-----------------------------------
Attachment: tiles.zip
> Checkstyle patches
> ------------------
>
> Key: STR-2900
> URL: http://issues.apache.org/struts/browse/STR-2900
> Project: Struts 1
> Type: Improvement
> Components: Core, Apps, EL, Extras, Faces, Scripting, Taglibs, Tiles
> Versions: 1.3.1
> Environment: Any
> Reporter: Frank W. Zammetti
> Attachments: apps.zip, core.zip, el.zip, extras.zip, faces.zip, integration.zip, mailreader-dao.zip, scripting.zip, taglib.zip, tiles.zip
>
> This is a collection of patches which addresses about 2,150 Checkstyle complaints. Each ZIP file should be unzipped, and be sure to recreate directory structure! You will find a structure that matches the source repo. I created a single patch file for each package within each subproject that has changes, so it should be quite granular enough. Also note that there are some new package.html files in some places which should be added. I will be happy to do another round once these are applied.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (STR-2900) Checkstyle patches
Posted by "Frank W. Zammetti (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2900?page=all ]
Frank W. Zammetti updated STR-2900:
-----------------------------------
Attachment: mailreader-dao.zip
> Checkstyle patches
> ------------------
>
> Key: STR-2900
> URL: http://issues.apache.org/struts/browse/STR-2900
> Project: Struts 1
> Type: Improvement
> Components: Core, Apps, EL, Extras, Faces, Scripting, Taglibs, Tiles
> Versions: 1.3.1
> Environment: Any
> Reporter: Frank W. Zammetti
> Attachments: apps.zip, core.zip, el.zip, extras.zip, faces.zip, integration.zip, mailreader-dao.zip, scripting.zip, taglib.zip, tiles.zip
>
> This is a collection of patches which addresses about 2,150 Checkstyle complaints. Each ZIP file should be unzipped, and be sure to recreate directory structure! You will find a structure that matches the source repo. I created a single patch file for each package within each subproject that has changes, so it should be quite granular enough. Also note that there are some new package.html files in some places which should be added. I will be happy to do another round once these are applied.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (STR-2900) Checkstyle patches
Posted by "Frank W. Zammetti (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2900?page=all ]
Frank W. Zammetti updated STR-2900:
-----------------------------------
Attachment: integration.zip
> Checkstyle patches
> ------------------
>
> Key: STR-2900
> URL: http://issues.apache.org/struts/browse/STR-2900
> Project: Struts 1
> Type: Improvement
> Components: Core, Apps, EL, Extras, Faces, Scripting, Taglibs, Tiles
> Versions: 1.3.1
> Environment: Any
> Reporter: Frank W. Zammetti
> Attachments: apps.zip, core.zip, el.zip, extras.zip, faces.zip, integration.zip, mailreader-dao.zip, scripting.zip, taglib.zip, tiles.zip
>
> This is a collection of patches which addresses about 2,150 Checkstyle complaints. Each ZIP file should be unzipped, and be sure to recreate directory structure! You will find a structure that matches the source repo. I created a single patch file for each package within each subproject that has changes, so it should be quite granular enough. Also note that there are some new package.html files in some places which should be added. I will be happy to do another round once these are applied.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (STR-2900) Checkstyle patches
Posted by "Frank W. Zammetti (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2900?page=all ]
Frank W. Zammetti updated STR-2900:
-----------------------------------
Attachment: scripting.zip
> Checkstyle patches
> ------------------
>
> Key: STR-2900
> URL: http://issues.apache.org/struts/browse/STR-2900
> Project: Struts 1
> Type: Improvement
> Components: Core, Apps, EL, Extras, Faces, Scripting, Taglibs, Tiles
> Versions: 1.3.1
> Environment: Any
> Reporter: Frank W. Zammetti
> Attachments: apps.zip, core.zip, el.zip, extras.zip, faces.zip, integration.zip, mailreader-dao.zip, scripting.zip, taglib.zip, tiles.zip
>
> This is a collection of patches which addresses about 2,150 Checkstyle complaints. Each ZIP file should be unzipped, and be sure to recreate directory structure! You will find a structure that matches the source repo. I created a single patch file for each package within each subproject that has changes, so it should be quite granular enough. Also note that there are some new package.html files in some places which should be added. I will be happy to do another round once these are applied.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (STR-2900) Checkstyle patches
Posted by "Wendy Smoak (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2900?page=comments#action_37719 ]
Wendy Smoak commented on STR-2900:
----------------------------------
Most of these changes went in last night (2006-07-11). The example apps and any new package.html files remain to be done. Thanks!
> Checkstyle patches
> ------------------
>
> Key: STR-2900
> URL: http://issues.apache.org/struts/browse/STR-2900
> Project: Struts 1
> Type: Improvement
> Components: Core, Apps, EL, Extras, Faces, Scripting, Taglibs, Tiles
> Versions: 1.3.1
> Environment: Any
> Reporter: Frank W. Zammetti
> Assignee: James Mitchell
> Fix For: 1.3.5
> Attachments: all.patch, apps.zip, core.zip, el.zip, extras.zip, faces.zip, frank_checkstyle.patch.gz, integration.zip, mailreader-dao.zip, scripting.zip, taglib.zip, tiles.zip
>
> This is a collection of patches which addresses about 2,150 Checkstyle complaints. Each ZIP file should be unzipped, and be sure to recreate directory structure! You will find a structure that matches the source repo. I created a single patch file for each package within each subproject that has changes, so it should be quite granular enough. Also note that there are some new package.html files in some places which should be added. I will be happy to do another round once these are applied.
> For background, see also
> * http://www.mail-archive.com/dev%40struts.apache.org/msg22827.html
> * http://www.mail-archive.com/dev%40struts.apache.org/msg22988.html
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (STR-2900) Checkstyle patches
Posted by "James Mitchell (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2900?page=comments#action_37684 ]
James Mitchell commented on STR-2900:
-------------------------------------
Hey, that's cool. Don't worry about it. I'll figure something out.
Sorry to hear that you're stuck using TSVN. When I'm forced to use Winders, I also prefer to go with Cygwin.
Thanks again
> Checkstyle patches
> ------------------
>
> Key: STR-2900
> URL: http://issues.apache.org/struts/browse/STR-2900
> Project: Struts 1
> Type: Improvement
> Components: Core, Apps, EL, Extras, Faces, Scripting, Taglibs, Tiles
> Versions: 1.3.1
> Environment: Any
> Reporter: Frank W. Zammetti
> Assignee: James Mitchell
> Fix For: 1.3.5
> Attachments: all.patch, apps.zip, core.zip, el.zip, extras.zip, faces.zip, integration.zip, mailreader-dao.zip, scripting.zip, taglib.zip, tiles.zip
>
> This is a collection of patches which addresses about 2,150 Checkstyle complaints. Each ZIP file should be unzipped, and be sure to recreate directory structure! You will find a structure that matches the source repo. I created a single patch file for each package within each subproject that has changes, so it should be quite granular enough. Also note that there are some new package.html files in some places which should be added. I will be happy to do another round once these are applied.
> For background, see also
> * http://www.mail-archive.com/dev%40struts.apache.org/msg22827.html
> * http://www.mail-archive.com/dev%40struts.apache.org/msg22988.html
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (STR-2900) Checkstyle patches
Posted by "Wendy Smoak (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2900?page=all ]
Wendy Smoak resolved STR-2900:
------------------------------
Resolution: Fixed
Assign To: Wendy Smoak (was: James Mitchell)
Done. Thanks again, Frank!
I skipped the two Faces example apps. They were mostly tabs -> spaces, and the patch only used two spaces per tab rather than four, so the indenting was wrong.
> Checkstyle patches
> ------------------
>
> Key: STR-2900
> URL: http://issues.apache.org/struts/browse/STR-2900
> Project: Struts 1
> Type: Improvement
> Components: Core, Apps, EL, Extras, Faces, Scripting, Taglibs, Tiles
> Versions: 1.3.1
> Environment: Any
> Reporter: Frank W. Zammetti
> Assignee: Wendy Smoak
> Fix For: 1.3.5
> Attachments: all.patch, apps.zip, core.zip, el.zip, extras.zip, faces.zip, frank_checkstyle.patch.gz, integration.zip, mailreader-dao.zip, scripting.zip, taglib.zip, tiles.zip
>
> This is a collection of patches which addresses about 2,150 Checkstyle complaints. Each ZIP file should be unzipped, and be sure to recreate directory structure! You will find a structure that matches the source repo. I created a single patch file for each package within each subproject that has changes, so it should be quite granular enough. Also note that there are some new package.html files in some places which should be added. I will be happy to do another round once these are applied.
> For background, see also
> * http://www.mail-archive.com/dev%40struts.apache.org/msg22827.html
> * http://www.mail-archive.com/dev%40struts.apache.org/msg22988.html
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (STR-2900) Checkstyle patches
Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2900?page=all ]
Ted Husted updated STR-2900:
----------------------------
Fix Version: 1.3.5
> Checkstyle patches
> ------------------
>
> Key: STR-2900
> URL: http://issues.apache.org/struts/browse/STR-2900
> Project: Struts 1
> Type: Improvement
> Components: Apps, Core, EL, Extras, Faces, Scripting, Taglibs, Tiles
> Versions: 1.3.1
> Environment: Any
> Reporter: Frank W. Zammetti
> Assignee: James Mitchell
> Fix For: 1.3.5
> Attachments: all.patch, apps.zip, core.zip, el.zip, extras.zip, faces.zip, integration.zip, mailreader-dao.zip, scripting.zip, taglib.zip, tiles.zip
>
> This is a collection of patches which addresses about 2,150 Checkstyle complaints. Each ZIP file should be unzipped, and be sure to recreate directory structure! You will find a structure that matches the source repo. I created a single patch file for each package within each subproject that has changes, so it should be quite granular enough. Also note that there are some new package.html files in some places which should be added. I will be happy to do another round once these are applied.
> For background, see also
> * http://www.mail-archive.com/dev%40struts.apache.org/msg22827.html
> * http://www.mail-archive.com/dev%40struts.apache.org/msg22988.html
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (STR-2900) Checkstyle patches
Posted by "Frank W. Zammetti (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2900?page=all ]
Frank W. Zammetti updated STR-2900:
-----------------------------------
Attachment: taglib.zip
> Checkstyle patches
> ------------------
>
> Key: STR-2900
> URL: http://issues.apache.org/struts/browse/STR-2900
> Project: Struts 1
> Type: Improvement
> Components: Core, Apps, EL, Extras, Faces, Scripting, Taglibs, Tiles
> Versions: 1.3.1
> Environment: Any
> Reporter: Frank W. Zammetti
> Attachments: apps.zip, core.zip, el.zip, extras.zip, faces.zip, integration.zip, mailreader-dao.zip, scripting.zip, taglib.zip, tiles.zip
>
> This is a collection of patches which addresses about 2,150 Checkstyle complaints. Each ZIP file should be unzipped, and be sure to recreate directory structure! You will find a structure that matches the source repo. I created a single patch file for each package within each subproject that has changes, so it should be quite granular enough. Also note that there are some new package.html files in some places which should be added. I will be happy to do another round once these are applied.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (STR-2900) Checkstyle patches
Posted by "Wendy Smoak (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2900?page=all ]
Wendy Smoak updated STR-2900:
-----------------------------
Attachment: frank_checkstyle.patch.gz
I asked Frank to zip his working copy and make it available. The attached patch is the result of:
1. rename all _svn directories to .svn (TortoiseSVN .NET hack)
2. svn switch http://svn.apache.org/repos/asf/struts/struts1/trunk
(this was checked out when it was struts/action/trunk. svn switch also does an update)
3. mvn clean install -Papps (which worked)
4. svn status | grep "C " (looking for conflicts, there were none)
5. svn diff > frank_checkstyle.patch
6. gzip frank_checkstyle.patch
> Checkstyle patches
> ------------------
>
> Key: STR-2900
> URL: http://issues.apache.org/struts/browse/STR-2900
> Project: Struts 1
> Type: Improvement
> Components: Apps, Core, EL, Extras, Faces, Scripting, Taglibs, Tiles
> Versions: 1.3.1
> Environment: Any
> Reporter: Frank W. Zammetti
> Assignee: James Mitchell
> Fix For: 1.3.5
> Attachments: all.patch, apps.zip, core.zip, el.zip, extras.zip, faces.zip, frank_checkstyle.patch.gz, integration.zip, mailreader-dao.zip, scripting.zip, taglib.zip, tiles.zip
>
> This is a collection of patches which addresses about 2,150 Checkstyle complaints. Each ZIP file should be unzipped, and be sure to recreate directory structure! You will find a structure that matches the source repo. I created a single patch file for each package within each subproject that has changes, so it should be quite granular enough. Also note that there are some new package.html files in some places which should be added. I will be happy to do another round once these are applied.
> For background, see also
> * http://www.mail-archive.com/dev%40struts.apache.org/msg22827.html
> * http://www.mail-archive.com/dev%40struts.apache.org/msg22988.html
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (STR-2900) Checkstyle patches
Posted by "Frank W. Zammetti (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2900?page=all ]
Frank W. Zammetti updated STR-2900:
-----------------------------------
Attachment: extras.zip
> Checkstyle patches
> ------------------
>
> Key: STR-2900
> URL: http://issues.apache.org/struts/browse/STR-2900
> Project: Struts 1
> Type: Improvement
> Components: Core, Apps, EL, Extras, Faces, Scripting, Taglibs, Tiles
> Versions: 1.3.1
> Environment: Any
> Reporter: Frank W. Zammetti
> Attachments: apps.zip, core.zip, el.zip, extras.zip, faces.zip
>
> This is a collection of patches which addresses about 2,150 Checkstyle complaints. Each ZIP file should be unzipped, and be sure to recreate directory structure! You will find a structure that matches the source repo. I created a single patch file for each package within each subproject that has changes, so it should be quite granular enough. Also note that there are some new package.html files in some places which should be added. I will be happy to do another round once these are applied.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira