You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "davsclaus (via GitHub)" <gi...@apache.org> on 2026/10/19 20:06:44 UTC

[PR] CAMEL-25784: camel_get_errors says in its description that it answers for an integration that is not running [camel]

davsclaus opened a new pull request, #28127:
URL: https://github.com/apache/camel/pull/28127

   Follow-up of [CAMEL-25784](https://issues.apache.org/jira/browse/CAMEL-25784) (#28108), from the review of #28108: `camel_get_errors` says how the previous run of an integration that is not running ended, but its description only spoke of "a running integration". An agent picks a tool by its description, so it would not call `camel_get_errors` for an integration that stopped, such as one that failed to start.
   
   - The description of `camel_get_errors` (the core tool and the camel-jbang-mcp server) adds: "For an integration that is not running, it says how its previous run ended." It now matches `camel_get_log`, whose description says that it gets the log of the previous run.
   - The tools table in camel-jbang-mcp.adoc says both: `camel_get_log` gets the log of the previous run (and `previous=true` asks for it while the integration runs again), and `camel_get_errors` says how the previous run ended.
   
   ## Tests
   
   - The camel-jbang-core tests of the tools that name `camel_get_errors` pass (63: `AskToolsTest`, `AuthoringToolsTest`, `PreviousRunToolsTest`, `RepeatedToolCallsTest`, `ToolRegistryTest`), and `AuthoringToolsTest` of camel-jbang-mcp (10).
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   
   https://claude.ai/code/session_01STT6whBgK1AqsSsUKrnE8m
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-25784: camel_get_errors says in its description that it answers for an integration that is not running [camel]

Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #28127:
URL: https://github.com/apache/camel/pull/28127


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-25784: camel_get_errors says in its description that it answers for an integration that is not running [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28127:
URL: https://github.com/apache/camel/pull/28127#issuecomment-6276303355

   :star2: Thank you for your contribution to the Apache Camel project! :star2:
     :robot: CI automation will test this PR automatically.
   
     :camel: Apache Camel Committers, please review the following items:
   
     * First-time contributors **require MANUAL approval** for the GitHub Actions to run
     * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
     * You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
     * Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
     
     :warning: Be careful when sharing logs. Review their contents before sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-25784: camel_get_errors says in its description that it answers for an integration that is not running [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28127:
URL: https://github.com/apache/camel/pull/28127#issuecomment-6277677284

   <!-- ci-tested-modules -->
   :test_tube: **CI tested the following changed modules:**
   
   - `docs`
   - `dsl/camel-jbang/camel-jbang-core`
   - `dsl/camel-jbang/camel-jbang-mcp`
   
   :repeat: **1 test passed only after a retry on JDK 25** (1 retried attempt)
   
   <details><summary>Recovered flaky tests on JDK 25 (1)</summary>
   
   | Module | Test | Failed attempts | First failure |
   | --- | --- | --- | --- |
   | `dsl/camel-jbang/camel-jbang-core` | `LogConfigurationTest.withoutTheDirectoryOfTheCliTheLogFileIsInTheCamelDirectoryOfTheUser` | 1 | expected: "/home/runner/work/camel/camel/dsl/camel-jbang/camel-jbang-core/target/test-home-4/.camel/11717.log" but was: "/tmp/junit-15308004299460176781/.camel/11717.log" |
   
   > :information_source: These tests did **not** fail the build. Surefire retried them and they passed.
   > Retries are enabled project-wide by `surefire.rerunFailingTestsCount` in `parent/pom.xml`.
   
   </details>
   
   ---
   
   <details><summary>:microscope: Scalpel shadow comparison — Scalpel: 5 of 707 tested, 8 compile-only — current: 5 all tested</summary>
   
   [Maveniverse Scalpel](https://github.com/maveniverse/scalpel) detected **5 affected modules** (current approach: 5).
   
   **Skip-tests mode would test 5 modules** (3 direct + 4 downstream), **skip tests for 8** (generated code, meta-modules)
   
   <details><summary>Modules Scalpel would test (5)</summary>
   
   - `camel-jbang-mcp` ← dsl/camel-jbang/camel-jbang-mcp/src/main/java/org/apache/camel/dsl/jbang/core/commands/mcp/AuthoringTools.java
   - `camel-jbang-plugin-mcp` ← downstream of org.apache.camel:camel-jbang-core
   - `camel-jbang-plugin-tui` ← downstream of org.apache.camel:camel-jbang-core
   - `camel-jbang-plugin-validate` ← downstream of org.apache.camel:camel-jbang-core
   - `camel-launcher-container` ← downstream of org.apache.camel:camel-launcher
   
   </details>
   
   <details><summary>Modules with tests skipped (8)</summary>
   
   - `camel-jbang-it`
   - `camel-jbang-main`
   - `camel-jbang-plugin-edit`
   - `camel-jbang-plugin-generate`
   - `camel-jbang-plugin-kubernetes`
   - `camel-jbang-plugin-test`
   - `camel-launcher`
   - `coverage`
   
   </details>
   
   > :information_source: Shadow mode — Scalpel observes but does not affect test execution. [Learn more](https://github.com/maveniverse/scalpel)
   
   </details>
   
   :warning: **Some tests are disabled on GitHub Actions** (`@DisabledIfSystemProperty(named = "ci.env.name")`) and require manual verification:
   
   - `dsl/camel-jbang/camel-jbang-core`: 2 test(s) disabled on GitHub Actions
   - `dsl/camel-jbang/camel-jbang-mcp`: 2 test(s) disabled on GitHub Actions
   
   :bulb: **Manual integration tests recommended:**
   
   > You modified `dsl/camel-jbang/camel-jbang-core`. The related integration tests in `dsl/camel-jbang/camel-jbang-it` are excluded from CI. Consider running them manually:
   > ```
   > mvn verify -f dsl/camel-jbang/camel-jbang-it -Djbang-it-test
   > ```
   
   <details><summary>All tested modules (15 modules, 1m 48s total)</summary>
   
   **Total reactor time:** 1m 48s
   
   | Module | Duration | Status |
   | --- | --- | --- |
   | Camel :: JBang :: Plugin :: Validate | 29.2s | SUCCESS |
   | Camel :: JBang :: MCP | 23.6s | SUCCESS |
   | Camel :: Docs | 21.8s | SUCCESS |
   | Camel :: JBang :: Plugin :: Kubernetes | 13.2s | SUCCESS |
   | Camel :: JBang :: Plugin :: Testing | 12.9s | SUCCESS |
   | Camel :: JBang :: Plugin :: Generate | 2.0s | SUCCESS |
   | Camel :: JBang :: Plugin :: Edit | 1.4s | SUCCESS |
   | Camel :: Coverage | 1.4s | SUCCESS |
   | Camel :: JBang :: Plugin :: MCP | 1.1s | SUCCESS |
   | Camel :: JBang :: Main | 1.0s | SUCCESS |
   | Camel :: JBang :: Core | n/a |  |
   | Camel :: JBang :: Integration tests | n/a |  |
   | Camel :: JBang :: Plugin :: TUI | n/a |  |
   | Camel :: Launcher | n/a |  |
   | Camel :: Launcher :: Container | n/a |  |
   
   **Top 20 slowest modules:**
   - `Camel :: JBang :: Plugin :: Validate` (29.2s)
   - `Camel :: JBang :: MCP` (23.6s)
   - `Camel :: Docs` (21.8s)
   - `Camel :: JBang :: Plugin :: Kubernetes` (13.2s)
   - `Camel :: JBang :: Plugin :: Testing` (12.9s)
   - `Camel :: JBang :: Plugin :: Generate` (2.0s)
   - `Camel :: JBang :: Plugin :: Edit` (1.4s)
   - `Camel :: Coverage` (1.4s)
   - `Camel :: JBang :: Plugin :: MCP` (1.1s)
   - `Camel :: JBang :: Main` (1.0s)
   
   </details>
   
   ---
   :gear: [View full build and test results](https://github.com/apache/camel/actions/runs/39316571908)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org