You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2015/02/02 22:03:35 UTC
Re: Review Request 29598: Moved Modules protobuf to
mesos/modules.proto.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29598/
-----------------------------------------------------------
(Updated Feb. 2, 2015, 4:03 p.m.)
Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.
Changes
-------
rebased
Bugs: MESOS-2096
https://issues.apache.org/jira/browse/MESOS-2096
Repository: mesos
Description
-------
[1/9] Build Mesos Modules outside Mesos source tree.
To expose Modules message outside the mesos source tree. This allows modules to #include mesos/mesos.hpp and get the required protobuf definition.
Diffs (updated)
-----
include/mesos/module.hpp 594212605127522a1b5f0d1335d6c208b499289b
include/mesos/module.proto PRE-CREATION
src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e
src/common/parse.hpp ae581e5168606bf7ea7e092c5095ddf9d321c792
src/common/type_utils.hpp 6809a12611ccd5de9e75c642d7dd09227c2eb5d2
src/master/flags.hpp 6c18a1af625311ef149b5877b08f63c2b12c040d
src/messages/messages.proto c609f500e5e999a7587feb8acfb62aa637824c0a
src/slave/flags.hpp 0f6cc41d60a2e3bc2121cc438351135541ef99ba
Diff: https://reviews.apache.org/r/29598/diff/
Testing
-------
make check
Thanks,
Kapil Arya
Re: Review Request 29598: Moved Modules protobuf to
mesos/modules.proto.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29598/
-----------------------------------------------------------
(Updated Feb. 9, 2015, 9:37 p.m.)
Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.
Changes
-------
Addressed Nik's comment. Moved modules.proto to mesos/module/
Bugs: MESOS-2096
https://issues.apache.org/jira/browse/MESOS-2096
Repository: mesos
Description
-------
[1/9] Build Mesos Modules outside Mesos source tree.
To expose Modules message outside the mesos source tree. This allows modules to #include mesos/mesos.hpp and get the required protobuf definition.
Diffs (updated)
-----
include/mesos/module/module.hpp PRE-CREATION
include/mesos/module/module.proto PRE-CREATION
src/Makefile.am 93537d17d3c7604a8532ee1453e405630c481ddc
src/common/parse.hpp 772a1a5dbc2574977de6b931b1954e15cae99acb
src/common/type_utils.hpp 5c24c080f359a6adc4840f0a1586d21585616908
src/master/flags.hpp df2e9cbdd56e9831290bf57c65b212cd7820a7f6
src/messages/messages.proto 44122bd777a27236d3f4aad376e0055544d40121
src/module/manager.hpp 7a9d93b1a62ef2a1806f198f0c9014a66c2e4091
src/module/manager.cpp 573df8209c3ac7a77208c87dc7d2231e0e971a85
src/slave/flags.hpp f6033355d129f0013d39dd053455c936596bf159
src/tests/module.hpp 776a4263627492f1a7b360a54c83ef34d4511ae1
src/tests/module_tests.cpp 2e113be2a48290fb862b04022f38458b4612ab26
Diff: https://reviews.apache.org/r/29598/diff/
Testing
-------
make check
Thanks,
Kapil Arya
Re: Review Request 29598: Moved Modules protobuf to
mesos/modules.proto.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29598/#review71706
-----------------------------------------------------------
Ship it!
src/Makefile.am
<https://reviews.apache.org/r/29598/#comment117572>
Should we contain this in it's own directory? It looks a bit inconsistent compared to containerizer, fetcher and scheduler
- Niklas Nielsen
On Feb. 4, 2015, 7:15 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29598/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 7:15 p.m.)
>
>
> Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.
>
>
> Bugs: MESOS-2096
> https://issues.apache.org/jira/browse/MESOS-2096
>
>
> Repository: mesos
>
>
> Description
> -------
>
> [1/9] Build Mesos Modules outside Mesos source tree.
>
> To expose Modules message outside the mesos source tree. This allows modules to #include mesos/mesos.hpp and get the required protobuf definition.
>
>
> Diffs
> -----
>
> include/mesos/module.hpp 594212605127522a1b5f0d1335d6c208b499289b
> include/mesos/module.proto PRE-CREATION
> src/Makefile.am 93537d17d3c7604a8532ee1453e405630c481ddc
> src/common/parse.hpp ae581e5168606bf7ea7e092c5095ddf9d321c792
> src/common/type_utils.hpp b23eeb8a4055f596aba40d0c8a8250530c870876
> src/master/flags.hpp e9f6fff28153212756c9d78be733ec045f291483
> src/messages/messages.proto 8d86517039ec825b7d2ace6673da8971e140fa5e
> src/slave/flags.hpp facf6d3e68e412897a1381d7bbdcceaf5d1fbb94
>
> Diff: https://reviews.apache.org/r/29598/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 29598: Moved Modules protobuf to
mesos/modules.proto.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29598/
-----------------------------------------------------------
(Updated Feb. 4, 2015, 10:15 p.m.)
Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.
Changes
-------
rebased
Bugs: MESOS-2096
https://issues.apache.org/jira/browse/MESOS-2096
Repository: mesos
Description
-------
[1/9] Build Mesos Modules outside Mesos source tree.
To expose Modules message outside the mesos source tree. This allows modules to #include mesos/mesos.hpp and get the required protobuf definition.
Diffs (updated)
-----
include/mesos/module.hpp 594212605127522a1b5f0d1335d6c208b499289b
include/mesos/module.proto PRE-CREATION
src/Makefile.am 93537d17d3c7604a8532ee1453e405630c481ddc
src/common/parse.hpp ae581e5168606bf7ea7e092c5095ddf9d321c792
src/common/type_utils.hpp b23eeb8a4055f596aba40d0c8a8250530c870876
src/master/flags.hpp e9f6fff28153212756c9d78be733ec045f291483
src/messages/messages.proto 8d86517039ec825b7d2ace6673da8971e140fa5e
src/slave/flags.hpp facf6d3e68e412897a1381d7bbdcceaf5d1fbb94
Diff: https://reviews.apache.org/r/29598/diff/
Testing
-------
make check
Thanks,
Kapil Arya
Re: Review Request 29598: Moved Modules protobuf to
mesos/modules.proto.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29598/
-----------------------------------------------------------
(Updated Feb. 2, 2015, 7:42 p.m.)
Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.
Changes
-------
Fixed makefile.
Bugs: MESOS-2096
https://issues.apache.org/jira/browse/MESOS-2096
Repository: mesos
Description
-------
[1/9] Build Mesos Modules outside Mesos source tree.
To expose Modules message outside the mesos source tree. This allows modules to #include mesos/mesos.hpp and get the required protobuf definition.
Diffs (updated)
-----
include/mesos/module.hpp 594212605127522a1b5f0d1335d6c208b499289b
include/mesos/module.proto PRE-CREATION
src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e
src/common/parse.hpp ae581e5168606bf7ea7e092c5095ddf9d321c792
src/common/type_utils.hpp 6809a12611ccd5de9e75c642d7dd09227c2eb5d2
src/master/flags.hpp 6c18a1af625311ef149b5877b08f63c2b12c040d
src/messages/messages.proto c609f500e5e999a7587feb8acfb62aa637824c0a
src/slave/flags.hpp 0f6cc41d60a2e3bc2121cc438351135541ef99ba
Diff: https://reviews.apache.org/r/29598/diff/
Testing
-------
make check
Thanks,
Kapil Arya