You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2012/02/08 02:27:00 UTC

[jira] [Commented] (FLUME-955) Rat failure: Legacy Avro Source missing Apache license header

    [ https://issues.apache.org/jira/browse/FLUME-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203102#comment-13203102 ] 

jiraposter@reviews.apache.org commented on FLUME-955:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3785/
-----------------------------------------------------------

Review request for Flume.


Summary
-------

Simply add Apache License header to AvroLegacySource.java


This addresses bug FLUME-955.
    https://issues.apache.org/jira/browse/FLUME-955


Diffs
-----

  flume-ng-legacy-sources/flume-avro-source/src/main/java/org/apache/flume/source/avroLegacy/AvroLegacySource.java e7308c9 

Diff: https://reviews.apache.org/r/3785/diff


Testing
-------

Checked out pristine copy of flume-728 branch, applied the patch, and mvn clean & install went through smoothly.


Thanks,

Mike


                
> Rat failure: Legacy Avro Source missing Apache license header
> -------------------------------------------------------------
>
>                 Key: FLUME-955
>                 URL: https://issues.apache.org/jira/browse/FLUME-955
>             Project: Flume
>          Issue Type: Bug
>    Affects Versions: v1.0.0
>            Reporter: Mike Percy
>            Assignee: Mike Percy
>             Fix For: v1.1.0
>
>
> Upon executing the following command on the FLUME-728 branch I get a build error:
> $ mvn clean install
> ...
> [INFO] Flume legacy Thrift Source ........................ SUCCESS [0.396s]
> [INFO] Flume legacy Avro source .......................... FAILURE [0.466s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> ...
> [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.7:check (verify.rat) on project flume-avro-source: Too many unapproved licenses: 1 -> [Help 1]
> Following snippet is from flume-ng-legacy-sources/flume-avro-source/target/rat.txt:
> *****************************************************
> Summary
> -------
> Notes: 0
> Binaries: 0
> Archives: 0
> Standards: 4
> Apache Licensed: 3
> Generated Documents: 0
> JavaDocs are generated and so license header is optional
> Generated files do not required license headers
> 1 Unknown Licenses
> *******************************
> Unapproved licenses:
>   /Users/mpercy/src/flume2/flume-728/flume-ng-legacy-sources/flume-avro-source/src/main/java/org/apache/flume/source/avroLegacy/AvroLegacySource.java
> *******************************
> Archives:
> *****************************************************
>   Files with Apache License headers will be marked AL
>   Binary files (which do not require AL headers) will be marked B
>   Compressed archives will be marked A
>   Notices, licenses etc will be marked N
>   AL    /Users/mpercy/src/flume2/flume-728/flume-ng-legacy-sources/flume-avro-source/pom.xml
>   AL    /Users/mpercy/src/flume2/flume-728/flume-ng-legacy-sources/flume-avro-source/src/main/avro/flumeCompatibility.avdl
>  !????? /Users/mpercy/src/flume2/flume-728/flume-ng-legacy-sources/flume-avro-source/src/main/java/org/apache/flume/source/avroLegacy/AvroLegacySource.java
>   AL    /Users/mpercy/src/flume2/flume-728/flume-ng-legacy-sources/flume-avro-source/src/test/java/org/apache/flume/source/avroLegacy/TestLegacyAvroSource.java

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira