You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/02 14:04:09 UTC

[GitHub] [superset] codecov[bot] edited a comment on pull request #13818: test: PropertiesModal

codecov[bot] edited a comment on pull request #13818:
URL: https://github.com/apache/superset/pull/13818#issuecomment-808452014


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13818?src=pr&el=h1) Report
   > Merging [#13818](https://codecov.io/gh/apache/superset/pull/13818?src=pr&el=desc) (8434b47) into [master](https://codecov.io/gh/apache/superset/commit/a45a5e10600980df7cbacd1decd2f6fc3cf901f3?el=desc) (a45a5e1) will **decrease** coverage by `0.00%`.
   > The diff coverage is `73.17%`.
   
   > :exclamation: Current head 8434b47 differs from pull request most recent head ff7e048. Consider uploading reports for the commit ff7e048 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13818/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13818?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13818      +/-   ##
   ==========================================
   - Coverage   77.54%   77.53%   -0.01%     
   ==========================================
     Files         934      934              
     Lines       47249    47337      +88     
     Branches     5892     5949      +57     
   ==========================================
   + Hits        36641    36705      +64     
   - Misses      10464    10488      +24     
     Partials      144      144              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `63.78% <45.58%> (+0.04%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13818?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/components/Loading/index.tsx](https://codecov.io/gh/apache/superset/pull/13818/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTG9hZGluZy9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
   | [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13818/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.73% <ø> (ø)` | |
   | [...ters/FiltersConfigModal/FiltersConfigForm/state.ts](https://codecov.io/gh/apache/superset/pull/13818/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL3N0YXRlLnRz) | `76.00% <50.00%> (-12.89%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13818/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `56.07% <50.00%> (ø)` | |
   | [...veFilters/FilterBar/FilterControls/FilterValue.tsx](https://codecov.io/gh/apache/superset/pull/13818/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlclZhbHVlLnRzeA==) | `74.24% <54.16%> (-11.22%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13818/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `69.56% <66.66%> (+0.92%)` | :arrow_up: |
   | [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13818/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `93.10% <85.71%> (-0.65%)` | :arrow_down: |
   | [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13818/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (+9.52%)` | :arrow_up: |
   | [...d/src/explore/components/PropertiesModal/index.tsx](https://codecov.io/gh/apache/superset/pull/13818/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Qcm9wZXJ0aWVzTW9kYWwvaW5kZXgudHN4) | `81.94% <100.00%> (ø)` | |
   | [superset-frontend/src/explore/store.js](https://codecov.io/gh/apache/superset/pull/13818/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvc3RvcmUuanM=) | `92.85% <100.00%> (ø)` | |
   | ... and [15 more](https://codecov.io/gh/apache/superset/pull/13818/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13818?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13818?src=pr&el=footer). Last update [a45a5e1...ff7e048](https://codecov.io/gh/apache/superset/pull/13818?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org