[GitHub] [shardingsphere] menghaoranss commented on a diff in pull request #18155: addComputeNodeInstance when modeType is not cluster

[GitBox <gi...@apache.org>]

menghaoranss commented on code in PR #18155:
URL: https://github.com/apache/shardingsphere/pull/18155#discussion_r887819144


##########
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/instance/InstanceContext.java:
##########
@@ -52,6 +52,9 @@ public InstanceContext(final ComputeNodeInstance instance, final WorkerIdGenerat
         this.workerIdGenerator = workerIdGenerator;
         this.modeConfiguration = modeConfiguration;
         this.lockContext = lockContext;
+        if (!isCluster()) {

Review Comment:
   for standalone mode, DistSQL just control the current instance, So there is no need to add instance.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org