You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/28 05:14:48 UTC

[GitHub] jzhuge commented on issue #21978: [SPARK-25006][SQL] Add CatalogTableIdentifier.

jzhuge commented on issue #21978: [SPARK-25006][SQL] Add CatalogTableIdentifier.
URL: https://github.com/apache/spark/pull/21978#issuecomment-468140615
 
 
   Hi Matt,
   
   Agree we still need it. My PR for SPARK-26946 to implement multi-part
   identifier will be built on top of this because CatalogTableIdentifier at
   least provides a good way to incrementally migrate code paths. Do not
   review that PR yet, I will update in a few days, then we will have a better
   picture.
   
   Thanks,
   
   On Wed, Feb 27, 2019 at 7:27 PM mccheah <no...@github.com> wrote:
   
   > Think there's a failing build, also do we still need this or have the
   > underlying ideas changed in our discussion? My understanding is that we
   > still need this and that catalog identifiers are important to start with to
   > build the follow up table catalog APIs on.
   >
   > Also should this include multi-part identifier?
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/spark/pull/21978#issuecomment-468122823>, or mute
   > the thread
   > <https://github.com/notifications/unsubscribe-auth/ABy-pIdmtFgKnHpqK38MHEv1viN5eGtgks5vR0yTgaJpZM4VtC5y>
   > .
   >
   
   
   -- 
   John Zhuge
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org