You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/02/11 20:07:55 UTC
[GitHub] [tvm] trevor-m opened a new pull request #7446: [Frontend][Keras] Make keras reshape less restrictive
trevor-m opened a new pull request #7446:
URL: https://github.com/apache/tvm/pull/7446
The previous implementation of reshape in the Keras frontend attempted to map the target shape, which is specified in NHWC format, to NCHW format. However, this approach had many limitations of what reshapes can be supported and introduced some complicated logic.
Instead, I am proposing to just transpose input to NHWC, apply the unmodified reshape, then transpose back to NCHW. This is simpler and can support more reshapes which are valid in keras.
I added some test cases for reshapes which were not supported in the previous implementation, but are now possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #7446: [Frontend][Keras] Make keras reshape less restrictive
Posted by GitBox <gi...@apache.org>.
masahi merged pull request #7446:
URL: https://github.com/apache/tvm/pull/7446
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] trevor-m commented on pull request #7446: [Frontend][Keras] Make keras reshape less restrictive
Posted by GitBox <gi...@apache.org>.
trevor-m commented on pull request #7446:
URL: https://github.com/apache/tvm/pull/7446#issuecomment-777840373
@siju-samuel @jwfromm @mbrookhart Could you please review?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org