You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/24 04:46:55 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #39204: [SPARK-41700][CONNECT][PYTHON] Remove `FunctionBuilder`
zhengruifeng opened a new pull request, #39204:
URL: https://github.com/apache/spark/pull/39204
### What changes were proposed in this pull request?
Remove `FunctionBuilder`
### Why are the changes needed?
since we had supported almost all the functions
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
updated UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #39204: [SPARK-41700][CONNECT][PYTHON] Remove `FunctionBuilder`
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #39204:
URL: https://github.com/apache/spark/pull/39204#issuecomment-1364629207
thank you all, merged into master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #39204: [SPARK-41700][CONNECT][PYTHON] Remove `FunctionBuilder`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #39204:
URL: https://github.com/apache/spark/pull/39204#discussion_r1056873471
##########
python/pyspark/sql/connect/column.py:
##########
@@ -226,7 +225,7 @@ def substr(self, startPos: Union[int, "Column"], length: Union[int, "Column"]) -
else:
start_exp = startPos
- return F.substr(self, start_exp, length_exp)
+ return substring(self, start_exp, length_exp)
Review Comment:
Could you fix the linter failure, @zhengruifeng ?
```
annotations failed mypy checks:
python/pyspark/sql/connect/column.py:228: error: Argument 2 to "substring" has incompatible type "Column"; expected "int" [arg-type]
python/pyspark/sql/connect/column.py:228: error: Argument 3 to "substring" has incompatible type "Column"; expected "int" [arg-type]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #39204: [SPARK-41700][CONNECT][PYTHON] Remove `FunctionBuilder`
Posted by GitBox <gi...@apache.org>.
zhengruifeng closed pull request #39204: [SPARK-41700][CONNECT][PYTHON] Remove `FunctionBuilder`
URL: https://github.com/apache/spark/pull/39204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #39204: [SPARK-41700][CONNECT][PYTHON] Remove `FunctionBuilder`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #39204:
URL: https://github.com/apache/spark/pull/39204#issuecomment-1364497379
Cc @grundprinzip
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #39204: [SPARK-41700][CONNECT][PYTHON] Remove `FunctionBuilder`
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on code in PR #39204:
URL: https://github.com/apache/spark/pull/39204#discussion_r1056895975
##########
python/pyspark/sql/connect/column.py:
##########
@@ -226,7 +225,7 @@ def substr(self, startPos: Union[int, "Column"], length: Union[int, "Column"]) -
else:
start_exp = startPos
- return F.substr(self, start_exp, length_exp)
+ return substring(self, start_exp, length_exp)
Review Comment:
sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org