You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Till Toenshoff <to...@me.com> on 2017/08/10 15:50:02 UTC
Re: Dropping support for Apple Clang
Which version of Apple’s clang did you try for C++14? The latest version available is Apple LLVM version 9.0.0 (clang-900.0.22.8).
> On Jul 29, 2017, at 2:38 AM, Michael Park <mp...@apache.org> wrote:
>
> I'd like to drop support for Apple Clang.
>
> With the C++14 upgrade, we'll be requiring many distros to fetch a newer
> compiler. In most cases it only takes a few commands to get a newer
> compiler. This is also true of OS X, where clang-4.0 can be easily
> installed with `brew install llvm`.
>
> The current codebase does not compile with Apple Clang under C++14 mode. We
> could choose to investigate whether this is a Mesos bug or an Apple Clang
> bug, but after doing a brief investigation myself, I feel like it's not
> worth the effort. There are already cases where we need to install a new
> compiler on OS X due to Apple Clang releases based on clang-3.8 (MESOS-5745
> <https://issues.apache.org/jira/browse/MESOS-5745>).
>
> Not that Apple Clang was "officially" supported anyway, but we have had
> minor workarounds (e.g., THREAD_LOCAL) to support it.
>
> Please let me know what you think!
>
> Thanks,
>
> MPark
Re: Dropping support for Apple Clang
Posted by Michael Park <mc...@gmail.com>.
Thanks Dario!
On Thu, Aug 10, 2017 at 12:12 PM Dario Rexin <dr...@apple.com> wrote:
> Hey MPark,
>
> I just did a clean make check on your cpp14 branch with Apple LLVM version
> 9.0.0 (clang-900.0.22.8). It compiles fine and I got 1 test error on the
> first run, on a second run no tests failed, so I assume that’s just a flaky
> test.
>
> --
> Dario
>
> > On Aug 10, 2017, at 10:09 AM, Michael Park <mp...@apache.org> wrote:
> >
> >>
> >> Which version of Apple’s clang did you try for C++14? The latest version
> >> available is Apple LLVM version 9.0.0 (clang-900.0.22.8).
> >>
> >
> > I tested on
> >
> > Apple LLVM version 8.1.0 (clang-802.0.42)
> > Target: x86_64-apple-darwin16.7.0
> > Thread model: posix
> > InstalledDir: /Library/Developer/CommandLineTools/usr/bin
> >
> > Till, do you mind trying it out on 9.0.0?
> > You can just try building https://github.com/mpark/mesos/tree/cpp14
> >
> > MPark
> >
> >> On Jul 29, 2017, at 2:38 AM, Michael Park <mp...@apache.org> wrote:
> >>>
> >>> I'd like to drop support for Apple Clang.
> >>>
> >>> With the C++14 upgrade, we'll be requiring many distros to fetch a
> newer
> >>> compiler. In most cases it only takes a few commands to get a newer
> >>> compiler. This is also true of OS X, where clang-4.0 can be easily
> >>> installed with `brew install llvm`.
> >>>
> >>> The current codebase does not compile with Apple Clang under C++14
> mode.
> >> We
> >>> could choose to investigate whether this is a Mesos bug or an Apple
> Clang
> >>> bug, but after doing a brief investigation myself, I feel like it's not
> >>> worth the effort. There are already cases where we need to install a
> new
> >>> compiler on OS X due to Apple Clang releases based on clang-3.8
> >> (MESOS-5745
> >>> <https://issues.apache.org/jira/browse/MESOS-5745>).
> >>>
> >>> Not that Apple Clang was "officially" supported anyway, but we have had
> >>> minor workarounds (e.g., THREAD_LOCAL) to support it.
> >>>
> >>> Please let me know what you think!
> >>>
> >>> Thanks,
> >>>
> >>> MPark
> >>
> >>
>
>
Re: Dropping support for Apple Clang
Posted by Dario Rexin <dr...@apple.com>.
Hey MPark,
I just did a clean make check on your cpp14 branch with Apple LLVM version 9.0.0 (clang-900.0.22.8). It compiles fine and I got 1 test error on the first run, on a second run no tests failed, so I assume that’s just a flaky test.
--
Dario
> On Aug 10, 2017, at 10:09 AM, Michael Park <mp...@apache.org> wrote:
>
>>
>> Which version of Apple’s clang did you try for C++14? The latest version
>> available is Apple LLVM version 9.0.0 (clang-900.0.22.8).
>>
>
> I tested on
>
> Apple LLVM version 8.1.0 (clang-802.0.42)
> Target: x86_64-apple-darwin16.7.0
> Thread model: posix
> InstalledDir: /Library/Developer/CommandLineTools/usr/bin
>
> Till, do you mind trying it out on 9.0.0?
> You can just try building https://github.com/mpark/mesos/tree/cpp14
>
> MPark
>
>> On Jul 29, 2017, at 2:38 AM, Michael Park <mp...@apache.org> wrote:
>>>
>>> I'd like to drop support for Apple Clang.
>>>
>>> With the C++14 upgrade, we'll be requiring many distros to fetch a newer
>>> compiler. In most cases it only takes a few commands to get a newer
>>> compiler. This is also true of OS X, where clang-4.0 can be easily
>>> installed with `brew install llvm`.
>>>
>>> The current codebase does not compile with Apple Clang under C++14 mode.
>> We
>>> could choose to investigate whether this is a Mesos bug or an Apple Clang
>>> bug, but after doing a brief investigation myself, I feel like it's not
>>> worth the effort. There are already cases where we need to install a new
>>> compiler on OS X due to Apple Clang releases based on clang-3.8
>> (MESOS-5745
>>> <https://issues.apache.org/jira/browse/MESOS-5745>).
>>>
>>> Not that Apple Clang was "officially" supported anyway, but we have had
>>> minor workarounds (e.g., THREAD_LOCAL) to support it.
>>>
>>> Please let me know what you think!
>>>
>>> Thanks,
>>>
>>> MPark
>>
>>
Re: Dropping support for Apple Clang
Posted by Michael Park <mp...@apache.org>.
>
> Which version of Apple’s clang did you try for C++14? The latest version
> available is Apple LLVM version 9.0.0 (clang-900.0.22.8).
>
I tested on
Apple LLVM version 8.1.0 (clang-802.0.42)
Target: x86_64-apple-darwin16.7.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin
Till, do you mind trying it out on 9.0.0?
You can just try building https://github.com/mpark/mesos/tree/cpp14
MPark
> On Jul 29, 2017, at 2:38 AM, Michael Park <mp...@apache.org> wrote:
> >
> > I'd like to drop support for Apple Clang.
> >
> > With the C++14 upgrade, we'll be requiring many distros to fetch a newer
> > compiler. In most cases it only takes a few commands to get a newer
> > compiler. This is also true of OS X, where clang-4.0 can be easily
> > installed with `brew install llvm`.
> >
> > The current codebase does not compile with Apple Clang under C++14 mode.
> We
> > could choose to investigate whether this is a Mesos bug or an Apple Clang
> > bug, but after doing a brief investigation myself, I feel like it's not
> > worth the effort. There are already cases where we need to install a new
> > compiler on OS X due to Apple Clang releases based on clang-3.8
> (MESOS-5745
> > <https://issues.apache.org/jira/browse/MESOS-5745>).
> >
> > Not that Apple Clang was "officially" supported anyway, but we have had
> > minor workarounds (e.g., THREAD_LOCAL) to support it.
> >
> > Please let me know what you think!
> >
> > Thanks,
> >
> > MPark
>
>