You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Padma Priya N <pa...@gmail.com> on 2017/03/01 07:25:29 UTC
Review Request 57181: AMBARI-20206.Workflow manager is allowing to
have empty action node
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57181/
-----------------------------------------------------------
Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
Bugs: AMBARI-20206
https://issues.apache.org/jira/browse/AMBARI-20206
Repository: ambari
Description
-------
Modified validation to check for empty action node name.
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 2d326d1
contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js 8aac32b
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-errors.hbs 00cb8a6
contrib/views/wfmanager/src/main/resources/ui/app/templates/index.hbs d96be85
contrib/views/wfmanager/src/main/resources/ui/app/validators/duplicate-data-node-name.js 86e5182
contrib/views/wfmanager/src/main/resources/ui/app/validators/duplicate-kill-node-name.js b8770c2
Diff: https://reviews.apache.org/r/57181/diff/1/
Testing
-------
Manual Testing
Thanks,
Padma Priya N
Re: Review Request 57181: AMBARI-20206.Workflow manager is allowing
to have empty action node
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57181/#review167263
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On March 1, 2017, 7:25 a.m., Padma Priya N wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57181/
> -----------------------------------------------------------
>
> (Updated March 1, 2017, 7:25 a.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20206
> https://issues.apache.org/jira/browse/AMBARI-20206
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Modified validation to check for empty action node name.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 2d326d1
> contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js 8aac32b
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-errors.hbs 00cb8a6
> contrib/views/wfmanager/src/main/resources/ui/app/templates/index.hbs d96be85
> contrib/views/wfmanager/src/main/resources/ui/app/validators/duplicate-data-node-name.js 86e5182
> contrib/views/wfmanager/src/main/resources/ui/app/validators/duplicate-kill-node-name.js b8770c2
>
>
> Diff: https://reviews.apache.org/r/57181/diff/1/
>
>
> Testing
> -------
>
> Manual Testing
>
>
> Thanks,
>
> Padma Priya N
>
>
Re: Review Request 57181: AMBARI-20206.Workflow manager is allowing
to have empty action node
Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57181/#review167226
-----------------------------------------------------------
Ship it!
Ship It!
- belliraj hb
On March 1, 2017, 7:25 a.m., Padma Priya N wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57181/
> -----------------------------------------------------------
>
> (Updated March 1, 2017, 7:25 a.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20206
> https://issues.apache.org/jira/browse/AMBARI-20206
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Modified validation to check for empty action node name.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 2d326d1
> contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js 8aac32b
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-errors.hbs 00cb8a6
> contrib/views/wfmanager/src/main/resources/ui/app/templates/index.hbs d96be85
> contrib/views/wfmanager/src/main/resources/ui/app/validators/duplicate-data-node-name.js 86e5182
> contrib/views/wfmanager/src/main/resources/ui/app/validators/duplicate-kill-node-name.js b8770c2
>
>
> Diff: https://reviews.apache.org/r/57181/diff/1/
>
>
> Testing
> -------
>
> Manual Testing
>
>
> Thanks,
>
> Padma Priya N
>
>