You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2015/12/17 03:39:18 UTC

Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/
-----------------------------------------------------------

Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-2980
    https://issues.apache.org/jira/browse/MESOS-2980


Repository: mesos


Description
-------

Unified Container: Implemented passing entrypoint in runtime config.


Diffs
-----

  src/slave/containerizer/mesos/provisioner/docker/store.cpp 1ad7b67a94b1d9367afcb7c30a6d01fdf6b8ab6c 
  src/slave/containerizer/mesos/provisioner/store.hpp 8d1493856420dee3210af79b628c8c770c5c8550 
  src/tests/containerizer/provisioner_docker_tests.cpp 3f1717b770e139c3759aab0aeda9dbcf5029b0c2 

Diff: https://reviews.apache.org/r/41491/diff/


Testing
-------

make check


Thanks,

Gilbert Song

Re: Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/#review110880
-----------------------------------------------------------


Bad patch!

Reviews applied: [41011, 41125, 41194, 41406, 41407]

Failed command: ./support/apply-review.sh -n -r 41407

Error:
 2015-12-17 03:22:59 URL:https://reviews.apache.org/r/41407/diff/raw/ [3922/3922] -> "41407.patch" [1]
error: patch failed: src/slave/containerizer/mesos/provisioner/docker/puller.cpp:180
error: src/slave/containerizer/mesos/provisioner/docker/puller.cpp: patch does not apply

- Mesos ReviewBot


On Dec. 17, 2015, 2:39 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41491/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2015, 2:39 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2980
>     https://issues.apache.org/jira/browse/MESOS-2980
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Unified Container: Implemented passing entrypoint in runtime config.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 1ad7b67a94b1d9367afcb7c30a6d01fdf6b8ab6c 
>   src/slave/containerizer/mesos/provisioner/store.hpp 8d1493856420dee3210af79b628c8c770c5c8550 
>   src/tests/containerizer/provisioner_docker_tests.cpp 3f1717b770e139c3759aab0aeda9dbcf5029b0c2 
> 
> Diff: https://reviews.apache.org/r/41491/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/#review111183
-----------------------------------------------------------


Bad patch!

Reviews applied: [41011, 41125, 41194, 41406, 41407]

Failed command: ./support/apply-review.sh -n -r 41407

Error:
 2015-12-18 13:43:23 URL:https://reviews.apache.org/r/41407/diff/raw/ [4297/4297] -> "41407.patch" [1]
error: patch failed: src/slave/containerizer/mesos/provisioner/docker/puller.cpp:142
error: src/slave/containerizer/mesos/provisioner/docker/puller.cpp: patch does not apply

- Mesos ReviewBot


On Dec. 18, 2015, 9:21 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41491/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2015, 9:21 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2980
>     https://issues.apache.org/jira/browse/MESOS-2980
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Unified Container: Implemented passing entrypoint in runtime config.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 1ad7b67a94b1d9367afcb7c30a6d01fdf6b8ab6c 
>   src/slave/containerizer/mesos/provisioner/store.hpp 8d1493856420dee3210af79b628c8c770c5c8550 
>   src/tests/containerizer/provisioner_docker_tests.cpp 3f1717b770e139c3759aab0aeda9dbcf5029b0c2 
> 
> Diff: https://reviews.apache.org/r/41491/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

Posted by Gilbert Song <so...@gmail.com>.

> On Dec. 30, 2015, 6:41 p.m., Jie Yu wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp, line 1614
> > <https://reviews.apache.org/r/41491/diff/4/?file=1177068#file1177068line1614>
> >
> >     Why change this test?

Because we need to os::write manifest to disk and move it to store directory. We have to make sure `layId` is identical as "456"(originally we only need `layerid - path` pair for MockPuller), and two `layerPath` are redundant. We only use the last one.


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/#review112369
-----------------------------------------------------------


On Dec. 31, 2015, 3:06 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41491/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2015, 3:06 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4225
>     https://issues.apache.org/jira/browse/MESOS-4225
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Unified Container: Implemented passing entrypoint in runtime config.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp e951c96a7f9c5ff72f6993981e2e3744e3b837f6 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp b2e23d82ea255e1c91d7537a58f86632763d9a56 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 89d06e94bd2255bb4f2dad3fae75c1b3d789611d 
>   src/slave/containerizer/mesos/provisioner/store.hpp aec725f789f7aeb92abfcc6718c2e6e2f1f37981 
>   src/tests/containerizer/provisioner_docker_tests.cpp bb142f5ea99e8ea9b20a896f95ae37aa1d8d3f98 
> 
> Diff: https://reviews.apache.org/r/41491/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/#review112369
-----------------------------------------------------------



src/slave/containerizer/mesos/provisioner/docker/store.cpp (lines 163 - 164)
<https://reviews.apache.org/r/41491/#comment172840>

    This fits in one line?



src/slave/containerizer/mesos/provisioner/docker/store.cpp (line 166)
<https://reviews.apache.org/r/41491/#comment172841>

    s/v1DockerImageManifest/manifest/
    
    You need to rename the method parameter to `_manifest`



src/slave/containerizer/mesos/provisioner/docker/store.cpp (line 173)
<https://reviews.apache.org/r/41491/#comment172843>

    Why Option is needed here? An empty vector means no entry point, right?



src/slave/containerizer/mesos/provisioner/docker/store.cpp (line 175)
<https://reviews.apache.org/r/41491/#comment172842>

    You can use `->` operator to avoid `.get()`
    ```
    if (manifest->container_config().entrypoint_size() > 0)
    ```



src/slave/containerizer/mesos/provisioner/docker/store.cpp (lines 265 - 269)
<https://reviews.apache.org/r/41491/#comment172844>

    I would use the following indentation
    
    ```
    CHECK(!image.layer_ids().empty());
    
    Try<string> manifest = os::read(
        path::getImageLayerManifestPath(
            flags.docker_store_dir,
            image.layer_ids(image.layer_ids_size() - 1)));
    ```



src/tests/containerizer/provisioner_docker_tests.cpp (line 1614)
<https://reviews.apache.org/r/41491/#comment172846>

    Why change this test?


- Jie Yu


On Dec. 28, 2015, 11:49 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41491/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2015, 11:49 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4225
>     https://issues.apache.org/jira/browse/MESOS-4225
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Unified Container: Implemented passing entrypoint in runtime config.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp e951c96a7f9c5ff72f6993981e2e3744e3b837f6 
>   src/slave/containerizer/mesos/provisioner/store.hpp aec725f789f7aeb92abfcc6718c2e6e2f1f37981 
>   src/tests/containerizer/provisioner_docker_tests.cpp bb142f5ea99e8ea9b20a896f95ae37aa1d8d3f98 
> 
> Diff: https://reviews.apache.org/r/41491/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 41491: Unified Container: Exposed docker/appc image manifest to mesos containerizer.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/#review114636
-----------------------------------------------------------


Bad patch!

Reviews applied: [41491]

Failed command: ./support/apply-review.sh -n -r 41491

Error:
 2016-01-15 02:03:02 URL:https://reviews.apache.org/r/41491/diff/raw/ [7645/7645] -> "41491.patch" [1]
Total errors found: 0
Checking 5 files
Error: Commit message summary (the first line) must not exceed 72 characters.

- Mesos ReviewBot


On Jan. 15, 2016, 1:32 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41491/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2016, 1:32 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4225
>     https://issues.apache.org/jira/browse/MESOS-4225
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Unified Container: Exposed docker/appc image manifest to mesos containerizer.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 03425daaf015cf231920b7eda1d5424895a41286 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 4202f5552174ad3ab595ab3f16ab91d0854951f0 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 023f7363f33c4a927fae11037a408f6747fc3c39 
>   src/slave/containerizer/mesos/provisioner/store.hpp aec725f789f7aeb92abfcc6718c2e6e2f1f37981 
>   src/tests/containerizer/provisioner_docker_tests.cpp f81f0039dc12d09d85fda0be345d1509b4c6a664 
> 
> Diff: https://reviews.apache.org/r/41491/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 41491: Exposed docker/appc image manifest to mesos containerizer.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/#review114783
-----------------------------------------------------------


Patch looks great!

Reviews applied: [41491]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 15, 2016, 7:04 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41491/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2016, 7:04 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4225
>     https://issues.apache.org/jira/browse/MESOS-4225
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Exposed docker/appc image manifest to mesos containerizer.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 03425daaf015cf231920b7eda1d5424895a41286 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 4202f5552174ad3ab595ab3f16ab91d0854951f0 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 023f7363f33c4a927fae11037a408f6747fc3c39 
>   src/slave/containerizer/mesos/provisioner/store.hpp aec725f789f7aeb92abfcc6718c2e6e2f1f37981 
>   src/tests/containerizer/provisioner_docker_tests.cpp f81f0039dc12d09d85fda0be345d1509b4c6a664 
> 
> Diff: https://reviews.apache.org/r/41491/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 41491: Exposed docker image manifest to mesos containerizer.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/#review116609
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/provisioner/docker/store.cpp (line 219)
<https://reviews.apache.org/r/41491/#comment177683>

    CHECK_LT(0u, image.layer_ids_size());



src/slave/containerizer/mesos/provisioner/docker/store.cpp (lines 238 - 244)
<https://reviews.apache.org/r/41491/#comment177682>

    I think we already support parsing v1 manifest from string. No need for the JSON parsing part.



src/tests/containerizer/provisioner_docker_tests.cpp (line 1255)
<https://reviews.apache.org/r/41491/#comment177684>

    Can you add a TODO here. We need a helper to create test layers which will allow us to set manifest so that we can add checks here.


- Jie Yu


On Jan. 26, 2016, 5 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41491/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2016, 5 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, Qian Zhang, and Timothy Chen.
> 
> 
> Bugs: MESOS-4225
>     https://issues.apache.org/jira/browse/MESOS-4225
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Exposed docker image manifest to mesos containerizer.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 03425daaf015cf231920b7eda1d5424895a41286 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 4202f5552174ad3ab595ab3f16ab91d0854951f0 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 023f7363f33c4a927fae11037a408f6747fc3c39 
>   src/slave/containerizer/mesos/provisioner/store.hpp aec725f789f7aeb92abfcc6718c2e6e2f1f37981 
>   src/tests/containerizer/provisioner_docker_tests.cpp 33df60065903228749833bbad20449ba8784594a 
> 
> Diff: https://reviews.apache.org/r/41491/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 41491: Exposed docker image manifest to mesos containerizer.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/
-----------------------------------------------------------

(Updated Jan. 27, 2016, 11:55 a.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, Qian Zhang, and Timothy Chen.


Bugs: MESOS-4225
    https://issues.apache.org/jira/browse/MESOS-4225


Repository: mesos


Description
-------

Exposed docker image manifest to mesos containerizer.


Diffs (updated)
-----

  src/slave/containerizer/mesos/provisioner/docker/store.cpp 03425daaf015cf231920b7eda1d5424895a41286 
  src/slave/containerizer/mesos/provisioner/provisioner.hpp 4202f5552174ad3ab595ab3f16ab91d0854951f0 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 023f7363f33c4a927fae11037a408f6747fc3c39 
  src/slave/containerizer/mesos/provisioner/store.hpp aec725f789f7aeb92abfcc6718c2e6e2f1f37981 
  src/tests/containerizer/provisioner_docker_tests.cpp 33df60065903228749833bbad20449ba8784594a 

Diff: https://reviews.apache.org/r/41491/diff/


Testing
-------

make check


Thanks,

Gilbert Song

Re: Review Request 41491: Exposed docker image manifest to mesos containerizer.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/
-----------------------------------------------------------

(Updated Jan. 25, 2016, 9 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, Qian Zhang, and Timothy Chen.


Bugs: MESOS-4225
    https://issues.apache.org/jira/browse/MESOS-4225


Repository: mesos


Description
-------

Exposed docker image manifest to mesos containerizer.


Diffs (updated)
-----

  src/slave/containerizer/mesos/provisioner/docker/store.cpp 03425daaf015cf231920b7eda1d5424895a41286 
  src/slave/containerizer/mesos/provisioner/provisioner.hpp 4202f5552174ad3ab595ab3f16ab91d0854951f0 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 023f7363f33c4a927fae11037a408f6747fc3c39 
  src/slave/containerizer/mesos/provisioner/store.hpp aec725f789f7aeb92abfcc6718c2e6e2f1f37981 
  src/tests/containerizer/provisioner_docker_tests.cpp 33df60065903228749833bbad20449ba8784594a 

Diff: https://reviews.apache.org/r/41491/diff/


Testing
-------

make check


Thanks,

Gilbert Song

Re: Review Request 41491: Exposed docker image manifest to mesos containerizer.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/
-----------------------------------------------------------

(Updated Jan. 20, 2016, 12:19 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, Qian Zhang, and Timothy Chen.


Bugs: MESOS-4225
    https://issues.apache.org/jira/browse/MESOS-4225


Repository: mesos


Description
-------

Exposed docker image manifest to mesos containerizer.


Diffs (updated)
-----

  src/slave/containerizer/mesos/provisioner/docker/store.cpp 03425daaf015cf231920b7eda1d5424895a41286 
  src/slave/containerizer/mesos/provisioner/provisioner.hpp 4202f5552174ad3ab595ab3f16ab91d0854951f0 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 023f7363f33c4a927fae11037a408f6747fc3c39 
  src/slave/containerizer/mesos/provisioner/store.hpp aec725f789f7aeb92abfcc6718c2e6e2f1f37981 
  src/tests/containerizer/provisioner_docker_tests.cpp f81f0039dc12d09d85fda0be345d1509b4c6a664 

Diff: https://reviews.apache.org/r/41491/diff/


Testing
-------

make check


Thanks,

Gilbert Song

Re: Review Request 41491: Exposed docker image manifest to mesos containerizer.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/
-----------------------------------------------------------

(Updated Jan. 19, 2016, 6:56 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, Qian Zhang, and Timothy Chen.


Changes
-------

Updated summary msg.


Summary (updated)
-----------------

Exposed docker image manifest to mesos containerizer.


Bugs: MESOS-4225
    https://issues.apache.org/jira/browse/MESOS-4225


Repository: mesos


Description (updated)
-------

Exposed docker image manifest to mesos containerizer.


Diffs (updated)
-----

  src/slave/containerizer/mesos/provisioner/docker/store.cpp 03425daaf015cf231920b7eda1d5424895a41286 
  src/slave/containerizer/mesos/provisioner/provisioner.hpp 4202f5552174ad3ab595ab3f16ab91d0854951f0 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 023f7363f33c4a927fae11037a408f6747fc3c39 
  src/slave/containerizer/mesos/provisioner/store.hpp aec725f789f7aeb92abfcc6718c2e6e2f1f37981 
  src/tests/containerizer/provisioner_docker_tests.cpp f81f0039dc12d09d85fda0be345d1509b4c6a664 

Diff: https://reviews.apache.org/r/41491/diff/


Testing
-------

make check


Thanks,

Gilbert Song

Re: Review Request 41491: Exposed docker/appc image manifest to mesos containerizer.

Posted by Gilbert Song <so...@gmail.com>.

> On Jan. 17, 2016, 10:57 p.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/provisioner/provisioner.hpp, line 60
> > <https://reviews.apache.org/r/41491/diff/10/?file=1198406#file1198406line60>
> >
> >     We only expose Docker image manifest? But the summary of this RR says we will expose both docker and appc image manifest.

Thanks. Msg fixed.


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/#review114958
-----------------------------------------------------------


On Jan. 15, 2016, 11:04 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41491/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2016, 11:04 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4225
>     https://issues.apache.org/jira/browse/MESOS-4225
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Exposed docker/appc image manifest to mesos containerizer.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 03425daaf015cf231920b7eda1d5424895a41286 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 4202f5552174ad3ab595ab3f16ab91d0854951f0 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 023f7363f33c4a927fae11037a408f6747fc3c39 
>   src/slave/containerizer/mesos/provisioner/store.hpp aec725f789f7aeb92abfcc6718c2e6e2f1f37981 
>   src/tests/containerizer/provisioner_docker_tests.cpp f81f0039dc12d09d85fda0be345d1509b4c6a664 
> 
> Diff: https://reviews.apache.org/r/41491/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 41491: Exposed docker/appc image manifest to mesos containerizer.

Posted by Qian Zhang <zh...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/#review114958
-----------------------------------------------------------



src/slave/containerizer/mesos/provisioner/provisioner.hpp (line 60)
<https://reviews.apache.org/r/41491/#comment175796>

    We only expose Docker image manifest? But the summary of this RR says we will expose both docker and appc image manifest.


- Qian Zhang


On Jan. 16, 2016, 3:04 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41491/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2016, 3:04 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4225
>     https://issues.apache.org/jira/browse/MESOS-4225
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Exposed docker/appc image manifest to mesos containerizer.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 03425daaf015cf231920b7eda1d5424895a41286 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 4202f5552174ad3ab595ab3f16ab91d0854951f0 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 023f7363f33c4a927fae11037a408f6747fc3c39 
>   src/slave/containerizer/mesos/provisioner/store.hpp aec725f789f7aeb92abfcc6718c2e6e2f1f37981 
>   src/tests/containerizer/provisioner_docker_tests.cpp f81f0039dc12d09d85fda0be345d1509b4c6a664 
> 
> Diff: https://reviews.apache.org/r/41491/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 41491: Exposed docker/appc image manifest to mesos containerizer.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/
-----------------------------------------------------------

(Updated Jan. 15, 2016, 11:04 a.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Changes
-------

Updated comments.


Bugs: MESOS-4225
    https://issues.apache.org/jira/browse/MESOS-4225


Repository: mesos


Description
-------

Exposed docker/appc image manifest to mesos containerizer.


Diffs (updated)
-----

  src/slave/containerizer/mesos/provisioner/docker/store.cpp 03425daaf015cf231920b7eda1d5424895a41286 
  src/slave/containerizer/mesos/provisioner/provisioner.hpp 4202f5552174ad3ab595ab3f16ab91d0854951f0 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 023f7363f33c4a927fae11037a408f6747fc3c39 
  src/slave/containerizer/mesos/provisioner/store.hpp aec725f789f7aeb92abfcc6718c2e6e2f1f37981 
  src/tests/containerizer/provisioner_docker_tests.cpp f81f0039dc12d09d85fda0be345d1509b4c6a664 

Diff: https://reviews.apache.org/r/41491/diff/


Testing
-------

make check


Thanks,

Gilbert Song

Re: Review Request 41491: Exposed docker/appc image manifest to mesos containerizer.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/#review114690
-----------------------------------------------------------


Patch looks great!

Reviews applied: [41491]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 15, 2016, 5:30 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41491/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2016, 5:30 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4225
>     https://issues.apache.org/jira/browse/MESOS-4225
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Exposed docker/appc image manifest to mesos containerizer.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 03425daaf015cf231920b7eda1d5424895a41286 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 4202f5552174ad3ab595ab3f16ab91d0854951f0 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 023f7363f33c4a927fae11037a408f6747fc3c39 
>   src/slave/containerizer/mesos/provisioner/store.hpp aec725f789f7aeb92abfcc6718c2e6e2f1f37981 
>   src/tests/containerizer/provisioner_docker_tests.cpp f81f0039dc12d09d85fda0be345d1509b4c6a664 
> 
> Diff: https://reviews.apache.org/r/41491/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 41491: Exposed docker/appc image manifest to mesos containerizer.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/
-----------------------------------------------------------

(Updated Jan. 14, 2016, 9:30 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Summary (updated)
-----------------

Exposed docker/appc image manifest to mesos containerizer.


Bugs: MESOS-4225
    https://issues.apache.org/jira/browse/MESOS-4225


Repository: mesos


Description (updated)
-------

Exposed docker/appc image manifest to mesos containerizer.


Diffs (updated)
-----

  src/slave/containerizer/mesos/provisioner/docker/store.cpp 03425daaf015cf231920b7eda1d5424895a41286 
  src/slave/containerizer/mesos/provisioner/provisioner.hpp 4202f5552174ad3ab595ab3f16ab91d0854951f0 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 023f7363f33c4a927fae11037a408f6747fc3c39 
  src/slave/containerizer/mesos/provisioner/store.hpp aec725f789f7aeb92abfcc6718c2e6e2f1f37981 
  src/tests/containerizer/provisioner_docker_tests.cpp f81f0039dc12d09d85fda0be345d1509b4c6a664 

Diff: https://reviews.apache.org/r/41491/diff/


Testing
-------

make check


Thanks,

Gilbert Song

Re: Review Request 41491: Unified Container: Exposed docker/appc image manifest to mesos containerizer.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/
-----------------------------------------------------------

(Updated Jan. 14, 2016, 5:32 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-4225
    https://issues.apache.org/jira/browse/MESOS-4225


Repository: mesos


Description
-------

Unified Container: Exposed docker/appc image manifest to mesos containerizer.


Diffs (updated)
-----

  src/slave/containerizer/mesos/provisioner/docker/store.cpp 03425daaf015cf231920b7eda1d5424895a41286 
  src/slave/containerizer/mesos/provisioner/provisioner.hpp 4202f5552174ad3ab595ab3f16ab91d0854951f0 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 023f7363f33c4a927fae11037a408f6747fc3c39 
  src/slave/containerizer/mesos/provisioner/store.hpp aec725f789f7aeb92abfcc6718c2e6e2f1f37981 
  src/tests/containerizer/provisioner_docker_tests.cpp f81f0039dc12d09d85fda0be345d1509b4c6a664 

Diff: https://reviews.apache.org/r/41491/diff/


Testing
-------

make check


Thanks,

Gilbert Song

Re: Review Request 41491: Unified Container: Exposed docker/appc image manifest to mesos containerizer.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/
-----------------------------------------------------------

(Updated Jan. 13, 2016, 6:03 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-4225
    https://issues.apache.org/jira/browse/MESOS-4225


Repository: mesos


Description
-------

Unified Container: Exposed docker/appc image manifest to mesos containerizer.


Diffs (updated)
-----

  src/slave/containerizer/mesos/provisioner/docker/store.cpp 03425daaf015cf231920b7eda1d5424895a41286 
  src/slave/containerizer/mesos/provisioner/provisioner.hpp b2e23d82ea255e1c91d7537a58f86632763d9a56 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 89d06e94bd2255bb4f2dad3fae75c1b3d789611d 
  src/slave/containerizer/mesos/provisioner/store.hpp aec725f789f7aeb92abfcc6718c2e6e2f1f37981 
  src/tests/containerizer/provisioner_docker_tests.cpp 8d6a06057c7600aeb1aca76d4dfadc45b6eae99d 

Diff: https://reviews.apache.org/r/41491/diff/


Testing
-------

make check


Thanks,

Gilbert Song

Re: Review Request 41491: Unified Container: Exposed docker/appc image manifest to mesos containerizer.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/
-----------------------------------------------------------

(Updated Jan. 6, 2016, 5:15 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-4225
    https://issues.apache.org/jira/browse/MESOS-4225


Repository: mesos


Description
-------

Unified Container: Exposed docker/appc image manifest to mesos containerizer.


Diffs (updated)
-----

  src/slave/containerizer/mesos/provisioner/docker/store.cpp 03425daaf015cf231920b7eda1d5424895a41286 
  src/slave/containerizer/mesos/provisioner/provisioner.hpp b2e23d82ea255e1c91d7537a58f86632763d9a56 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 89d06e94bd2255bb4f2dad3fae75c1b3d789611d 
  src/slave/containerizer/mesos/provisioner/store.hpp aec725f789f7aeb92abfcc6718c2e6e2f1f37981 
  src/tests/containerizer/provisioner_docker_tests.cpp 8635eee1832cd4ab0e73e218106388d25d0278b7 

Diff: https://reviews.apache.org/r/41491/diff/


Testing
-------

make check


Thanks,

Gilbert Song

Re: Review Request 41491: Unified Container: Exposed docker/appc image manifest to mesos containerizer.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/
-----------------------------------------------------------

(Updated Dec. 31, 2015, 3:19 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Summary (updated)
-----------------

Unified Container: Exposed docker/appc image manifest to mesos containerizer.


Bugs: MESOS-4225
    https://issues.apache.org/jira/browse/MESOS-4225


Repository: mesos


Description (updated)
-------

Unified Container: Exposed docker/appc image manifest to mesos containerizer.


Diffs
-----

  src/slave/containerizer/mesos/provisioner/docker/store.cpp e951c96a7f9c5ff72f6993981e2e3744e3b837f6 
  src/slave/containerizer/mesos/provisioner/provisioner.hpp b2e23d82ea255e1c91d7537a58f86632763d9a56 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 89d06e94bd2255bb4f2dad3fae75c1b3d789611d 
  src/slave/containerizer/mesos/provisioner/store.hpp aec725f789f7aeb92abfcc6718c2e6e2f1f37981 
  src/tests/containerizer/provisioner_docker_tests.cpp bb142f5ea99e8ea9b20a896f95ae37aa1d8d3f98 

Diff: https://reviews.apache.org/r/41491/diff/


Testing
-------

make check


Thanks,

Gilbert Song

Re: Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/
-----------------------------------------------------------

(Updated Dec. 31, 2015, 3:06 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-4225
    https://issues.apache.org/jira/browse/MESOS-4225


Repository: mesos


Description
-------

Unified Container: Implemented passing entrypoint in runtime config.


Diffs (updated)
-----

  src/slave/containerizer/mesos/provisioner/docker/store.cpp e951c96a7f9c5ff72f6993981e2e3744e3b837f6 
  src/slave/containerizer/mesos/provisioner/provisioner.hpp b2e23d82ea255e1c91d7537a58f86632763d9a56 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 89d06e94bd2255bb4f2dad3fae75c1b3d789611d 
  src/slave/containerizer/mesos/provisioner/store.hpp aec725f789f7aeb92abfcc6718c2e6e2f1f37981 
  src/tests/containerizer/provisioner_docker_tests.cpp bb142f5ea99e8ea9b20a896f95ae37aa1d8d3f98 

Diff: https://reviews.apache.org/r/41491/diff/


Testing
-------

make check


Thanks,

Gilbert Song

Re: Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/
-----------------------------------------------------------

(Updated Dec. 28, 2015, 3:49 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-4225
    https://issues.apache.org/jira/browse/MESOS-4225


Repository: mesos


Description
-------

Unified Container: Implemented passing entrypoint in runtime config.


Diffs (updated)
-----

  src/slave/containerizer/mesos/provisioner/docker/store.cpp e951c96a7f9c5ff72f6993981e2e3744e3b837f6 
  src/slave/containerizer/mesos/provisioner/store.hpp aec725f789f7aeb92abfcc6718c2e6e2f1f37981 
  src/tests/containerizer/provisioner_docker_tests.cpp bb142f5ea99e8ea9b20a896f95ae37aa1d8d3f98 

Diff: https://reviews.apache.org/r/41491/diff/


Testing
-------

make check


Thanks,

Gilbert Song

Re: Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/#review111321
-----------------------------------------------------------


Patch looks great!

Reviews applied: [41011, 41125, 41194, 41406, 41407, 41487, 41488, 41489, 41490, 41491]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 18, 2015, 9:31 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41491/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2015, 9:31 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2980
>     https://issues.apache.org/jira/browse/MESOS-2980
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Unified Container: Implemented passing entrypoint in runtime config.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 1ad7b67a94b1d9367afcb7c30a6d01fdf6b8ab6c 
>   src/slave/containerizer/mesos/provisioner/store.hpp 8d1493856420dee3210af79b628c8c770c5c8550 
>   src/tests/containerizer/provisioner_docker_tests.cpp b57ee8681e0861cf93f5dcf9368c004a57df1374 
> 
> Diff: https://reviews.apache.org/r/41491/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/
-----------------------------------------------------------

(Updated Dec. 18, 2015, 1:31 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-2980
    https://issues.apache.org/jira/browse/MESOS-2980


Repository: mesos


Description
-------

Unified Container: Implemented passing entrypoint in runtime config.


Diffs (updated)
-----

  src/slave/containerizer/mesos/provisioner/docker/store.cpp 1ad7b67a94b1d9367afcb7c30a6d01fdf6b8ab6c 
  src/slave/containerizer/mesos/provisioner/store.hpp 8d1493856420dee3210af79b628c8c770c5c8550 
  src/tests/containerizer/provisioner_docker_tests.cpp b57ee8681e0861cf93f5dcf9368c004a57df1374 

Diff: https://reviews.apache.org/r/41491/diff/


Testing
-------

make check


Thanks,

Gilbert Song

Re: Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/
-----------------------------------------------------------

(Updated Dec. 18, 2015, 1:21 a.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-2980
    https://issues.apache.org/jira/browse/MESOS-2980


Repository: mesos


Description
-------

Unified Container: Implemented passing entrypoint in runtime config.


Diffs (updated)
-----

  src/slave/containerizer/mesos/provisioner/docker/store.cpp 1ad7b67a94b1d9367afcb7c30a6d01fdf6b8ab6c 
  src/slave/containerizer/mesos/provisioner/store.hpp 8d1493856420dee3210af79b628c8c770c5c8550 
  src/tests/containerizer/provisioner_docker_tests.cpp 3f1717b770e139c3759aab0aeda9dbcf5029b0c2 

Diff: https://reviews.apache.org/r/41491/diff/


Testing
-------

make check


Thanks,

Gilbert Song