You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "yl09099 (via GitHub)" <gi...@apache.org> on 2024/06/12 15:52:06 UTC

[PR] [#1778][Improvement] Dashboard adds the ability to automatically format code. [incubator-uniffle]

yl09099 opened a new pull request, #1779:
URL: https://github.com/apache/incubator-uniffle/pull/1779

   ### What changes were proposed in this pull request?
   
   Introducing the front-end eslint code validation tool and formatting the front-end code.
   
   ### Why are the changes needed?
   
   Fix: #1778 
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Existential test.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1778][Improvement] Dashboard adds the ability to automatically format code. [incubator-uniffle]

Posted by "yl09099 (via GitHub)" <gi...@apache.org>.
yl09099 commented on PR #1779:
URL: https://github.com/apache/incubator-uniffle/pull/1779#issuecomment-2164297244

   > > > Single quotes may be more suitable for front-end developers? @yl09099
   > > 
   > > 
   > > done. Format the code using the command "npx prettier . --write".
   > 
   > Could you add a job for checking style in the workflow?
   
   
   
   > > > Single quotes may be more suitable for front-end developers? @yl09099
   > > 
   > > 
   > > done. Format the code using the command "npx prettier . --write".
   > 
   > Could you add a job for checking style in the workflow?
   
   This format check rule is automatically triggered at compile time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1778][Improvement] Dashboard adds the ability to automatically format code. [incubator-uniffle]

Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.
xianjingfeng commented on PR #1779:
URL: https://github.com/apache/incubator-uniffle/pull/1779#issuecomment-2164211219

   Single quotes may be more suitable for front-end developers? @yl09099 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1778] improvement(dashboard): Dashboard adds the ability to automatically format code. [incubator-uniffle]

Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi merged PR #1779:
URL: https://github.com/apache/incubator-uniffle/pull/1779


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1778][Improvement] Dashboard adds the ability to automatically format code. [incubator-uniffle]

Posted by "yl09099 (via GitHub)" <gi...@apache.org>.
yl09099 commented on PR #1779:
URL: https://github.com/apache/incubator-uniffle/pull/1779#issuecomment-2164236867

   > Single quotes may be more suitable for front-end developers? @yl09099
   
   done. Format the code using the command "npx prettier . --write".


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1778][Improvement] Dashboard adds the ability to automatically format code. [incubator-uniffle]

Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #1779:
URL: https://github.com/apache/incubator-uniffle/pull/1779#issuecomment-2167080457

   > > Single quotes may be more suitable for front-end developers? @yl09099
   > 
   > done. Format the code using the command "npx prettier . --write".
   
   Could you add this format command into the dashboard doc? @yl09099 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1778][Improvement] Dashboard adds the ability to automatically format code. [incubator-uniffle]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1779:
URL: https://github.com/apache/incubator-uniffle/pull/1779#issuecomment-2163490703

   ## Test Results
    2 434 files  +5   2 434 suites  +5   5h 1m 53s :stopwatch: + 7m 59s
      937 tests ±0     936 :white_check_mark: +1   1 :zzz: ±0  0 :x: ±0 
   10 857 runs  +5  10 843 :white_check_mark: +6  14 :zzz: ±0  0 :x: ±0 
   
   Results for commit 50161684. ± Comparison against base commit fe2efe09.
   
   [test-results]:data:application/gzip;base64,H4sIAPDQaWYC/03MTQ6DIBCG4asY1l0wMMLYyzRT1ITUnwZh1fTuRaOU5fcwvB8x+mnYxL1RqPHWiC35WO8+BY5+XbIAAehM+T3uF52213psybmDzJ9e/r3/KjCynzLIAkMIazglpGVvgqTWnvOKZkNd7KziBVX12HXUrfPsYx6ilWDAEAJwx05Cr8gaxUhSj2iZ+GmsJqPE9wcBlYjzEgEAAA==
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1778][Improvement] Dashboard adds the ability to automatically format code. [incubator-uniffle]

Posted by "yl09099 (via GitHub)" <gi...@apache.org>.
yl09099 commented on code in PR #1779:
URL: https://github.com/apache/incubator-uniffle/pull/1779#discussion_r1637427069


##########
dashboard/src/main/webapp/.eslintignore:
##########
@@ -0,0 +1,4 @@
+/node_modules
+/package-lock.json
+/dist
+.DS_Store

Review Comment:
   What does this mean?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1778][Improvement] Dashboard adds the ability to automatically format code. [incubator-uniffle]

Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.
xianjingfeng commented on PR #1779:
URL: https://github.com/apache/incubator-uniffle/pull/1779#issuecomment-2164246735

   > > Single quotes may be more suitable for front-end developers? @yl09099
   > 
   > done. Format the code using the command "npx prettier . --write".
   
   Could you add a job for checking style in the workflow?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1778][Improvement] Dashboard adds the ability to automatically format code. [incubator-uniffle]

Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.
xianjingfeng commented on code in PR #1779:
URL: https://github.com/apache/incubator-uniffle/pull/1779#discussion_r1637409648


##########
dashboard/src/main/webapp/.eslintignore:
##########
@@ -0,0 +1,4 @@
+/node_modules
+/package-lock.json
+/dist
+.DS_Store

Review Comment:
   ```suggestion
   .DS_Store
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org