You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/07/30 16:25:36 UTC
[GitHub] [incubator-apisix] shuaijinchao opened a new pull request #1948: release: released 1.5.0 version.
shuaijinchao opened a new pull request #1948:
URL: https://github.com/apache/incubator-apisix/pull/1948
### What this PR does / why we need it:
released 1.5.0 version.
@apache/apisix-committers please do have a check.
@membphis After PR merge, please upload `apisix-1.5-0.rockspec` to https://luarocks.org/modules/apisix/apisix
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [x] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] moonming commented on a change in pull request #1948: release: released 1.5.0 version.
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #1948:
URL: https://github.com/apache/incubator-apisix/pull/1948#discussion_r463393607
##########
File path: README.md
##########
@@ -124,12 +125,12 @@ There are several ways to install the Apache Release version of APISIX:
- Installation runtime dependencies: OpenResty and etcd, and compilation dependencies: luarocks. Refer to [install dependencies documentation](doc/install-dependencies.md)
- Download the latest source code release package:
```shell
- wget http://www.apache.org/dist/incubator/apisix/1.4/apache-apisix-1.4-incubating-src.tar.gz
- tar zxvf apache-apisix-1.4-incubating-src.tar.gz
+ wget http://www.apache.org/dist/incubator/apisix/1.5/apache-apisix-1.5-incubating-src.tar.gz
Review comment:
the TLP dir is not begin with `incubator`
##########
File path: README.md
##########
@@ -124,12 +125,12 @@ There are several ways to install the Apache Release version of APISIX:
- Installation runtime dependencies: OpenResty and etcd, and compilation dependencies: luarocks. Refer to [install dependencies documentation](doc/install-dependencies.md)
- Download the latest source code release package:
```shell
- wget http://www.apache.org/dist/incubator/apisix/1.4/apache-apisix-1.4-incubating-src.tar.gz
- tar zxvf apache-apisix-1.4-incubating-src.tar.gz
+ wget http://www.apache.org/dist/incubator/apisix/1.5/apache-apisix-1.5-incubating-src.tar.gz
+ tar zxvf apache-apisix-1.5-incubating-src.tar.gz
Review comment:
we need to remove all `incubating`, because Apache APISIX is TLP now.
##########
File path: README.md
##########
@@ -124,12 +125,12 @@ There are several ways to install the Apache Release version of APISIX:
- Installation runtime dependencies: OpenResty and etcd, and compilation dependencies: luarocks. Refer to [install dependencies documentation](doc/install-dependencies.md)
- Download the latest source code release package:
```shell
- wget http://www.apache.org/dist/incubator/apisix/1.4/apache-apisix-1.4-incubating-src.tar.gz
- tar zxvf apache-apisix-1.4-incubating-src.tar.gz
+ wget http://www.apache.org/dist/incubator/apisix/1.5/apache-apisix-1.5-incubating-src.tar.gz
+ tar zxvf apache-apisix-1.5-incubating-src.tar.gz
```
- Install the dependencies：
```shell
- cd apache-apisix-1.4-incubating
+ cd apache-apisix-1.5-incubating
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org