You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Josh McKenzie (Jira)" <ji...@apache.org> on 2022/02/03 19:42:00 UTC

[jira] [Commented] (CASSANDRA-17078) Fix failing test: SSTableReaderTest.testPersistentStatistics

    [ https://issues.apache.org/jira/browse/CASSANDRA-17078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486678#comment-17486678 ] 

Josh McKenzie commented on CASSANDRA-17078:
-------------------------------------------

Got a prelim branch [here|https://github.com/apache/cassandra/compare/trunk...josh-mckenzie:cassandra-17078?expand=1] that does a few things in SSTableReaderTest:
1. Removes duplication on the CF SSTable discarding at the start of many tests
2. Isolates the test w/the intermittent failure in circle to its own CF instead of sharing w/other tests
3. Isolates the test that has a couple potentially troublesome calls (.deleteOnExit, etc) that may be leading to ordering and timing issues between tests.

A lot of these tests are mucking around directly with SSTable files, deleting things, moving things, deleting directories and files with hooks, you name it. A lot of stuff that's risky when it comes to consistency if the parallelization of your test running infra doesn't have deterministic test ordering. 

Not sure if I can repro the original problem locally; going to give it a solid soak and if it doesn't repro try it on circle for a multiplex run as well.

> Fix failing test: SSTableReaderTest.testPersistentStatistics
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-17078
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17078
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/unit
>            Reporter: Josh McKenzie
>            Assignee: Josh McKenzie
>            Priority: Normal
>             Fix For: 4.x
>
>
> JDK8 unit test failure
> See it on CircleCI but not on Jenkins ASF infra right now.
> {code:java}
> java.lang.RuntimeException: Failed importing sstables
> 	at org.apache.cassandra.db.SSTableImporter.importNewSSTables(SSTableImporter.java:164)
> 	at org.apache.cassandra.db.ColumnFamilyStore.loadNewSSTables(ColumnFamilyStore.java:734)
> 	at org.apache.cassandra.io.sstable.SSTableReaderTest.clearAndLoad(SSTableReaderTest.java:222)
> 	at org.apache.cassandra.io.sstable.SSTableReaderTest.testPersistentStatistics(SSTableReaderTest.java:215)
> Caused by: java.lang.RuntimeException: Failed to rename /tmp/cassandra/build/test/cassandra/data/SSTableReaderTest/Standard1-da581e50380611ecaad41173773221f9/nb-9-big-Digest.crc32 to /tmp/cassandra/build/test/cassandra/data/SSTableReaderTest/Standard1-da581e50380611ecaad41173773221f9/nb-13-big-Digest.crc32
> 	at org.apache.cassandra.io.util.PathUtils.rename(PathUtils.java:385)
> 	at org.apache.cassandra.io.util.File.move(File.java:227)
> 	at org.apache.cassandra.io.util.FileUtils.renameWithConfirm(FileUtils.java:704)
> 	at org.apache.cassandra.io.util.FileUtils.renameWithConfirm(FileUtils.java:698)
> 	at org.apache.cassandra.io.sstable.format.SSTableWriter.rename(SSTableWriter.java:337)
> 	at org.apache.cassandra.io.sstable.format.SSTableReader.moveAndOpenSSTable(SSTableReader.java:2339)
> 	at org.apache.cassandra.db.SSTableImporter.importNewSSTables(SSTableImporter.java:139)
> Caused by: java.nio.file.NoSuchFileException: /tmp/cassandra/build/test/cassandra/data/SSTableReaderTest/Standard1-da581e50380611ecaad41173773221f9/nb-9-big-Digest.crc32 -> /tmp/cassandra/build/test/cassandra/data/SSTableReaderTest/Standard1-da581e50380611ecaad41173773221f9/nb-13-big-Digest.crc32
> 	at sun.nio.fs.UnixException.translateToIOException(UnixException.java:86)
> 	at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
> 	at sun.nio.fs.UnixCopyFile.move(UnixCopyFile.java:396)
> 	at sun.nio.fs.UnixFileSystemProvider.move(UnixFileSystemProvider.java:262)
> 	at java.nio.file.Files.move(Files.java:1395)
> 	at org.apache.cassandra.io.util.PathUtils.atomicMoveWithFallback(PathUtils.java:396)
> 	at org.apache.cassandra.io.util.PathUtils.rename(PathUtils.java:377)
> {code}
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org