[GitHub] [accumulo] dlmarion commented on a diff in pull request #2732: Prevent tserver shutdown when only 1 tserver running.

[GitBox <gi...@apache.org>]

dlmarion commented on code in PR #2732:
URL: https://github.com/apache/accumulo/pull/2732#discussion_r882627789


##########
server/manager/src/main/java/org/apache/accumulo/manager/tserverOps/ShutdownTServer.java:
##########
@@ -57,6 +57,13 @@ public long isReady(long tid, Manager manager) {
       return 0;
     }
 
+    // if one tserver is remaining throw an error and return before attempting shutdown
+    if (manager.onlineTabletServers().size() == 1) {
+      log.error("Only 1 tserver running and it contains the Root table. Not shutting down {}. ",
+          server);
+      return 0;

Review Comment:
   I'm not sure that this is doing what the comment suggests. Returning 0 means that the FateOp is ready for execution and the `call` method will be executed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org