You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/10/05 12:53:33 UTC
[GitHub] [apisix-website] guoqqqi opened a new pull request #641: feat: update the blog page
guoqqqi opened a new pull request #641:
URL: https://github.com/apache/apisix-website/pull/641
Changes:
1. Left sidebar replaced with tags
<!-- Add here what changes were made in this pull request and if possible provide links showcasing the changes. -->
Screenshots of the change:
<!-- Add screenshots depicting the changes. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on a change in pull request #641: feat: update the blog page
Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on a change in pull request #641:
URL: https://github.com/apache/apisix-website/pull/641#discussion_r722679257
##########
File path: website/src/theme/BlogPostItem/index.js
##########
@@ -0,0 +1,134 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
Review comment:
Yup, the blog page is not so customisable directly, so docusaurus has this functionality to `swizzle` out elements,
Refer to this - [`swizzle`](https://github.com/apache/apisix-website/issues/490#issuecomment-911850832)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] guoqqqi commented on pull request #641: feat: update the blog page
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on pull request #641:
URL: https://github.com/apache/apisix-website/pull/641#issuecomment-934440047
I am not currently adding too much styling to the header page and I have a few problems that I need help with.
1. if I add a background colour or image to the header section, it doesn't seem to match the style of the other pages, like the team etc page
2. there seems to be some empty space and I'm torn between removing it and adding the header, but I think it looks good too, it just looks like something is missing
cc @juzhiyuan @1502shivam-singh @Baoyuantop @bzp2010 @liuxiran
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on pull request #641: feat: update the blog page
Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on pull request #641:
URL: https://github.com/apache/apisix-website/pull/641#issuecomment-934829074
> 2. there seems to be some empty space and I'm torn between removing it and adding the header, but I think it looks good too, it just looks like something is missing
Absence of balancing visual element i guess (check example below). Though, it seems trivial to me for now, we can work on it later maybe.
the dots graphic and slight color change does that here. We can too put something less focus wanting, but a balancing visual element in the right or left area for some balance.
Though, this one also looks fine too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #641: feat: update the blog page
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #641:
URL: https://github.com/apache/apisix-website/pull/641#discussion_r722278022
##########
File path: website/src/theme/BlogPostItem/index.js
##########
@@ -0,0 +1,134 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
Review comment:
This file is copied from Facebook?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on a change in pull request #641: feat: update the blog page
Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on a change in pull request #641:
URL: https://github.com/apache/apisix-website/pull/641#discussion_r722663987
##########
File path: website/src/theme/BlogTagsPostsPage/index.js
##########
@@ -0,0 +1,68 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+import React, { useEffect, useState } from 'react';
+import Layout from '@theme/Layout';
+import BlogPostItem from '@theme/BlogPostItem';
+import BlogSidebar from '@theme/BlogSidebar';
+import { ThemeClassNames } from '@docusaurus/theme-common'; // Very simple pluralization: probably good enough for now
+
+function BlogTagsPostPage(props) {
+ const { metadata, items } = props;
+ const { name: tagName } = metadata;
+ const [, setTagsCount] = useState();
+ const tagsTotal = JSON.parse(localStorage.getItem('tagsTotal'));
Review comment:
Will pushing the definition of this in useEffect cause some errors ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan merged pull request #641: feat: update the blog page
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #641:
URL: https://github.com/apache/apisix-website/pull/641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on a change in pull request #641: feat: update the blog page
Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on a change in pull request #641:
URL: https://github.com/apache/apisix-website/pull/641#discussion_r722663987
##########
File path: website/src/theme/BlogTagsPostsPage/index.js
##########
@@ -0,0 +1,68 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+import React, { useEffect, useState } from 'react';
+import Layout from '@theme/Layout';
+import BlogPostItem from '@theme/BlogPostItem';
+import BlogSidebar from '@theme/BlogSidebar';
+import { ThemeClassNames } from '@docusaurus/theme-common'; // Very simple pluralization: probably good enough for now
+
+function BlogTagsPostPage(props) {
+ const { metadata, items } = props;
+ const { name: tagName } = metadata;
+ const [, setTagsCount] = useState();
+ const tagsTotal = JSON.parse(localStorage.getItem('tagsTotal'));
Review comment:
Will pushing the definition of `tagsTotal` in useEffect cause some errors or unwanted behaviour ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh edited a comment on pull request #641: feat: update the blog page
Posted by GitBox <gi...@apache.org>.
1502shivam-singh edited a comment on pull request #641:
URL: https://github.com/apache/apisix-website/pull/641#issuecomment-934829074
> 2. there seems to be some empty space and I'm torn between removing it and adding the header, but I think it looks good too, it just looks like something is missing
Absence of balancing visual element i guess (check example below). Though, it seems trivial to me for now, we can work on it later maybe.
the dots graphic and slight color change does that here. We can too put something less focus wanting, but a balancing visual element in the right or left area for some balance.
Though, this one looks fine too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] guoqqqi commented on a change in pull request #641: feat: update the blog page
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on a change in pull request #641:
URL: https://github.com/apache/apisix-website/pull/641#discussion_r722283461
##########
File path: website/src/theme/BlogPostItem/index.js
##########
@@ -0,0 +1,134 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
Review comment:
The file is a commit of the PR I recovered under https://github.com/apache/apisix-website/pull/616 and it appears to be a shell CLI generated file, https://docusaurus.io/docs/cli#docusaurus-swizzle-sitedir
cc @Baoyuantop have a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on a change in pull request #641: feat: update the blog page
Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on a change in pull request #641:
URL: https://github.com/apache/apisix-website/pull/641#discussion_r722663987
##########
File path: website/src/theme/BlogTagsPostsPage/index.js
##########
@@ -0,0 +1,68 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+import React, { useEffect, useState } from 'react';
+import Layout from '@theme/Layout';
+import BlogPostItem from '@theme/BlogPostItem';
+import BlogSidebar from '@theme/BlogSidebar';
+import { ThemeClassNames } from '@docusaurus/theme-common'; // Very simple pluralization: probably good enough for now
+
+function BlogTagsPostPage(props) {
+ const { metadata, items } = props;
+ const { name: tagName } = metadata;
+ const [, setTagsCount] = useState();
+ const tagsTotal = JSON.parse(localStorage.getItem('tagsTotal'));
Review comment:
Will pushing the definition of `tagsTotal` in useEffect cause some errors ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org