[jira] [Updated] (HBASE-5295) Improve the Thrift API to switch on/off writing to wal for Mutations

["Phabricator (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phabricator updated HBASE-5295:
-------------------------------

    Attachment: D3015.1.patch

mbautin requested code review of "[jira] [HBASE-5295] [89-fb] Improve the Thrift API to switch on/off writing to wal for Mutations".
Reviewers: Kannan, dhruba, sc, JIRA

  Porting Dhruba's patch from HBASE-5295 to 89-fb add a writeToWAL flag to the Mutation Thrift API. Also adding a new unit test and fixing an inconsistency in the mutateRow API in case different Mutation objects have different values of writeToWAL specified.

TEST PLAN
  Exiting unit tests
  New unit test

REVISION DETAIL
  https://reviews.facebook.net/D3015

AFFECTED FILES
  src/main/java/org/apache/hadoop/hbase/KeyValue.java
  src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
  src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
  src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java
  src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java
  src/main/java/org/apache/hadoop/hbase/util/Bytes.java
  src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift
  src/test/java/org/apache/hadoop/hbase/HTestConst.java
  src/test/java/org/apache/hadoop/hbase/thrift/TestMutationWriteToWAL.java
  src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
  src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerLegacy.java

MANAGE HERALD DIFFERENTIAL RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/6861/

Tip: use the X-Herald-Rules header to filter Herald messages in your client.

                
> Improve the Thrift API  to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
>                 Key: HBASE-5295
>                 URL: https://issues.apache.org/jira/browse/HBASE-5295
>             Project: HBase
>          Issue Type: Improvement
>          Components: thrift
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>         Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch, D3015.1.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira