You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "lxr599 (via GitHub)" <gi...@apache.org> on 2024/07/23 05:58:27 UTC
[PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
lxr599 opened a new pull request, #38236:
URL: https://github.com/apache/doris/pull/38236
## Proposed changes
get the correct value of `row_store_page_size` after FE restarts
<!--Describe your changes.-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2244407274
<details>
<summary>TPC-DS: <b>Total hot run time: 173760 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 759ef99c74e45d0f4d6b4784614b9045df1026e8, data reload: false
query1 906 375 371 371
query2 6411 1917 1866 1866
query3 6655 208 212 208
query4 28458 17619 17423 17423
query5 3744 478 489 478
query6 270 170 163 163
query7 4584 290 277 277
query8 265 193 194 193
query9 8484 2409 2360 2360
query10 437 290 266 266
query11 11813 10098 10079 10079
query12 113 88 80 80
query13 1625 365 354 354
query14 10020 7735 7570 7570
query15 226 168 165 165
query16 7765 513 475 475
query17 1384 558 519 519
query18 1957 270 270 270
query19 200 153 154 153
query20 96 89 84 84
query21 217 125 123 123
query22 4408 4072 4121 4072
query23 34224 34266 33642 33642
query24 11146 2870 2935 2870
query25 593 386 377 377
query26 706 149 154 149
query27 2322 280 276 276
query28 6215 2026 2042 2026
query29 889 653 610 610
query30 297 155 157 155
query31 1002 767 761 761
query32 100 59 60 59
query33 792 337 338 337
query34 960 483 497 483
query35 891 772 811 772
query36 1176 967 945 945
query37 149 83 89 83
query38 3001 2940 2824 2824
query39 950 819 809 809
query40 208 119 116 116
query41 47 43 42 42
query42 118 103 96 96
query43 531 489 488 488
query44 1147 709 717 709
query45 196 164 160 160
query46 1096 753 725 725
query47 1873 1779 1781 1779
query48 357 288 285 285
query49 892 396 416 396
query50 782 388 393 388
query51 6725 6675 6678 6675
query52 102 92 88 88
query53 356 286 283 283
query54 943 471 436 436
query55 76 74 72 72
query56 286 260 268 260
query57 1154 1045 1072 1045
query58 258 276 258 258
query59 3019 2617 2636 2617
query60 307 280 282 280
query61 94 97 91 91
query62 773 653 645 645
query63 317 281 280 280
query64 9197 2197 1648 1648
query65 3164 3137 3103 3103
query66 743 329 332 329
query67 15512 14993 14887 14887
query68 4508 536 524 524
query69 504 322 338 322
query70 1201 1157 1092 1092
query71 363 281 285 281
query72 6735 5754 5634 5634
query73 758 326 319 319
query74 6230 5768 5712 5712
query75 3380 2654 2681 2654
query76 2255 1017 894 894
query77 509 304 301 301
query78 9950 9040 8889 8889
query79 2837 517 524 517
query80 2876 470 469 469
query81 599 220 222 220
query82 928 137 147 137
query83 312 173 165 165
query84 285 90 83 83
query85 2127 307 292 292
query86 482 315 335 315
query87 3316 3220 3095 3095
query88 4052 2354 2340 2340
query89 500 393 379 379
query90 1861 193 189 189
query91 194 97 101 97
query92 61 47 49 47
query93 4699 501 507 501
query94 1211 289 297 289
query95 402 320 312 312
query96 619 267 273 267
query97 3216 3051 3051 3051
query98 220 209 214 209
query99 1698 1265 1256 1256
Total cold run time: 284612 ms
Total hot run time: 173760 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2244321917
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "lxr599 (via GitHub)" <gi...@apache.org>.
lxr599 commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2244315321
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2245231733
<details>
<summary>ClickBench: <b>Total hot run time: 31.08 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit cb7548ef242a850ef4931c0b9a152e41dc087614, data reload: false
query1 0.04 0.04 0.03
query2 0.08 0.03 0.04
query3 0.22 0.04 0.05
query4 1.68 0.08 0.08
query5 0.49 0.47 0.47
query6 1.13 0.73 0.72
query7 0.02 0.02 0.01
query8 0.05 0.04 0.04
query9 0.54 0.50 0.48
query10 0.54 0.54 0.54
query11 0.16 0.12 0.12
query12 0.15 0.12 0.13
query13 0.60 0.59 0.59
query14 0.77 0.77 0.77
query15 0.86 0.81 0.82
query16 0.36 0.37 0.38
query17 1.02 0.95 0.96
query18 0.22 0.22 0.21
query19 1.77 1.71 1.72
query20 0.01 0.00 0.01
query21 15.41 0.78 0.66
query22 3.99 6.08 2.44
query23 18.31 1.53 1.27
query24 2.15 0.25 0.22
query25 0.17 0.09 0.08
query26 0.30 0.22 0.21
query27 0.45 0.23 0.23
query28 13.23 1.02 1.00
query29 12.59 3.29 3.29
query30 0.27 0.06 0.05
query31 2.87 0.38 0.39
query32 3.30 0.48 0.48
query33 2.87 2.89 2.90
query34 16.94 4.35 4.33
query35 4.37 4.41 4.42
query36 0.65 0.47 0.47
query37 0.19 0.15 0.15
query38 0.15 0.15 0.15
query39 0.04 0.03 0.04
query40 0.16 0.13 0.12
query41 0.09 0.05 0.05
query42 0.05 0.05 0.05
query43 0.06 0.03 0.04
Total cold run time: 109.32 s
Total hot run time: 31.08 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2247051421
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "lxr599 (via GitHub)" <gi...@apache.org>.
lxr599 commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2247045943
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "lxr599 (via GitHub)" <gi...@apache.org>.
lxr599 commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2245321687
run external
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2247520861
<details>
<summary>ClickBench: <b>Total hot run time: 30.95 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 297dc779c2e1a2e002e0041c33a09a620fb9e692, data reload: false
query1 0.04 0.04 0.03
query2 0.08 0.04 0.04
query3 0.23 0.04 0.05
query4 1.68 0.09 0.11
query5 0.52 0.47 0.47
query6 1.15 0.73 0.73
query7 0.02 0.02 0.01
query8 0.06 0.04 0.04
query9 0.55 0.48 0.48
query10 0.54 0.53 0.53
query11 0.16 0.11 0.12
query12 0.14 0.12 0.13
query13 0.60 0.59 0.59
query14 0.77 0.79 0.78
query15 0.86 0.82 0.82
query16 0.37 0.37 0.36
query17 0.95 0.95 0.97
query18 0.24 0.22 0.21
query19 1.81 1.71 1.74
query20 0.01 0.02 0.01
query21 15.47 0.78 0.64
query22 4.22 6.46 2.28
query23 18.27 1.38 1.28
query24 2.18 0.24 0.22
query25 0.15 0.08 0.08
query26 0.30 0.21 0.22
query27 0.46 0.24 0.23
query28 13.13 1.04 1.02
query29 12.63 3.34 3.32
query30 0.25 0.06 0.05
query31 2.88 0.39 0.40
query32 3.26 0.50 0.47
query33 2.93 2.86 2.91
query34 16.96 4.33 4.36
query35 4.39 4.37 4.43
query36 0.66 0.50 0.47
query37 0.19 0.16 0.16
query38 0.16 0.15 0.15
query39 0.05 0.04 0.04
query40 0.16 0.13 0.12
query41 0.09 0.05 0.05
query42 0.06 0.05 0.05
query43 0.04 0.04 0.04
Total cold run time: 109.67 s
Total hot run time: 30.95 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2244417011
<details>
<summary>ClickBench: <b>Total hot run time: 31.35 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 759ef99c74e45d0f4d6b4784614b9045df1026e8, data reload: false
query1 0.04 0.04 0.03
query2 0.09 0.03 0.04
query3 0.22 0.04 0.04
query4 1.68 0.07 0.08
query5 0.50 0.49 0.49
query6 1.15 0.73 0.73
query7 0.02 0.02 0.01
query8 0.06 0.04 0.04
query9 0.55 0.50 0.50
query10 0.54 0.55 0.55
query11 0.16 0.12 0.12
query12 0.15 0.12 0.13
query13 0.60 0.58 0.58
query14 0.76 0.78 0.78
query15 0.86 0.81 0.81
query16 0.35 0.36 0.37
query17 0.99 0.97 1.06
query18 0.22 0.21 0.22
query19 1.81 1.67 1.70
query20 0.02 0.01 0.01
query21 15.42 0.80 0.67
query22 3.83 7.35 2.45
query23 18.26 1.42 1.38
query24 2.05 0.22 0.24
query25 0.14 0.10 0.08
query26 0.31 0.21 0.20
query27 0.45 0.24 0.23
query28 13.32 1.01 1.00
query29 12.59 3.27 3.30
query30 0.25 0.06 0.06
query31 2.86 0.41 0.39
query32 3.23 0.48 0.46
query33 2.89 2.93 2.98
query34 16.96 4.37 4.36
query35 4.52 4.47 4.47
query36 0.66 0.47 0.46
query37 0.19 0.16 0.16
query38 0.15 0.15 0.15
query39 0.04 0.03 0.04
query40 0.16 0.13 0.13
query41 0.10 0.05 0.05
query42 0.06 0.04 0.05
query43 0.05 0.04 0.04
Total cold run time: 109.26 s
Total hot run time: 31.35 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2247185958
<details>
<summary>ClickBench: <b>Total hot run time: 30.53 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 26e18ac623c12ffa189e17ac6897901ce8faa0c0, data reload: false
query1 0.04 0.03 0.03
query2 0.07 0.04 0.04
query3 0.22 0.04 0.05
query4 1.68 0.08 0.08
query5 0.50 0.49 0.48
query6 1.13 0.73 0.73
query7 0.02 0.02 0.01
query8 0.05 0.04 0.05
query9 0.55 0.50 0.48
query10 0.54 0.54 0.54
query11 0.15 0.12 0.11
query12 0.14 0.13 0.12
query13 0.59 0.60 0.59
query14 0.75 0.77 0.78
query15 0.86 0.81 0.82
query16 0.36 0.36 0.37
query17 0.95 0.94 0.95
query18 0.23 0.23 0.22
query19 1.81 1.68 1.69
query20 0.01 0.01 0.01
query21 15.42 0.74 0.65
query22 4.66 6.96 1.99
query23 18.29 1.43 1.26
query24 2.09 0.22 0.22
query25 0.15 0.10 0.08
query26 0.29 0.21 0.21
query27 0.45 0.22 0.23
query28 13.32 1.02 1.00
query29 12.60 3.32 3.31
query30 0.25 0.05 0.06
query31 2.88 0.39 0.39
query32 3.26 0.49 0.46
query33 2.89 2.93 2.86
query34 16.96 4.37 4.33
query35 4.43 4.42 4.38
query36 0.65 0.50 0.46
query37 0.19 0.16 0.15
query38 0.16 0.15 0.15
query39 0.04 0.03 0.04
query40 0.14 0.12 0.13
query41 0.09 0.05 0.04
query42 0.06 0.05 0.05
query43 0.05 0.04 0.04
Total cold run time: 109.97 s
Total hot run time: 30.53 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "lxr599 (via GitHub)" <gi...@apache.org>.
lxr599 commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2247306407
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2247153285
<details>
<summary>TPC-H: <b>Total hot run time: 39743 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 26e18ac623c12ffa189e17ac6897901ce8faa0c0, data reload: false
------ Round 1 ----------------------------------
q1 17650 4327 4280 4280
q2 2023 188 189 188
q3 10401 1169 1132 1132
q4 10187 815 708 708
q5 7533 2794 2647 2647
q6 218 139 139 139
q7 952 598 596 596
q8 9216 2081 2081 2081
q9 8777 6583 6559 6559
q10 8789 3778 3783 3778
q11 491 235 237 235
q12 397 227 222 222
q13 17873 2955 2988 2955
q14 273 234 234 234
q15 523 481 497 481
q16 521 368 375 368
q17 965 641 763 641
q18 8064 7592 7358 7358
q19 7370 1456 1311 1311
q20 661 329 326 326
q21 4915 3219 3309 3219
q22 351 286 285 285
Total cold run time: 118150 ms
Total hot run time: 39743 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4431 4231 4238 4231
q2 376 277 257 257
q3 2964 2884 2976 2884
q4 1972 1670 1762 1670
q5 5647 5530 5433 5433
q6 229 138 130 130
q7 2183 1842 1838 1838
q8 3246 3425 3453 3425
q9 8800 8825 8897 8825
q10 4138 3878 3708 3708
q11 592 516 502 502
q12 807 661 618 618
q13 16907 3167 3181 3167
q14 321 301 290 290
q15 518 500 478 478
q16 505 436 437 436
q17 1819 1520 1515 1515
q18 8131 8057 7828 7828
q19 1736 1666 1575 1575
q20 2936 1911 1855 1855
q21 8157 4894 4629 4629
q22 607 501 537 501
Total cold run time: 77022 ms
Total hot run time: 55795 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2247039942
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "lxr599 (via GitHub)" <gi...@apache.org>.
lxr599 commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2247320977
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "lxr599 (via GitHub)" <gi...@apache.org>.
lxr599 commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2246689453
run external
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2244389225
<details>
<summary>TPC-H: <b>Total hot run time: 40059 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 759ef99c74e45d0f4d6b4784614b9045df1026e8, data reload: false
------ Round 1 ----------------------------------
q1 18835 7676 4310 4310
q2 2023 191 192 191
q3 10527 1156 1170 1156
q4 10294 785 855 785
q5 7595 2731 2735 2731
q6 222 133 134 133
q7 961 596 596 596
q8 9220 2078 2108 2078
q9 8715 6610 6581 6581
q10 8896 3793 3816 3793
q11 460 235 233 233
q12 390 229 228 228
q13 17780 2967 2995 2967
q14 280 238 239 238
q15 517 477 465 465
q16 510 384 388 384
q17 980 651 659 651
q18 8150 7377 7396 7377
q19 6215 1367 1405 1367
q20 688 324 340 324
q21 4956 3193 3928 3193
q22 355 286 278 278
Total cold run time: 118569 ms
Total hot run time: 40059 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4402 4246 4262 4246
q2 409 292 280 280
q3 3144 2967 2923 2923
q4 2045 1765 1701 1701
q5 5566 5475 5549 5475
q6 233 133 132 132
q7 2260 1809 1863 1809
q8 3315 3456 3419 3419
q9 8750 8971 8737 8737
q10 4128 3906 3915 3906
q11 588 494 513 494
q12 830 652 627 627
q13 17178 3185 3182 3182
q14 323 286 291 286
q15 540 478 478 478
q16 488 446 432 432
q17 1808 1548 1501 1501
q18 8205 7940 7859 7859
q19 1749 1539 1489 1489
q20 2176 1862 1849 1849
q21 5200 4761 5043 4761
q22 587 484 494 484
Total cold run time: 73924 ms
Total hot run time: 56070 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon merged PR #38236:
URL: https://github.com/apache/doris/pull/38236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2245005515
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2245864114
<details>
<summary>TPC-DS: <b>Total hot run time: 174093 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 09c384cb98d383ac54b72031a518b0cdf572fc12, data reload: false
query1 907 368 368 368
query2 6330 1903 1789 1789
query3 6639 207 221 207
query4 28310 17874 17424 17424
query5 3569 496 490 490
query6 284 181 166 166
query7 4583 288 291 288
query8 246 197 186 186
query9 8628 2461 2407 2407
query10 423 283 267 267
query11 11018 10154 10072 10072
query12 113 85 81 81
query13 1650 369 359 359
query14 10401 7815 7636 7636
query15 218 169 165 165
query16 7648 528 466 466
query17 1128 533 534 533
query18 1898 272 272 272
query19 193 155 149 149
query20 91 83 81 81
query21 210 127 124 124
query22 4478 4234 4072 4072
query23 34145 33534 33593 33534
query24 11303 2942 2940 2940
query25 605 386 373 373
query26 711 151 147 147
query27 2278 276 279 276
query28 6402 2108 2092 2092
query29 882 618 643 618
query30 249 160 154 154
query31 975 776 777 776
query32 95 54 57 54
query33 759 356 340 340
query34 952 489 505 489
query35 929 765 779 765
query36 1134 958 948 948
query37 149 88 81 81
query38 2987 2914 2850 2850
query39 903 863 862 862
query40 205 126 121 121
query41 48 46 43 43
query42 106 102 103 102
query43 500 471 432 432
query44 1197 731 731 731
query45 195 162 162 162
query46 1083 752 708 708
query47 1869 1762 1764 1762
query48 382 289 289 289
query49 827 406 411 406
query50 777 383 394 383
query51 6848 6806 6578 6578
query52 107 92 91 91
query53 363 304 286 286
query54 882 451 440 440
query55 73 75 72 72
query56 298 272 296 272
query57 1155 1081 1085 1081
query58 246 258 248 248
query59 2844 2539 2562 2539
query60 303 274 275 274
query61 104 94 95 94
query62 806 643 632 632
query63 314 282 287 282
query64 9547 2225 1745 1745
query65 3166 3117 3133 3117
query66 768 325 331 325
query67 15512 15076 15110 15076
query68 4487 557 557 557
query69 461 347 342 342
query70 1168 1044 1154 1044
query71 376 281 269 269
query72 7164 5721 5556 5556
query73 751 340 324 324
query74 6146 5691 5765 5691
query75 3437 2707 2701 2701
query76 2195 896 860 860
query77 439 297 308 297
query78 9612 9025 8961 8961
query79 2728 522 527 522
query80 2304 464 467 464
query81 601 219 220 219
query82 777 144 133 133
query83 300 172 172 172
query84 265 91 89 89
query85 1715 319 363 319
query86 479 311 309 309
query87 3308 3119 3105 3105
query88 3823 2396 2382 2382
query89 473 382 379 379
query90 1701 201 193 193
query91 128 101 99 99
query92 60 50 49 49
query93 2113 519 517 517
query94 1088 305 299 299
query95 405 313 326 313
query96 590 285 271 271
query97 3238 2995 2999 2995
query98 230 198 206 198
query99 1761 1272 1277 1272
Total cold run time: 279271 ms
Total hot run time: 174093 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "lxr599 (via GitHub)" <gi...@apache.org>.
lxr599 commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2245763164
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon commented on code in PR #38236:
URL: https://github.com/apache/doris/pull/38236#discussion_r1689203039
##########
be/src/olap/rowset/segment_v2/segment_writer.cpp:
##########
@@ -258,8 +258,13 @@ Status SegmentWriter::_create_column_writer(uint32_t cid, const TabletColumn& co
if (column.is_row_store_column()) {
// smaller page size for row store column
- opts.data_page_size = _tablet_schema->row_store_page_size();
+ auto page_size = _tablet_schema->row_store_page_size();
+ opts.data_page_size = (page_size > 0) ? page_size : ([this]() {
+ _tablet_schema->set_row_store_page_size(segment_v2::ROW_STORE_PAGE_SIZE_DEFAULT_VALUE);
+ return segment_v2::ROW_STORE_PAGE_SIZE_DEFAULT_VALUE;
Review Comment:
don't set use default directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2247711973
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2244314998
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "lxr599 (via GitHub)" <gi...@apache.org>.
lxr599 commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2245069387
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2245186351
<details>
<summary>TPC-H: <b>Total hot run time: 39846 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit cb7548ef242a850ef4931c0b9a152e41dc087614, data reload: false
------ Round 1 ----------------------------------
q1 18368 8964 4263 4263
q2 2023 192 193 192
q3 10556 1177 1014 1014
q4 10327 851 810 810
q5 7635 2704 2690 2690
q6 224 145 144 144
q7 956 605 604 604
q8 9211 2112 2082 2082
q9 8670 6528 6549 6528
q10 8624 3761 3786 3761
q11 459 236 238 236
q12 394 234 227 227
q13 17761 2969 2984 2969
q14 267 238 244 238
q15 523 476 491 476
q16 476 376 381 376
q17 983 664 796 664
q18 8135 7532 7540 7532
q19 6467 1322 1336 1322
q20 680 331 319 319
q21 4903 3112 3435 3112
q22 356 290 287 287
Total cold run time: 117998 ms
Total hot run time: 39846 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4376 4229 4236 4229
q2 383 271 287 271
q3 3173 2957 2848 2848
q4 2047 1780 1661 1661
q5 5573 5492 5568 5492
q6 224 145 140 140
q7 2242 1829 1885 1829
q8 3304 3447 3403 3403
q9 8814 8985 8807 8807
q10 3970 3802 3956 3802
q11 601 495 507 495
q12 823 639 654 639
q13 16144 3180 3214 3180
q14 317 289 280 280
q15 547 486 475 475
q16 479 457 427 427
q17 1792 1522 1532 1522
q18 8166 8037 7853 7853
q19 1718 1635 1540 1540
q20 2865 1896 1869 1869
q21 5081 4672 5006 4672
q22 572 513 513 513
Total cold run time: 73211 ms
Total hot run time: 55947 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2247510729
<details>
<summary>TPC-DS: <b>Total hot run time: 174307 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 297dc779c2e1a2e002e0041c33a09a620fb9e692, data reload: false
query1 917 382 377 377
query2 6423 1937 1821 1821
query3 6640 209 216 209
query4 28374 17681 17390 17390
query5 3642 487 495 487
query6 281 177 171 171
query7 4611 295 290 290
query8 258 196 194 194
query9 8373 2405 2404 2404
query10 438 306 276 276
query11 11325 9979 10111 9979
query12 117 91 90 90
query13 1651 380 370 370
query14 10422 7984 7540 7540
query15 214 157 168 157
query16 7887 493 473 473
query17 1586 544 520 520
query18 2015 271 277 271
query19 193 147 151 147
query20 91 83 81 81
query21 198 123 129 123
query22 4338 4033 4105 4033
query23 34233 33657 33632 33632
query24 11057 2898 2889 2889
query25 620 408 401 401
query26 1223 161 153 153
query27 2409 286 280 280
query28 7197 2071 2049 2049
query29 881 651 606 606
query30 251 152 162 152
query31 952 747 767 747
query32 98 53 54 53
query33 761 330 338 330
query34 927 507 504 504
query35 832 774 761 761
query36 1133 990 981 981
query37 160 90 81 81
query38 2982 2922 2862 2862
query39 871 863 836 836
query40 200 122 118 118
query41 45 44 46 44
query42 120 96 96 96
query43 495 464 464 464
query44 1204 727 720 720
query45 206 175 175 175
query46 1088 731 753 731
query47 1837 1799 1778 1778
query48 374 290 294 290
query49 842 399 410 399
query50 774 391 399 391
query51 6779 6712 6721 6712
query52 106 96 89 89
query53 351 294 282 282
query54 918 453 451 451
query55 77 77 74 74
query56 302 269 284 269
query57 1137 1058 1042 1042
query58 246 247 269 247
query59 2752 2542 2562 2542
query60 309 268 269 268
query61 97 95 93 93
query62 821 625 659 625
query63 325 288 283 283
query64 9430 2257 1723 1723
query65 3162 3099 3100 3099
query66 747 328 337 328
query67 15397 14866 14882 14866
query68 4457 537 557 537
query69 463 341 339 339
query70 1134 1137 1169 1137
query71 422 279 285 279
query72 7106 6438 5733 5733
query73 752 328 330 328
query74 6098 5740 5752 5740
query75 3430 2699 2715 2699
query76 2717 927 936 927
query77 419 298 304 298
query78 9821 9141 9166 9141
query79 2488 532 523 523
query80 2186 471 471 471
query81 607 224 223 223
query82 996 140 136 136
query83 304 164 228 164
query84 264 87 95 87
query85 1204 310 298 298
query86 462 286 333 286
query87 3262 3130 3092 3092
query88 3385 2363 2366 2363
query89 489 385 378 378
query90 1735 196 193 193
query91 137 104 102 102
query92 67 51 49 49
query93 1909 522 519 519
query94 1101 305 288 288
query95 411 321 315 315
query96 590 271 274 271
query97 3196 3023 3098 3023
query98 225 198 198 198
query99 1568 1251 1274 1251
Total cold run time: 280127 ms
Total hot run time: 174307 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2247711920
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2245766324
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2245840530
<details>
<summary>TPC-H: <b>Total hot run time: 40371 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 09c384cb98d383ac54b72031a518b0cdf572fc12, data reload: false
------ Round 1 ----------------------------------
q1 17578 4432 4345 4345
q2 2026 198 187 187
q3 10451 1219 1077 1077
q4 10187 814 866 814
q5 7676 2835 2822 2822
q6 225 141 140 140
q7 979 597 599 597
q8 9224 2099 2081 2081
q9 8863 6602 6576 6576
q10 8755 3871 3820 3820
q11 452 242 231 231
q12 410 230 226 226
q13 17776 2989 3012 2989
q14 285 235 249 235
q15 534 491 494 491
q16 483 377 378 377
q17 972 658 690 658
q18 8364 7585 7535 7535
q19 9042 1409 1432 1409
q20 721 325 336 325
q21 4942 3150 3413 3150
q22 367 295 286 286
Total cold run time: 120312 ms
Total hot run time: 40371 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4453 4293 4275 4275
q2 370 274 261 261
q3 3182 2945 2986 2945
q4 2028 1711 1808 1711
q5 5577 5578 5537 5537
q6 237 147 141 141
q7 2284 1882 1836 1836
q8 3301 3452 3454 3452
q9 8859 8977 8820 8820
q10 4075 3743 3926 3743
q11 585 526 523 523
q12 812 624 690 624
q13 16874 3190 3217 3190
q14 308 287 296 287
q15 547 481 479 479
q16 496 441 443 441
q17 1841 1522 1549 1522
q18 8319 8200 7948 7948
q19 1857 1571 1588 1571
q20 2991 1906 1889 1889
q21 9766 4800 5054 4800
q22 623 531 519 519
Total cold run time: 79385 ms
Total hot run time: 56514 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2247064646
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "lxr599 (via GitHub)" <gi...@apache.org>.
lxr599 commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2247139534
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2247333458
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "lxr599 (via GitHub)" <gi...@apache.org>.
lxr599 commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2246883040
run external
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2245213904
<details>
<summary>TPC-DS: <b>Total hot run time: 173689 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit cb7548ef242a850ef4931c0b9a152e41dc087614, data reload: false
query1 910 376 362 362
query2 6339 1930 1789 1789
query3 6669 205 213 205
query4 28400 17541 17383 17383
query5 3776 492 481 481
query6 259 186 161 161
query7 4586 285 286 285
query8 232 189 189 189
query9 8709 2436 2425 2425
query10 433 305 288 288
query11 11477 10210 10089 10089
query12 116 83 88 83
query13 1634 376 374 374
query14 10061 7583 7797 7583
query15 232 161 165 161
query16 7327 472 472 472
query17 1283 579 550 550
query18 1860 285 300 285
query19 199 160 159 159
query20 93 81 81 81
query21 214 128 127 127
query22 4529 4029 4012 4012
query23 33906 33776 33363 33363
query24 10994 2865 2938 2865
query25 613 416 406 406
query26 715 163 152 152
query27 2247 279 295 279
query28 6273 2109 2101 2101
query29 893 620 637 620
query30 246 154 155 154
query31 961 749 766 749
query32 95 55 55 55
query33 668 326 331 326
query34 894 502 495 495
query35 878 776 745 745
query36 1155 991 985 985
query37 139 80 83 80
query38 2969 2809 2792 2792
query39 914 814 841 814
query40 201 119 118 118
query41 44 45 44 44
query42 114 100 94 94
query43 488 459 453 453
query44 1075 724 725 724
query45 193 163 162 162
query46 1112 754 729 729
query47 1873 1735 1752 1735
query48 361 293 292 292
query49 850 397 400 397
query50 771 388 393 388
query51 6809 6754 6643 6643
query52 102 94 93 93
query53 362 287 279 279
query54 888 455 439 439
query55 73 76 71 71
query56 295 271 272 271
query57 1106 1057 1070 1057
query58 241 254 274 254
query59 2782 2767 2612 2612
query60 314 259 276 259
query61 97 91 91 91
query62 789 633 645 633
query63 314 286 282 282
query64 9165 2217 1700 1700
query65 3156 3158 3090 3090
query66 761 332 333 332
query67 15648 15087 15011 15011
query68 4508 548 543 543
query69 639 426 359 359
query70 1185 1138 1176 1138
query71 437 277 283 277
query72 8444 5725 5622 5622
query73 757 325 320 320
query74 6068 5621 5614 5614
query75 3462 2698 2694 2694
query76 2595 894 899 894
query77 656 314 289 289
query78 12688 9540 8937 8937
query79 8108 517 557 517
query80 1171 498 482 482
query81 594 217 229 217
query82 569 132 130 130
query83 327 167 171 167
query84 279 84 85 84
query85 682 313 290 290
query86 445 308 328 308
query87 3290 3068 3089 3068
query88 4595 2384 2369 2369
query89 525 390 382 382
query90 1972 193 192 192
query91 133 98 103 98
query92 62 51 51 51
query93 4556 533 527 527
query94 1226 297 341 297
query95 411 311 317 311
query96 607 282 271 271
query97 3179 3106 2993 2993
query98 220 205 197 197
query99 1677 1274 1273 1273
Total cold run time: 289949 ms
Total hot run time: 173689 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2245877165
<details>
<summary>ClickBench: <b>Total hot run time: 31.16 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 09c384cb98d383ac54b72031a518b0cdf572fc12, data reload: false
query1 0.04 0.04 0.04
query2 0.08 0.03 0.04
query3 0.23 0.05 0.06
query4 1.66 0.09 0.10
query5 0.49 0.48 0.49
query6 1.13 0.72 0.73
query7 0.01 0.01 0.01
query8 0.05 0.04 0.04
query9 0.56 0.48 0.49
query10 0.55 0.54 0.55
query11 0.14 0.11 0.12
query12 0.16 0.12 0.12
query13 0.60 0.59 0.59
query14 0.75 0.80 0.77
query15 0.85 0.82 0.81
query16 0.37 0.37 0.36
query17 1.05 0.99 1.03
query18 0.24 0.22 0.22
query19 1.91 1.71 1.80
query20 0.02 0.01 0.01
query21 15.41 0.78 0.66
query22 3.82 7.30 2.36
query23 18.30 1.36 1.28
query24 2.09 0.23 0.22
query25 0.16 0.09 0.09
query26 0.29 0.21 0.21
query27 0.45 0.24 0.24
query28 13.28 1.02 0.99
query29 12.64 3.31 3.34
query30 0.24 0.06 0.06
query31 2.88 0.41 0.39
query32 3.25 0.46 0.48
query33 2.88 2.96 2.88
query34 17.04 4.37 4.38
query35 4.45 4.44 4.44
query36 0.65 0.47 0.46
query37 0.19 0.17 0.15
query38 0.15 0.15 0.15
query39 0.04 0.03 0.04
query40 0.16 0.12 0.12
query41 0.09 0.05 0.04
query42 0.05 0.05 0.04
query43 0.05 0.04 0.04
Total cold run time: 109.45 s
Total hot run time: 31.16 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "lxr599 (via GitHub)" <gi...@apache.org>.
lxr599 commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2247057552
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2247465523
<details>
<summary>TPC-H: <b>Total hot run time: 39831 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 297dc779c2e1a2e002e0041c33a09a620fb9e692, data reload: false
------ Round 1 ----------------------------------
q1 17661 4543 4268 4268
q2 2026 193 184 184
q3 10519 1167 1148 1148
q4 10248 794 847 794
q5 7529 2707 2648 2648
q6 221 142 141 141
q7 958 602 598 598
q8 9219 2056 2045 2045
q9 8729 6516 6549 6516
q10 8709 3825 3764 3764
q11 475 233 240 233
q12 389 231 232 231
q13 17777 2987 2988 2987
q14 283 230 235 230
q15 518 502 479 479
q16 499 390 385 385
q17 958 707 750 707
q18 8204 7350 7314 7314
q19 8193 1409 1366 1366
q20 661 324 332 324
q21 5009 3189 3269 3189
q22 355 280 286 280
Total cold run time: 119140 ms
Total hot run time: 39831 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4397 4264 4204 4204
q2 364 264 260 260
q3 3021 2890 2979 2890
q4 1943 1699 1713 1699
q5 5532 5550 5444 5444
q6 220 137 136 136
q7 2286 1899 1879 1879
q8 3295 3433 3399 3399
q9 8828 8898 8792 8792
q10 4165 3676 3863 3676
q11 618 523 508 508
q12 803 666 636 636
q13 17191 3162 3226 3162
q14 316 294 287 287
q15 531 482 496 482
q16 482 467 440 440
q17 1795 1488 1494 1488
q18 8104 7953 7757 7757
q19 1763 1564 1521 1521
q20 3094 1889 1874 1874
q21 5101 4765 4746 4746
q22 678 537 489 489
Total cold run time: 74527 ms
Total hot run time: 55769 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "lxr599 (via GitHub)" <gi...@apache.org>.
lxr599 commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2246700146
run external
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Row store) get the correct value of `row_store_page_size` after FE restarts [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38236:
URL: https://github.com/apache/doris/pull/38236#issuecomment-2247175447
<details>
<summary>TPC-DS: <b>Total hot run time: 174056 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 26e18ac623c12ffa189e17ac6897901ce8faa0c0, data reload: false
query1 908 368 378 368
query2 6432 1963 1848 1848
query3 6641 205 215 205
query4 26767 17694 17447 17447
query5 3811 491 503 491
query6 264 176 169 169
query7 4594 287 277 277
query8 227 190 184 184
query9 8534 2400 2390 2390
query10 432 318 280 280
query11 11798 10086 10112 10086
query12 111 81 80 80
query13 1635 362 357 357
query14 9445 7542 7698 7542
query15 217 175 173 173
query16 7738 499 473 473
query17 1364 538 535 535
query18 1907 276 272 272
query19 199 151 155 151
query20 92 86 82 82
query21 211 127 128 127
query22 4499 4310 3998 3998
query23 34172 33622 33669 33622
query24 10877 2938 2872 2872
query25 605 403 398 398
query26 705 149 148 148
query27 2252 276 289 276
query28 6193 2083 2055 2055
query29 867 634 633 633
query30 268 155 153 153
query31 986 779 770 770
query32 91 53 62 53
query33 640 356 347 347
query34 920 497 515 497
query35 865 733 763 733
query36 1141 978 948 948
query37 137 81 84 81
query38 2952 2830 2752 2752
query39 877 813 831 813
query40 200 121 117 117
query41 46 43 45 43
query42 112 99 97 97
query43 501 470 463 463
query44 1112 722 723 722
query45 190 159 160 159
query46 1101 728 756 728
query47 1844 1796 1798 1796
query48 353 291 296 291
query49 856 405 436 405
query50 772 381 389 381
query51 6776 6678 6763 6678
query52 98 95 91 91
query53 358 289 285 285
query54 861 456 445 445
query55 76 74 76 74
query56 285 265 268 265
query57 1146 1044 1044 1044
query58 237 252 273 252
query59 2938 2670 2559 2559
query60 322 273 265 265
query61 98 95 95 95
query62 798 640 651 640
query63 321 285 287 285
query64 9249 2324 1785 1785
query65 3167 3107 3109 3107
query66 740 321 319 319
query67 15583 15091 14853 14853
query68 4622 549 539 539
query69 730 426 349 349
query70 1154 1158 1061 1061
query71 411 278 276 276
query72 7692 5696 5484 5484
query73 775 342 333 333
query74 6432 6003 5721 5721
query75 3448 2693 2716 2693
query76 2684 953 933 933
query77 636 312 311 311
query78 9653 9202 10144 9202
query79 2993 517 536 517
query80 1360 464 467 464
query81 583 217 218 217
query82 736 137 132 132
query83 332 164 168 164
query84 271 86 84 84
query85 1666 321 300 300
query86 473 325 321 321
query87 3268 3106 3117 3106
query88 4060 2377 2385 2377
query89 472 395 382 382
query90 1729 193 196 193
query91 132 102 101 101
query92 58 48 49 48
query93 2387 512 519 512
query94 1132 278 304 278
query95 416 317 315 315
query96 600 274 276 274
query97 3170 3024 3002 3002
query98 230 199 205 199
query99 1637 1238 1270 1238
Total cold run time: 278456 ms
Total hot run time: 174056 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org