You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by NamanRastogi <gi...@git.apache.org> on 2019/01/03 09:43:43 UTC

[GitHub] carbondata pull request #3014: [CARBONDATA-3201] Added load level SORT_SCOPE

Github user NamanRastogi commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3014#discussion_r244947621
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala ---
    @@ -191,10 +191,17 @@ case class CarbonLoadDataCommand(
         optionsFinal
           .put("complex_delimiter_level_4",
             ComplexDelimitersEnum.COMPLEX_DELIMITERS_LEVEL_4.value())
    -    optionsFinal.put("sort_scope", tableProperties.asScala.getOrElse("sort_scope",
    -      carbonProperty.getProperty(CarbonLoadOptionConstants.CARBON_OPTIONS_SORT_SCOPE,
    -        carbonProperty.getProperty(CarbonCommonConstants.LOAD_SORT_SCOPE,
    -          CarbonCommonConstants.LOAD_SORT_SCOPE_DEFAULT))))
    +    optionsFinal.put(
    +      "sort_scope",
    +      options.getOrElse(
    +        "sort_scope",
    +        tableProperties.asScala.getOrElse(
    +          "sort_scope",
    +          carbonProperty.getProperty(
    +            CarbonLoadOptionConstants.CARBON_OPTIONS_SORT_SCOPE,
    +            carbonProperty.getProperty(
    +              CarbonCommonConstants.LOAD_SORT_SCOPE,
    +              CarbonCommonConstants.LOAD_SORT_SCOPE_DEFAULT)))))
    --- End diff --
    
    No need to handle for SDK.
    Done for PreAgg.


---