You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/06/09 00:14:13 UTC

[kudu-CR] [security-faults-itest] update expected error message

Alexey Serbin has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7128

Change subject: [security-faults-itest] update expected error message
......................................................................

[security-faults-itest] update expected error message

For some combination of timings in the KdcRestartsInTheMiddle scenario,
GSSAPI emits error not about expired context, but about expired
credentials.  This is legit, so we need to update the expected message
pattern correspondingly.

The example of test's output for such case can be found at
http://dist-test.cloudera.org/job?job_id=jenkins-slave.1496962083.13897

Change-Id: I9aab8f04e7c40d11ed7b786a01f35e6ef431598f
---
M src/kudu/integration-tests/security-faults-itest.cc
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/7128/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7128
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9aab8f04e7c40d11ed7b786a01f35e6ef431598f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [security-faults-itest] update expected error message

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: [security-faults-itest] update expected error message
......................................................................


Patch Set 1: Verified+1

Some unrelated failures: most of them due to timeouts in ASAN configuration.  It seems there were run in parallel with multiple others or at inferior machines.

-- 
To view, visit http://gerrit.cloudera.org:8080/7128
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9aab8f04e7c40d11ed7b786a01f35e6ef431598f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] [security-faults-itest] update expected error message

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: [security-faults-itest] update expected error message
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7128
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9aab8f04e7c40d11ed7b786a01f35e6ef431598f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] [security-faults-itest] update expected error message

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.

Change subject: [security-faults-itest] update expected error message
......................................................................


[security-faults-itest] update expected error message

For some combination of timings in the KdcRestartsInTheMiddle scenario,
GSSAPI emits error not about expired context, but about expired
credentials.  This is legit, so we need to update the expected message
pattern correspondingly.

The example of test's output for such case can be found at
http://dist-test.cloudera.org/job?job_id=jenkins-slave.1496962083.13897

Change-Id: I9aab8f04e7c40d11ed7b786a01f35e6ef431598f
Reviewed-on: http://gerrit.cloudera.org:8080/7128
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/integration-tests/security-faults-itest.cc
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Dan Burkert: Looks good to me, approved
  Alexey Serbin: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7128
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9aab8f04e7c40d11ed7b786a01f35e6ef431598f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>