You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Karl Heinz Marbaise <kh...@gmx.de> on 2017/07/28 20:03:15 UTC
MNG-6123 for Maven 3.5.1
Hi,
I would like to integrate MNG-6123[1] into Maven 3.5.1 (master)..which
needs a small change to one of the integration tests[2]
The IT's are fine see[3]
Are any objections?
If there are no objections I would like to merge to master on tuesday...
Kind regards
Karl Heinz Marbaise
[1]: https://issues.apache.org/jira/browse/MNG-6123
[2]:
https://git-wip-us.apache.org/repos/asf?p=maven-integration-testing.git;a=commit;h=3a1f095ec845c94b8e21ea28e4ffe69a01c29f4b
[3]:
https://builds.apache.org/view/M-R/view/Maven/job/maven-3.x-jenkinsfile/job/MNG-6123-detect-self-references/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: MNG-6123 for Maven 3.5.1
Posted by Robert Scholte <rf...@apache.org>.
Hi Karl Heinz,
comparing the key is often good enough, but I wonder if we should include
the packaging type as well.
On the other hand, if there's another module with the same GA, then you'll
have an issue as well.
Would be good to add a comment here that says ignoring type and
classifiers is intended and seems valid here for the reason mentioned
above.
thanks,
Robert
On Sun, 30 Jul 2017 13:25:12 +0200, Karl Heinz Marbaise
<kh...@gmx.de> wrote:
> Hi Robert,
>
> On 30/07/17 12:56, Robert Scholte wrote:
>> I'm missing the code change, I see only IT changes.
>
> Sure...missed the link:
>
> https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=65bb3030193db6b5c0d55c0f00f94f2dc77b801d
>
> On the branch:
> https://git-wip-us.apache.org/repos/asf?p=maven.git;a=shortlog;h=refs/heads/MNG-6123-detect-self-references
>
>
> Kind regards
> Karl Heinz Marbaise
>> On Fri, 28 Jul 2017 22:03:15 +0200, Karl Heinz Marbaise
>> <kh...@gmx.de> wrote:
>>
>>> Hi,
>>>
>>> I would like to integrate MNG-6123[1] into Maven 3.5.1 (master)..which
>>> needs a small change to one of the integration tests[2]
>>>
>>> The IT's are fine see[3]
>>>
>>> Are any objections?
>>>
>>> If there are no objections I would like to merge to master on
>>> tuesday...
>>>
>>> Kind regards
>>> Karl Heinz Marbaise
>>>
>>>
>>> [1]: https://issues.apache.org/jira/browse/MNG-6123
>>> [2]:
>>> https://git-wip-us.apache.org/repos/asf?p=maven-integration-testing.git;a=commit;h=3a1f095ec845c94b8e21ea28e4ffe69a01c29f4b
>>> [3]:
>>> https://builds.apache.org/view/M-R/view/Maven/job/maven-3.x-jenkinsfile/job/MNG-6123-detect-self-references/
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
>
> Mit freundlichem Gruß
> Karl-Heinz Marbaise
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: MNG-6123 for Maven 3.5.1
Posted by Karl Heinz Marbaise <kh...@gmx.de>.
Hi Robert,
On 30/07/17 12:56, Robert Scholte wrote:
> I'm missing the code change, I see only IT changes.
Sure...missed the link:
https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=65bb3030193db6b5c0d55c0f00f94f2dc77b801d
On the branch:
https://git-wip-us.apache.org/repos/asf?p=maven.git;a=shortlog;h=refs/heads/MNG-6123-detect-self-references
Kind regards
Karl Heinz Marbaise
>
> On Fri, 28 Jul 2017 22:03:15 +0200, Karl Heinz Marbaise
> <kh...@gmx.de> wrote:
>
>> Hi,
>>
>> I would like to integrate MNG-6123[1] into Maven 3.5.1 (master)..which
>> needs a small change to one of the integration tests[2]
>>
>> The IT's are fine see[3]
>>
>> Are any objections?
>>
>> If there are no objections I would like to merge to master on tuesday...
>>
>> Kind regards
>> Karl Heinz Marbaise
>>
>>
>> [1]: https://issues.apache.org/jira/browse/MNG-6123
>> [2]:
>> https://git-wip-us.apache.org/repos/asf?p=maven-integration-testing.git;a=commit;h=3a1f095ec845c94b8e21ea28e4ffe69a01c29f4b
>>
>> [3]:
>> https://builds.apache.org/view/M-R/view/Maven/job/maven-3.x-jenkinsfile/job/MNG-6123-detect-self-references/
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Mit freundlichem Gruß
Karl-Heinz Marbaise
--
SoftwareEntwicklung Beratung Schulung Tel.: +49 (0) 2405 / 415 893
Dipl.Ing.(FH) Karl-Heinz Marbaise USt.IdNr: DE191347579
Hauptstrasse 177
52146 Würselen http://www.soebes.de
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: MNG-6123 for Maven 3.5.1
Posted by Robert Scholte <rf...@apache.org>.
I'm missing the code change, I see only IT changes.
On Fri, 28 Jul 2017 22:03:15 +0200, Karl Heinz Marbaise
<kh...@gmx.de> wrote:
> Hi,
>
> I would like to integrate MNG-6123[1] into Maven 3.5.1 (master)..which
> needs a small change to one of the integration tests[2]
>
> The IT's are fine see[3]
>
> Are any objections?
>
> If there are no objections I would like to merge to master on tuesday...
>
> Kind regards
> Karl Heinz Marbaise
>
>
> [1]: https://issues.apache.org/jira/browse/MNG-6123
> [2]:
> https://git-wip-us.apache.org/repos/asf?p=maven-integration-testing.git;a=commit;h=3a1f095ec845c94b8e21ea28e4ffe69a01c29f4b
> [3]:
> https://builds.apache.org/view/M-R/view/Maven/job/maven-3.x-jenkinsfile/job/MNG-6123-detect-self-references/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org