[jira] [Commented] (CXF-5970) review org.apache.cxf.jaxrs.provider.ProviderFactory.Message*ReaderComparator

["Sergey Beryozkin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CXF-5970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14109658#comment-14109658 ] 

Sergey Beryozkin commented on CXF-5970:
---------------------------------------

Hi Romain,
Can you give me an example please of where the factory loses the expected priority ? Ultimately the runtime must guarantee the providers are sorted correctly,

Thanks, Sergey

> review org.apache.cxf.jaxrs.provider.ProviderFactory.Message*ReaderComparator
> -----------------------------------------------------------------------------
>
>                 Key: CXF-5970
>                 URL: https://issues.apache.org/jira/browse/CXF-5970
>             Project: CXF
>          Issue Type: Bug
>            Reporter: Romain Manni-Bucau
>
> Actually the task can be rephrase saying rework org.apache.cxf.jaxrs.provider.ProviderFactory#*Comparators
> Current implementations don't seem to have an absolute order which means sorting is not as deterministic as it should be under java >= 7.
> Other point is as a user you set a List of providers (you probably already sorted if important) so you want to ensure *your* order is respected at runtime (ie org.apache.cxf.jaxrs.provider.ProviderFactory#message[Readers|Writers] respect it).
> If you think this sorting is important maybe introducing in org.apache.cxf.jaxrs.AbstractJAXRSFactoryBean and org.apache.cxf.jaxrs.provider.ProviderFactory a boolean sortProviders can be enough to prevent calling sortXXX().



--
This message was sent by Atlassian JIRA
(v6.2#6252)