[GitHub] [hudi] leesf commented on a change in pull request #1810: [HUDI-875] Abstract hudi-sync-common, and support hudi-hive-sync

[GitBox <gi...@apache.org>]

leesf commented on a change in pull request #1810:
URL: https://github.com/apache/hudi/pull/1810#discussion_r452824160



##########
File path: hudi-sync/hudi-hive-sync/pom.xml
##########
@@ -43,6 +45,11 @@
       <artifactId>hudi-hadoop-mr</artifactId>
       <version>${project.version}</version>
     </dependency>
+    <dependency>
+      <groupId>org.apache.hudi</groupId>
+      <artifactId>hudi-sync-common</artifactId>

Review comment:
       hi, I am incline to put hudi-sync-common, hudi-sync-dla and hudi-sync-hive modules under hudi-sync, it will keep the structure same as the refactored hudi-client which is consisted of hudi-client-common, hudi-client-spark, hudi-client-flink, hudi-client-java modules.
   
   ```
   hudi-sync
   |--hudi-sync-common
   |--hudi-sync-hive
   |--hive-sync-dla
   
   
   hudi-client
   |--hudi-client-common
   |--hudi-client-java
   |--hudi-client-spark
   |--hudi-client-flink
   ```
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org