[jira] [Commented] (QPID-3170) Deleting/restoring dynamic federation routes, brokers will not relearn remote bindings that match local keys.

["jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/QPID-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13015350#comment-13015350 ] 

jiraposter@reviews.apache.org commented on QPID-3170:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/533/#review376
-----------------------------------------------------------

Ship it!


The dynamically-federated exchange code could use some cleanup at some point or some clearer comments around it as it is quite hard to follow and the method/variable names have very little intuitive meaning. However this is a good change and the extra tests are greatly needed.

- Gordon


On 2011-03-29 14:38:42, Kenneth Giusti wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/533/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-03-29 14:38:42)
bq.  
bq.  
bq.  Review request for Gordon Sim, michael goulish and Ted Ross.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Potential bugfix for QPID-3170 (BZ681715).  Changed the delOrigin() interface to require the remote origin when deleting a route (or a queue).  Also made the interface behave correctly if an origin is deleted twice.  Added some tests.
bq.  
bq.  
bq.  This addresses bug QPID-3170.
bq.      https://issues.apache.org/jira/browse/QPID-3170
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    /trunk/qpid/cpp/src/qpid/broker/DirectExchange.cpp 1086404 
bq.    /trunk/qpid/cpp/src/qpid/broker/Exchange.h 1086404 
bq.    /trunk/qpid/cpp/src/qpid/broker/FanOutExchange.cpp 1086404 
bq.    /trunk/qpid/cpp/src/qpid/broker/HeadersExchange.cpp 1086404 
bq.    /trunk/qpid/cpp/src/qpid/broker/TopicExchange.h 1086404 
bq.    /trunk/qpid/cpp/src/qpid/broker/TopicExchange.cpp 1086404 
bq.    /trunk/qpid/cpp/src/tests/federation.py 1086404 
bq.  
bq.  Diff: https://reviews.apache.org/r/533/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  make check & additional bug-specific test.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Kenneth
bq.  
bq.



> Deleting/restoring dynamic federation routes, brokers will not relearn remote bindings that match local keys.
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-3170
>                 URL: https://issues.apache.org/jira/browse/QPID-3170
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>    Affects Versions: 0.8
>            Reporter: Ken Giusti
>            Assignee: Ken Giusti
>             Fix For: 0.10
>
>         Attachments: QPID-3170-2.patch, fail.sh, pass.sh
>
>
> Should a dynamic federation route be deleted, then restored, remote bindings that use the same key as local bindings are not restored.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org