You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Stan Silvert (JIRA)" <de...@myfaces.apache.org> on 2007/09/04 15:46:44 UTC
[jira] Created: (JSR301-1) Bad init param causes infinite loop
Bad init param causes infinite loop
-----------------------------------
Key: JSR301-1
URL: https://issues.apache.org/jira/browse/JSR301-1
Project: MyFaces Portlet Bridge
Issue Type: Bug
Components: General
Affects Versions: 1.0.0-SNAPSHOT
Reporter: Stan Silvert
If the default view for a portlet mode is not specified, you will get an infinite loop.
In GenericFacesPortlet, the doDispatchInternal() method will call super.doDispatch(request, response) if a default view is not specified in portlet.xml. GenericPortlet.doDispatch() calls back into GenericFacesPortlet, creating an infinite loop.
It should throw a PortletException instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PORTLETBRIDGE-3) Bad init param causes infinite
loop
Posted by "Scott O'Bryan (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/PORTLETBRIDGE-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott O'Bryan updated PORTLETBRIDGE-3:
--------------------------------------
Resolution: Fixed
Assignee: Scott O'Bryan
Status: Resolved (was: Patch Available)
Patch applied to trunk. Thanks to Michael Freedman.
> Bad init param causes infinite loop
> -----------------------------------
>
> Key: PORTLETBRIDGE-3
> URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-3
> Project: MyFaces Portlet Bridge
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0.0-SNAPSHOT
> Reporter: Stan Silvert
> Assignee: Scott O'Bryan
> Fix For: 1.0.0-SNAPSHOT
>
> Attachments: bridge_patch_1121.patch
>
>
> If the default view for a portlet mode is not specified, you will get an infinite loop.
> In GenericFacesPortlet, the doDispatchInternal() method will call super.doDispatch(request, response) if a default view is not specified in portlet.xml. GenericPortlet.doDispatch() calls back into GenericFacesPortlet, creating an infinite loop.
> It should throw a PortletException instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PORTLETBRIDGE-3) Bad init param causes infinite
loop
Posted by "Michael Freedman (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/PORTLETBRIDGE-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Freedman updated PORTLETBRIDGE-3:
-----------------------------------------
Status: Patch Available (was: Open)
> Bad init param causes infinite loop
> -----------------------------------
>
> Key: PORTLETBRIDGE-3
> URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-3
> Project: MyFaces Portlet Bridge
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0.0-SNAPSHOT
> Reporter: Stan Silvert
> Fix For: 1.0.0-SNAPSHOT
>
>
> If the default view for a portlet mode is not specified, you will get an infinite loop.
> In GenericFacesPortlet, the doDispatchInternal() method will call super.doDispatch(request, response) if a default view is not specified in portlet.xml. GenericPortlet.doDispatch() calls back into GenericFacesPortlet, creating an infinite loop.
> It should throw a PortletException instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PORTLETBRIDGE-3) Bad init param causes infinite
loop
Posted by "Scott O'Bryan (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/PORTLETBRIDGE-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544622 ]
Scott O'Bryan commented on PORTLETBRIDGE-3:
-------------------------------------------
Hey Mike, I looked at this patch and your fix for PortletBridge-14 concerns me as it seems you'll be trading the "IllegalStateException" for a "ClassCastException" when running a render request.
If I understand this correctly, the intention of this interim solution is to make this a noop when we are not in an action request so I'm going to modify your patch with that understanding. Please review my changes to PortletExternalContextImpl.setCharacterEncoding and let me know if this is what you intended.
> Bad init param causes infinite loop
> -----------------------------------
>
> Key: PORTLETBRIDGE-3
> URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-3
> Project: MyFaces Portlet Bridge
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0.0-SNAPSHOT
> Reporter: Stan Silvert
> Fix For: 1.0.0-SNAPSHOT
>
> Attachments: bridge_patch_1121.patch
>
>
> If the default view for a portlet mode is not specified, you will get an infinite loop.
> In GenericFacesPortlet, the doDispatchInternal() method will call super.doDispatch(request, response) if a default view is not specified in portlet.xml. GenericPortlet.doDispatch() calls back into GenericFacesPortlet, creating an infinite loop.
> It should throw a PortletException instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PORTLETBRIDGE-3) Bad init param causes infinite
loop
Posted by "Michael Freedman (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/PORTLETBRIDGE-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545949 ]
Michael Freedman commented on PORTLETBRIDGE-3:
----------------------------------------------
Scott. Good catch. I must have been thinking that the delegation/cast was in an else clause -- brain lock I guess. I presume you fixed this before applying the patch, right?
> Bad init param causes infinite loop
> -----------------------------------
>
> Key: PORTLETBRIDGE-3
> URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-3
> Project: MyFaces Portlet Bridge
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0.0-SNAPSHOT
> Reporter: Stan Silvert
> Assignee: Scott O'Bryan
> Fix For: 1.0.0-SNAPSHOT
>
> Attachments: bridge_patch_1121.patch
>
>
> If the default view for a portlet mode is not specified, you will get an infinite loop.
> In GenericFacesPortlet, the doDispatchInternal() method will call super.doDispatch(request, response) if a default view is not specified in portlet.xml. GenericPortlet.doDispatch() calls back into GenericFacesPortlet, creating an infinite loop.
> It should throw a PortletException instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.