You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by bostko <gi...@git.apache.org> on 2015/05/01 02:13:18 UTC
[GitHub] incubator-brooklyn pull request: Revert the eager loading of the c...
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/622
Revert the eager loading of the catalog items
Currently loading the documentation of a catalog item is little slow. I think for the catalog items particularly, there is no reason for lazy loading the resource.
Loading via ajax also doesn't allow the browser to cache the js resource and it is reloaded each time when switching back and forth between index.html and catalog-item.html
The other change I made is to include the catalog items generation in the documentation build
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/incubator-brooklyn catalog-documentation-improvements
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/622.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #622
----
commit e68a8e4f29178e96f9a9de0a6f6464e831a17207
Author: Valentin Aitken <va...@cloudsoftcorp.com>
Date: 2015-05-01T00:03:22Z
Revert the eager loading of the catalog items
- Include the catalog items generation in the documentation build
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Revert the eager loading of the c...
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/622#discussion_r31411200
--- Diff: docs/_build/build.sh ---
@@ -179,9 +179,20 @@ function test_site() {
}
function make_jekyll() {
+ if [ -f ../usage/dist/target/brooklyn-dist/bin/brooklyn ]; then
+ ITEMS_JS=style/js/catalog/items.js
--- End diff --
Does `items.js` need to be checked in if it is generated by this function?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Revert the eager loading of the c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/622
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Revert the eager loading of the c...
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/622#issuecomment-126449051
@bostko Thanks. Will merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Revert the eager loading of the c...
Posted by bostko <gi...@git.apache.org>.
Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/622#discussion_r33459189
--- Diff: docs/_build/build.sh ---
@@ -179,9 +179,20 @@ function test_site() {
}
function make_jekyll() {
+ if [ -f ../usage/dist/target/brooklyn-dist/bin/brooklyn ]; then
+ ITEMS_JS=style/js/catalog/items.js
--- End diff --
Yes it needs to be putted in the project
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---