[GitHub] [airflow] o-nikolas commented on a diff in pull request #30992: Add options to KubernetesPodOperator

["o-nikolas (via GitHub)" <gi...@apache.org>]

o-nikolas commented on code in PR #30992:
URL: https://github.com/apache/airflow/pull/30992#discussion_r1185574456


##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -282,6 +282,9 @@ def __init__(
         security_context: dict | None = None,
         container_security_context: dict | None = None,
         dnspolicy: str | None = None,
+        dns_config: dict | None = None,

Review Comment:
   Kube has a type for this right?
   ```suggestion
           dns_config: V1PodDNSConfig | None = None,
   ```



##########
tests/providers/cncf/kubernetes/operators/test_pod.py:
##########
@@ -324,6 +324,41 @@ def test_find_pod_labels(self):
             "already_checked!=True,!airflow-worker"
         )
 
+    @patch(HOOK_CLASS, new=MagicMock)
+    def test_pod_additional_options(self):

Review Comment:
   Nit: something about this test name seems too generic, maybe:
   ```suggestion
       def test_pod_dns_options(self):
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org