You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/09/17 10:07:22 UTC
[GitHub] [apisix] bzp2010 opened a new pull request #5086: fix(gzip): schema typo
bzp2010 opened a new pull request #5086:
URL: https://github.com/apache/apisix/pull/5086
### What this PR does / why we need it:
fix #5085
#### _By the way, do we need to backport it to version 2.9?_
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [x] Have you modified the corresponding document?
* [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5086: fix(gzip): schema typo
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #5086:
URL: https://github.com/apache/apisix/pull/5086
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #5086: fix(gzip): schema typo
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #5086:
URL: https://github.com/apache/apisix/pull/5086#issuecomment-922153521
>
>
> Hi,
> I noticed that other CI build tests passed, and only `CI / build (ubuntu-18.04, linux_openresty)` failed. Does this have anything to do with my change?
Yes, please check the output of the CI log:
```
# Failed test 'TEST 19: schema check - response_body - response is expected (repeated req 0, req 0)'
# at /home/runner/work/apisix/apisix/test-nginx/lib/Test/Nginx/Socket.pm line 1589.
# @@ -1,6 +1,6 @@
# {"error_msg":"failed to check the configuration of plugin gzip err: property \"types\" validation failed: object matches none of the requireds"}
# {"error_msg":"failed to check the configuration of plugin gzip err: property \"min_length\" validation failed: expected 0 to be greater than 1"}
# -{"error_msg":"failed to check the configuration of plugin gzip err: property \"comp_level\" validation failed: expected 0 to be greater than 1"}
# +{"error_msg":"failed to check the configuration of plugin gzip err: property \"comp_level\" validation failed: expected 10 to be smaller than 9"}
# {"error_msg":"failed to check the configuration of plugin gzip err: property \"http_version\" validation failed: matches none of the enum values"}
# {"error_msg":"failed to check the configuration of plugin gzip err: property \"buffers\" validation failed: property \"number\" validation failed: expected 0 to be greater than 1"}
# {"error_msg":"failed to check the configuration of plugin gzip err: property \"vary\" validation failed: wrong type: expected boolean, got number"}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bzp2010 commented on pull request #5086: fix(gzip): schema typo
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on pull request #5086:
URL: https://github.com/apache/apisix/pull/5086#issuecomment-922157331
Thank you very much for pointing out that problem. It was modified during the adjustment sequence, but it was not completely modified correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5086: fix(gzip): schema typo
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #5086:
URL: https://github.com/apache/apisix/pull/5086#discussion_r710965087
##########
File path: t/plugin/gzip.t
##########
@@ -46,7 +46,57 @@ run_tests();
__DATA__
-=== TEST 1: sanity
Review comment:
Please add new test from the bottom
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bzp2010 commented on pull request #5086: fix(gzip): schema typo
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on pull request #5086:
URL: https://github.com/apache/apisix/pull/5086#issuecomment-922149248
Hi,
I noticed that other CI build tests passed, and only `CI / build (ubuntu-18.04, linux_openresty)` failed. Does this have anything to do with my change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bzp2010 commented on a change in pull request #5086: fix(gzip): schema typo
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on a change in pull request #5086:
URL: https://github.com/apache/apisix/pull/5086#discussion_r711019885
##########
File path: t/plugin/gzip.t
##########
@@ -46,7 +46,57 @@ run_tests();
__DATA__
-=== TEST 1: sanity
Review comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bzp2010 commented on pull request #5086: fix(gzip): schema typo
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on pull request #5086:
URL: https://github.com/apache/apisix/pull/5086#issuecomment-921682754
> Could you add a test in https://github.com/apache/apisix/blob/master/t/plugin/gzip.t like
>
> https://github.com/apache/apisix/blob/1a072f4271e74e27339823fec5817e1c2d42c719/t/plugin/real-ip.t#L49
>
> ?
Ok, I will add it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org