You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2020/06/11 03:18:37 UTC
[Bug 64514] New: classes missing from bootstrap.jar
https://bz.apache.org/bugzilla/show_bug.cgi?id=64514
Bug ID: 64514
Summary: classes missing from bootstrap.jar
Product: Tomcat 10
Version: unspecified
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P2
Component: Packaging
Assignee: dev@tomcat.apache.org
Reporter: raymond.auge@liferay.com
Target Milestone: ------
When performing a jdeps analysis on bootstrap.jar in master we can see that
there are two classes missing.
> tomcat]$ jdeps -v -cp output/build/bin/tomcat-juli.jar output/build/bin/bootstrap.jar | grep "not found"
> bootstrap.jar -> not found
> org.apache.catalina.startup.Bootstrap -> org.apache.catalina.Globals not found
> org.apache.catalina.startup.Tool -> org.apache.catalina.Globals not found
> org.apache.catalina.startup.Tool -> org.apache.tomcat.util.ExceptionUtils not found
The effective result of this is that when calculating either the OSGi or JPMS
metadata these packages want to be imported. Since several other classes are
cherry-picked into the jar it stands to reason that the assembly should be
logically complete as to never encounter any hard to diagnose errors.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 64514] classes missing from bootstrap.jar
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64514
rotty3000 <ra...@liferay.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Hardware|PC |All
OS|Linux |All
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 64514] classes missing from bootstrap.jar
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64514
--- Comment #2 from rotty3000 <ra...@liferay.com> ---
This issue was discussed on list and determined that if the missing parts being
small and benign enough to copy into bootstrap, that might be the best solution
as proposed by @markt:
> If we created o.a.c.startup.Constants, defined the constants required by
> the bootstrap classes there and then referenced those from o.a.c.Globals
> would that help?
It did!
> Is it Tool's use of ExceptionUtils that is causing that class to be
> needed? If so would making Bootstrap.handleThrowable() package private
> and using that instead help?
It does!
I've tested these changed and they solve the packaging issue for both OSGi and
JPMS.
PR update coming.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 64514] classes missing from bootstrap.jar
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64514
--- Comment #3 from rotty3000 <ra...@liferay.com> ---
The outcome is essentially that both in usage and now in terms of real java
dependencies, bootstrap has no dependencies outside of java.base and
tomcat-juli.jar
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 64514] classes missing from bootstrap.jar
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64514
--- Comment #1 from rotty3000 <ra...@liferay.com> ---
https://github.com/apache/tomcat/pull/296
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 64514] classes missing from bootstrap.jar
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64514
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #4 from Mark Thomas <ma...@apache.org> ---
Thanks for the PRs.
Fixed in:
- master for 10.0.0-M7 onwards
- 9.0.x for 9.0.37 onwards
- 8.5.x for 8.5.57 onwards
Note that I back-ported this to 8.5.x even though 8.5.x doesn't use bnd to keep
the code in sync for easier back-ports of future fixes.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org