You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/04 14:34:44 UTC

[GitHub] [spark] sarutak commented on a change in pull request #34484: [SPARK-37207][PySpark] Add isEmpty method for the Python DataFrame API

sarutak commented on a change in pull request #34484:
URL: https://github.com/apache/spark/pull/34484#discussion_r742896256



##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -473,6 +473,13 @@ def isStreaming(self) -> bool:
         """
         return self._jdf.isStreaming()
 
+    def isEmpty(self) -> bool:
+        """Returns ``True`` if this :class:`DataFrame` is empty.

Review comment:
       Could you add `Examples` section?
   Then, I think we don't need additional tests for `isEmpty` in `test_dataframe.py`. The doctet is enough.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org