[GitHub] [pulsar] lhotari commented on a change in pull request #9302: Add subscription backlog size info for topicstats.

[GitBox <gi...@apache.org>]

lhotari commented on a change in pull request #9302:
URL: https://github.com/apache/pulsar/pull/9302#discussion_r573097468



##########
File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java
##########
@@ -584,10 +589,15 @@ void run() throws PulsarAdminException {
             "--get-precise-backlog" }, description = "Set true to get precise backlog")
         private boolean getPreciseBacklog = false;
 
+        @Parameter(names = { "-sbs",
+                "--get-subscription-backlog-size" }, description = "Set true to get backlog size for each subscription"
+                + ", locking required.")
+        private boolean subscriptionBacklogSize = false;
+
         @Override
         void run() throws Exception {
             String topic = validateTopicName(params);
-            print(getTopics().getPartitionedStats(topic, perPartition, getPreciseBacklog));
+            print(topics.getPartitionedStats(topic, perPartition, getPreciseBacklog, subscriptionBacklogSize));

Review comment:
       @MarvinCai it seems that `getTopics()` was changed to `topics` here unintentionally. Would you mind fixing this? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org