You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Howard M. Lewis Ship (Created) (JIRA)" <ji...@apache.org> on 2011/09/28 00:06:45 UTC

[jira] [Created] (TAP5-1675) Tapestry 5.3 allows a subcomponent to defined a parameter with the same name as a base component

Tapestry 5.3 allows a subcomponent to defined a parameter with the same name as a base component
------------------------------------------------------------------------------------------------

                 Key: TAP5-1675
                 URL: https://issues.apache.org/jira/browse/TAP5-1675
             Project: Tapestry 5
          Issue Type: Bug
          Components: tapestry-core
    Affects Versions: 5.3
            Reporter: Howard M. Lewis Ship
            Priority: Critical


I believe you got a more reasonable error message in 5.2. In 5.3 you may get an error if both the fields have @Property, due to a name collision on the getter/setter method names. Instead, Tapestry should fail early explaining that both the component and (the identified base class) define the same parameter name.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (TAP5-1675) Tapestry 5.3 allows a subcomponent to define a parameter with the same name as a base component

Posted by "Howard M. Lewis Ship (Closed) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-1675.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 5.3
         Assignee: Howard M. Lewis Ship
    
> Tapestry 5.3 allows a subcomponent to define a parameter with the same name as a base component
> -----------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1675
>                 URL: https://issues.apache.org/jira/browse/TAP5-1675
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>            Priority: Critical
>             Fix For: 5.3
>
>
> I believe you got a more reasonable error message in 5.2. In 5.3 you may get an error if both the fields have @Property, due to a name collision on the getter/setter method names. Instead, Tapestry should fail early explaining that both the component and (the identified base class) define the same parameter name.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (TAP5-1675) Tapestry 5.3 allows a subcomponent to define a parameter with the same name as a base component

Posted by "Howard M. Lewis Ship (Closed) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-1675.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 5.3
         Assignee: Howard M. Lewis Ship
    
> Tapestry 5.3 allows a subcomponent to define a parameter with the same name as a base component
> -----------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1675
>                 URL: https://issues.apache.org/jira/browse/TAP5-1675
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>            Priority: Critical
>             Fix For: 5.3
>
>
> I believe you got a more reasonable error message in 5.2. In 5.3 you may get an error if both the fields have @Property, due to a name collision on the getter/setter method names. Instead, Tapestry should fail early explaining that both the component and (the identified base class) define the same parameter name.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (TAP5-1675) Tapestry 5.3 allows a subcomponent to define a parameter with the same name as a base component

Posted by "Howard M. Lewis Ship (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship updated TAP5-1675:
---------------------------------------

    Summary: Tapestry 5.3 allows a subcomponent to define a parameter with the same name as a base component  (was: Tapestry 5.3 allows a subcomponent to defined a parameter with the same name as a base component)
    
> Tapestry 5.3 allows a subcomponent to define a parameter with the same name as a base component
> -----------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1675
>                 URL: https://issues.apache.org/jira/browse/TAP5-1675
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Priority: Critical
>
> I believe you got a more reasonable error message in 5.2. In 5.3 you may get an error if both the fields have @Property, due to a name collision on the getter/setter method names. Instead, Tapestry should fail early explaining that both the component and (the identified base class) define the same parameter name.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (TAP5-1675) Tapestry 5.3 allows a subcomponent to define a parameter with the same name as a base component

Posted by "Howard M. Lewis Ship (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship updated TAP5-1675:
---------------------------------------

    Summary: Tapestry 5.3 allows a subcomponent to define a parameter with the same name as a base component  (was: Tapestry 5.3 allows a subcomponent to defined a parameter with the same name as a base component)
    
> Tapestry 5.3 allows a subcomponent to define a parameter with the same name as a base component
> -----------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1675
>                 URL: https://issues.apache.org/jira/browse/TAP5-1675
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Priority: Critical
>
> I believe you got a more reasonable error message in 5.2. In 5.3 you may get an error if both the fields have @Property, due to a name collision on the getter/setter method names. Instead, Tapestry should fail early explaining that both the component and (the identified base class) define the same parameter name.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TAP5-1675) Tapestry 5.3 allows a subcomponent to define a parameter with the same name as a base component

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116039#comment-13116039 ] 

Hudson commented on TAP5-1675:
------------------------------

Integrated in tapestry-trunk-freestyle #551 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/551/])
    TAP5-1675: Tapestry 5.3 allows a subcomponent to define a parameter with the same name as a base component

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176661
Files : 
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/model/ModelMessages.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/model/MutableComponentModelImpl.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/model/ParameterModelImpl.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/model/ComponentModel.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/model/ParameterModel.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/internal/model/ModelStrings.properties
* /tapestry/tapestry5/trunk/tapestry-core/src/test/app1/Index.tml
* /tapestry/tapestry5/trunk/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/ParameterTests.groovy
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/base/ParameterBaseClass.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/components/ParameterSubClass.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/ParameterConflictDemo.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/model/MutableComponentModelImplTest.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/integration/app1/pages/ParameterConflictDemo.tml

                
> Tapestry 5.3 allows a subcomponent to define a parameter with the same name as a base component
> -----------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1675
>                 URL: https://issues.apache.org/jira/browse/TAP5-1675
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>            Priority: Critical
>             Fix For: 5.3
>
>
> I believe you got a more reasonable error message in 5.2. In 5.3 you may get an error if both the fields have @Property, due to a name collision on the getter/setter method names. Instead, Tapestry should fail early explaining that both the component and (the identified base class) define the same parameter name.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TAP5-1675) Tapestry 5.3 allows a subcomponent to define a parameter with the same name as a base component

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116039#comment-13116039 ] 

Hudson commented on TAP5-1675:
------------------------------

Integrated in tapestry-trunk-freestyle #551 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/551/])
    TAP5-1675: Tapestry 5.3 allows a subcomponent to define a parameter with the same name as a base component

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176661
Files : 
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/model/ModelMessages.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/model/MutableComponentModelImpl.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/model/ParameterModelImpl.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/model/ComponentModel.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/model/ParameterModel.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/internal/model/ModelStrings.properties
* /tapestry/tapestry5/trunk/tapestry-core/src/test/app1/Index.tml
* /tapestry/tapestry5/trunk/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/ParameterTests.groovy
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/base/ParameterBaseClass.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/components/ParameterSubClass.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/ParameterConflictDemo.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/model/MutableComponentModelImplTest.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/integration/app1/pages/ParameterConflictDemo.tml

                
> Tapestry 5.3 allows a subcomponent to define a parameter with the same name as a base component
> -----------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1675
>                 URL: https://issues.apache.org/jira/browse/TAP5-1675
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>            Priority: Critical
>             Fix For: 5.3
>
>
> I believe you got a more reasonable error message in 5.2. In 5.3 you may get an error if both the fields have @Property, due to a name collision on the getter/setter method names. Instead, Tapestry should fail early explaining that both the component and (the identified base class) define the same parameter name.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira