You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@cordova.apache.org by "Kevin Hawkins (JIRA)" <ji...@apache.org> on 2013/02/20 20:45:14 UTC

[jira] [Commented] (CB-2502) iOS: CDVViewController's commandDelegate property should be typed to the protocol

    [ https://issues.apache.org/jira/browse/CB-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13582466#comment-13582466 ] 

Kevin Hawkins commented on CB-2502:
-----------------------------------

Review is at https://github.com/apache/cordova-ios/pull/18.
                
> iOS: CDVViewController's commandDelegate property should be typed to the protocol
> ---------------------------------------------------------------------------------
>
>                 Key: CB-2502
>                 URL: https://issues.apache.org/jira/browse/CB-2502
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>    Affects Versions: Master
>            Reporter: Kevin Hawkins
>            Assignee: Shazron Abdullah
>            Priority: Minor
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> CDVViewController's commandDelegate property is typed as CDVCommandDelegateImpl, the concrete implementation of the CDVCommandDelegate protocol.  From an object-oriented design standpoint, we want to property to conform to the protocol API, not the implementation.  This would come into play particularly if a consumer was providing their own implementation of the protocol, as an override to the parent class's definition.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira