You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mime4j-dev@james.apache.org by "Tellier Benoit (JIRA)" <mi...@james.apache.org> on 2019/02/11 04:30:00 UTC
[jira] [Commented] (MIME4J-286) Comment wrongly duplicated.
[ https://issues.apache.org/jira/browse/MIME4J-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764659#comment-16764659 ]
Tellier Benoit commented on MIME4J-286:
---------------------------------------
Hi Yann,
Nice catch.
Do you think you would be able to open a pull request for this here? https://github.com/apache/james-mime4j
This would be really nice:
Best regards,
Benoit TELLIER
> Comment wrongly duplicated.
> ---------------------------
>
> Key: MIME4J-286
> URL: https://issues.apache.org/jira/browse/MIME4J-286
> Project: James Mime4j
> Issue Type: Bug
> Components: example
> Affects Versions: master
> Reporter: Yann Barsamian
> Priority: Trivial
> Labels: easyfix
>
> There is a bug in a comment of the following file:
> examples/src/main/java/org/apache/james/mime4j/samples/tree/MessageTree.java
> The documentation (comment
> /**
> * Create a node given a Multipart body.
> * Add the Preamble, all Body parts and the Epilogue to the node.
> *
> * @return the root node of the tree.
> */
> from the function:
> private DefaultMutableTreeNode createNode(Multipart multipart)
> Has been copied/pasted on the function which appears just before
> private DefaultMutableTreeNode createNode(Header header)
> It is quite clear that this other function is not given a multipart body, and is taking a header. The documentation of this function can be easily updated.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)