You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "TUCJVXCB (via GitHub)" <gi...@apache.org> on 2023/09/18 08:22:20 UTC
[GitHub] [camel] TUCJVXCB opened a new pull request, #11437: CAMEL-19879: camel-rest- Add option to set headerfilterStrategy
TUCJVXCB opened a new pull request, #11437:
URL: https://github.com/apache/camel/pull/11437
# Description
wish camel-rest can support custom headerfilterStrategy
# Target
- [X] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [X] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [X] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [X] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes
<!--
You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] TUCJVXCB commented on pull request #11437: CAMEL-19879: camel-rest- Add option to set headerfilterStrategy
Posted by "TUCJVXCB (via GitHub)" <gi...@apache.org>.
TUCJVXCB commented on PR #11437:
URL: https://github.com/apache/camel/pull/11437#issuecomment-1729410001
> the PR says that there are missing files in the commit. If you build camel-catalog, and endpointdsl / componentdsl then there are changed files to be added in the PR.
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] TUCJVXCB commented on pull request #11437: CAMEL-19879: camel-rest- Add option to set headerfilterStrategy
Posted by "TUCJVXCB (via GitHub)" <gi...@apache.org>.
TUCJVXCB commented on PR #11437:
URL: https://github.com/apache/camel/pull/11437#issuecomment-1737226579
> > There are uncommitted changes
>
> I wonder if you could do a rebuild of your PR and find the uncommitted files and add to the PR
>
> ```
> mvn clean install -Dquickly
> ```
it seems that because I manually added a [note] in rest.adoc, I only added it in one place. Do I need to add notes in other documents as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #11437: CAMEL-19879: camel-rest- Add option to set headerfilterStrategy
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11437:
URL: https://github.com/apache/camel/pull/11437#issuecomment-1722954376
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
:warning: Please note that the changes on this PR may be **tested automatically** if they change components.
:robot: Use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] TUCJVXCB commented on pull request #11437: CAMEL-19879: camel-rest- Add option to set headerfilterStrategy
Posted by "TUCJVXCB (via GitHub)" <gi...@apache.org>.
TUCJVXCB commented on PR #11437:
URL: https://github.com/apache/camel/pull/11437#issuecomment-1737241971
> > There are uncommitted changes
>
> I wonder if you could do a rebuild of your PR and find the uncommitted files and add to the PR
>
> ```
> mvn clean install -Dquickly
> ```
i rebuild just now, it just remove that [note]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] TUCJVXCB commented on pull request #11437: CAMEL-19879: camel-rest- Add option to set headerfilterStrategy
Posted by "TUCJVXCB (via GitHub)" <gi...@apache.org>.
TUCJVXCB commented on PR #11437:
URL: https://github.com/apache/camel/pull/11437#issuecomment-1727538072
> > > There is also special code in camel-vertx-http and camel-netty-http that needs adjustments
> >
> >
> > Are you referring to documents or code？
>
> I think code, can you look into these 2 components, they also set a rest based filter startegy by default I assume
Alright, I'll take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] TUCJVXCB commented on pull request #11437: CAMEL-19879: camel-rest- Add option to set headerfilterStrategy
Posted by "TUCJVXCB (via GitHub)" <gi...@apache.org>.
TUCJVXCB commented on PR #11437:
URL: https://github.com/apache/camel/pull/11437#issuecomment-1730953802
> You can build without testing
>
> mvn clean install -D quickly
thanks very much！🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #11437: CAMEL-19879: camel-rest- Add option to set headerfilterStrategy
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11437:
URL: https://github.com/apache/camel/pull/11437#issuecomment-1727470051
There is also special code in camel-vertx-http and camel-netty-http that needs adjustments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] TUCJVXCB commented on pull request #11437: CAMEL-19879: camel-rest- Add option to set headerfilterStrategy
Posted by "TUCJVXCB (via GitHub)" <gi...@apache.org>.
TUCJVXCB commented on PR #11437:
URL: https://github.com/apache/camel/pull/11437#issuecomment-1724714139
alright，i update docs now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #11437: CAMEL-19879: camel-rest- Add option to set headerfilterStrategy
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11437:
URL: https://github.com/apache/camel/pull/11437#issuecomment-1723623783
To make this tolerable, then you could add a note in the docs for camel-rest about using custom header filter strategy, that its recommended to extend the rest based and ensure to call its super methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #11437: CAMEL-19879: camel-rest- Add option to set headerfilterStrategy
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #11437:
URL: https://github.com/apache/camel/pull/11437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] TUCJVXCB commented on pull request #11437: CAMEL-19879: camel-rest- Add option to set headerfilterStrategy
Posted by "TUCJVXCB (via GitHub)" <gi...@apache.org>.
TUCJVXCB commented on PR #11437:
URL: https://github.com/apache/camel/pull/11437#issuecomment-1727508578
> There is also special code in camel-vertx-http and camel-netty-http that needs adjustments
Are you referring to documents or code？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #11437: CAMEL-19879: camel-rest- Add option to set headerfilterStrategy
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11437:
URL: https://github.com/apache/camel/pull/11437#issuecomment-1727525286
> > There is also special code in camel-vertx-http and camel-netty-http that needs adjustments
>
> Are you referring to documents or code？
I think code, can you look into these 2 components, they also set a rest based filter startegy by default I assume
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #11437: CAMEL-19879: camel-rest- Add option to set headerfilterStrategy
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11437:
URL: https://github.com/apache/camel/pull/11437#issuecomment-1729379332
the PR says that there are missing files in the commit. If you build camel-catalog, and endpointdsl / componentdsl then there are changed files to be added in the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #11437: CAMEL-19879: camel-rest- Add option to set headerfilterStrategy
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #11437:
URL: https://github.com/apache/camel/pull/11437#issuecomment-1730812430
You need to fully build the project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #11437: CAMEL-19879: camel-rest- Add option to set headerfilterStrategy
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11437:
URL: https://github.com/apache/camel/pull/11437#issuecomment-1737211112
> There are uncommitted changes
I wonder if you could do a rebuild of your PR and find the uncommitted files and add to the PR
mvn clean install -Dquickly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] TUCJVXCB commented on pull request #11437: CAMEL-19879: camel-rest- Add option to set headerfilterStrategy
Posted by "TUCJVXCB (via GitHub)" <gi...@apache.org>.
TUCJVXCB commented on PR #11437:
URL: https://github.com/apache/camel/pull/11437#issuecomment-1727506673
Are you referring to documents or code？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #11437: CAMEL-19879: camel-rest- Add option to set headerfilterStrategy
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11437:
URL: https://github.com/apache/camel/pull/11437#issuecomment-1725270159
You need to update in the src/main/docs folder - the json file doc is hardcoded via camel-core and cannot be changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] TUCJVXCB commented on pull request #11437: CAMEL-19879: camel-rest- Add option to set headerfilterStrategy
Posted by "TUCJVXCB (via GitHub)" <gi...@apache.org>.
TUCJVXCB commented on PR #11437:
URL: https://github.com/apache/camel/pull/11437#issuecomment-1730815560
> You need to fully build the project.
thx, i will try
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #11437: CAMEL-19879: camel-rest- Add option to set headerfilterStrategy
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11437:
URL: https://github.com/apache/camel/pull/11437#issuecomment-1730910160
You can build without testing
mvn clean install -D quickly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] TUCJVXCB commented on pull request #11437: CAMEL-19879: camel-rest- Add option to set headerfilterStrategy
Posted by "TUCJVXCB (via GitHub)" <gi...@apache.org>.
TUCJVXCB commented on PR #11437:
URL: https://github.com/apache/camel/pull/11437#issuecomment-1730810439
> the PR says that there are missing files in the commit. If you build camel-catalog, and endpointdsl / componentdsl then there are changed files to be added in the PR.
I'm sorry, I followed your instructions to build camel-catalog, and endpointdsl / componentdsl, but there no files are added, only some files are deleted.
<img width="694" alt="image" src="https://github.com/apache/camel/assets/39339597/06603f7e-1dd6-4fe5-a167-968b9f0d98ca">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] TUCJVXCB commented on pull request #11437: CAMEL-19879: camel-rest- Add option to set headerfilterStrategy
Posted by "TUCJVXCB (via GitHub)" <gi...@apache.org>.
TUCJVXCB commented on PR #11437:
URL: https://github.com/apache/camel/pull/11437#issuecomment-1730884850
> You need to fully build the project.
<img width="1885" alt="image" src="https://github.com/apache/camel/assets/39339597/b77892a6-6dec-446f-b4e5-8abbc8f28612">
May I ask what could be the reason for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org