[GitHub] [airflow] jedcunningham commented on a change in pull request #21824: Limits GitHub3.py in order to avoid backtracking

[GitBox <gi...@apache.org>]

jedcunningham commented on a change in pull request #21824:
URL: https://github.com/apache/airflow/pull/21824#discussion_r814987311



##########
File path: setup.py
##########
@@ -599,7 +599,16 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version
     'flake8-colors',
     'flaky',
     'freezegun',
-    'github3.py',
+    # Github3 version 3.1.2 requires PyJWT>=2.3.0 which clashes with Flask App Builder where PyJWT is <2.0.0
+    # Actually GitHub3.1.0 already introduced PyJWT>=2.3.0 but so far `pip` was able to resolve it without
+    # getting into a long backtracking loop and figure out that github3 3.0.0 version is the right version
+    # similarly limiting it to 3.1.2 causes pip not to enter the backtracking loop. Apparently when there
+    # Are 3 versions with PyJWT>=2.3.0 (3.1.0, 3.1.1 an 3.1.2) pip enters into backtrack loop and fails
+    # to resolve that github3 3.0.0 is the right version to use.
+    # This limitation could be removed if PyJWT limitation < 2.0.0 is dropped from FAB or when
+    # pip resolution is improved to handle the case, The issue which describes this PIP behaviour

Review comment:
       ```suggestion
       # pip resolution is improved to handle the case. The issue which describes this PIP behaviour
   ```

##########
File path: setup.py
##########
@@ -599,7 +599,16 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version
     'flake8-colors',
     'flaky',
     'freezegun',
-    'github3.py',
+    # Github3 version 3.1.2 requires PyJWT>=2.3.0 which clashes with Flask App Builder where PyJWT is <2.0.0
+    # Actually GitHub3.1.0 already introduced PyJWT>=2.3.0 but so far `pip` was able to resolve it without
+    # getting into a long backtracking loop and figure out that github3 3.0.0 version is the right version
+    # similarly limiting it to 3.1.2 causes pip not to enter the backtracking loop. Apparently when there
+    # Are 3 versions with PyJWT>=2.3.0 (3.1.0, 3.1.1 an 3.1.2) pip enters into backtrack loop and fails

Review comment:
       ```suggestion
       # are 3 versions with PyJWT>=2.3.0 (3.1.0, 3.1.1 an 3.1.2) pip enters into backtrack loop and fails
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org